From: Pavel Goran <via-bcache@pvgoran.name>
To: Zheng Yongjun <zhengyongjun3@huawei.com>
Cc: colyli@suse.de, kent.overstreet@gmail.com,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next v3] bcache: use DEFINE_MUTEX() for mutex lock
Date: Wed, 7 Apr 2021 19:54:09 +0700 [thread overview]
Message-ID: <807301067.20210407195409@pvgoran.name> (raw)
In-Reply-To: <20210407125000.858219-1-zhengyongjun3@huawei.com>
Hello Zheng,
The third paragraph of the commit description still mentions the .bss
segment.
Wednesday, April 7, 2021, 7:50:00 PM, you wrote:
> mutex lock can be initialized automatically with DEFINE_MUTEX() rather
> than explicitly calling mutex_init().
> this patch will reduce the size of bcache.ko about 16 bytes, the reason
> as follows:
> though this patch will increase the size of .data segment about 32 bytes,
> it will also reduce the size of .init.text and .rodata.str1.1(at x86_64),
> .rodata_str1.8(at arm64) and .bss segment total about 48 bytes which reduce
> the size more than .data segment;
> here is the statistics:
> Sections: (arm64 platform)
> Idx name size
> -.init.text 00000240
> +.init.text 00000228
> -.rodata.str1.8 000012cd
> +.rodata.str1.8 000012b5
> -.data 00000c60
> +.data 00000c80
> Sections: (x86 platform)
> Idx name size
> -.init.text 000001d9
> +.init.text 000001bf
> -.rodata.str1.1 00000c80
> +.rodata.str1.1 00000c6d
> -.data 00000cc0
> +.data 00000ce0
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> v3:
> - change commit log, delete statistic about .bss segment.
> v2:
> - add commit log about the reason why bcache.ko size reduced.
> drivers/md/bcache/super.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 03e1fe4de53d..3635f454309e 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -40,7 +40,7 @@ static const char invalid_uuid[] = {
> };
>
> static struct kobject *bcache_kobj;
> -struct mutex bch_register_lock;
> +DEFINE_MUTEX(bch_register_lock);
> bool bcache_is_reboot;
> LIST_HEAD(bch_cache_sets);
> static LIST_HEAD(uncached_devices);
> @@ -2869,7 +2869,6 @@ static int __init bcache_init(void)
>
> check_module_parameters();
>
> - mutex_init(&bch_register_lock);
> init_waitqueue_head(&unregister_wait);
> register_reboot_notifier(&reboot);
>
Pavel Goran
prev parent reply other threads:[~2021-04-07 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 12:50 [PATCH -next v3] bcache: use DEFINE_MUTEX() for mutex lock Zheng Yongjun
2021-04-07 12:54 ` Pavel Goran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=807301067.20210407195409@pvgoran.name \
--to=via-bcache@pvgoran.name \
--cc=colyli@suse.de \
--cc=hulkci@huawei.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.