From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4178FC48BDF for ; Tue, 15 Jun 2021 23:17:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B456F610CD for ; Tue, 15 Jun 2021 23:17:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B456F610CD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4DF266B006C; Tue, 15 Jun 2021 19:17:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48F296B006E; Tue, 15 Jun 2021 19:17:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 357A16B0070; Tue, 15 Jun 2021 19:17:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id 028486B006C for ; Tue, 15 Jun 2021 19:17:13 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9C8128249980 for ; Tue, 15 Jun 2021 23:17:13 +0000 (UTC) X-FDA: 78257521146.15.B27FB77 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf19.hostedemail.com (Postfix) with ESMTP id 8569A9001460 for ; Tue, 15 Jun 2021 23:17:01 +0000 (UTC) Received: by mail-qv1-f53.google.com with SMTP id r19so625147qvw.5 for ; Tue, 15 Jun 2021 16:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=/eOTxWeFRbmE+ORGXelnrCejeZYr6MNqKVge8AO1rSA=; b=GyvwtapYyfDhwz0r7T88S5oSaRrlWzUKOmXyzVGH+kN8Z5wL0kdJAaI0+IB1TSV9pn 8QLgwNXqBUiL5fvo7PuM7pGMho55+5d/IAyoYVNObR2tczKzJvuoAzb345L34TFnqbv0 ViZD4G/0MHRmUE98Ks/193WasOnhtEN1AyWPp+vNaHe6Pv3Awd2c48QZVb2NP1N/8lg+ obnEV12JdxECcV0tZxEi1szR4B6niX5SDyWiMWh4d5dWOLE5EtpRQQwQ8glG89hTY10f 0vNeN6wOoJa1a/41npvGUjNRFeTZPuAy5yCYxvPWo9gaQonaBxVRVc0BwzNKeKDTcgQA wZ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=/eOTxWeFRbmE+ORGXelnrCejeZYr6MNqKVge8AO1rSA=; b=b0VhOkl43Y8uO7mrjKhiE//fZNPC9XV0pT/UNAMTjJ2JqSy1dJJ1YFmalGQs0W8ePm t+TCqtlz3z1oh/AVLKHOqVd1/eymmpDdSmEYjkI3UEg/PKr1s1107UKqKlyt/I/VotKh gqTSbDR++1fIEput6haM62e0XxKcJyKriuQdr2fnLQSBScrA8tfBi/P94cddxjK1hwqf g2OnJOY80K/aPVlgdyqqg1Sll+g6WCwFEdV1RLM7KL82tueVqF6gJJ6YA6AnSq3tm1gO gwIMneZUzTKPqjPz2WE4Cj/lSZxyNH6z0ve6Wtu/iuCUEvcpOvIa7gEDpzPbLhypWVVo 5Cmg== X-Gm-Message-State: AOAM531zsSWdznLwH4Krbcg/tYzr17AMCf3Sl/eycsxBtjugyHOsuXgX 8R59xVH8v5AmKVG3TdlFjzpuLg== X-Google-Smtp-Source: ABdhPJzqYft+LL0l+haHKcCTwJmHuJH8h8U0Ie3nQvro1v49ba5BACEll25i/olE/lTlYfSknzcaoA== X-Received: by 2002:ad4:4d04:: with SMTP id l4mr2515676qvl.32.1623799032446; Tue, 15 Jun 2021 16:17:12 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id x7sm434975qke.62.2021.06.15.16.17.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 16:17:12 -0700 (PDT) Date: Tue, 15 Jun 2021 16:16:56 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: "Matthew Wilcox (Oracle)" cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 2/5] Fix hugetlb_basepage_index missing prototype warning In-Reply-To: <20210615200242.1716568-3-willy@infradead.org> Message-ID: <8081b4a0-3681-eb15-4bca-7ad2ed10c6ca@google.com> References: <20210615200242.1716568-1-willy@infradead.org> <20210615200242.1716568-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8569A9001460 X-Stat-Signature: ex6mdyxpyeynjr16kqdz5dtw7qhyysyt Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=GyvwtapY; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of hughd@google.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=hughd@google.com X-HE-Tag: 1623799021-60361 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 15 Jun 2021, Matthew Wilcox (Oracle) wrote: > -Wmissing-prototypes requires that the prototype actually be in scope, > not just previously seen. Move it outside page_to_pgoff(). > > Signed-off-by: Matthew Wilcox (Oracle) Thanks Matthew: Acked-by: Hugh Dickins but Andrew please just add as a -fix.patch to mm-futex-fix-shared-futex-pgoff-on-shmem-huge-page.patch and merge them in due course - thank you. > --- > include/linux/pagemap.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index 5f0582de24e7..c4b1514818ff 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -585,16 +585,16 @@ static inline pgoff_t page_to_index(struct page *page) > return pgoff; > } > > +extern pgoff_t hugetlb_basepage_index(struct page *page); > + > /* > * Get the offset in PAGE_SIZE (even for hugetlb pages). > * (TODO: hugetlb pages should have ->index in PAGE_SIZE) > */ > static inline pgoff_t page_to_pgoff(struct page *page) > { > - if (unlikely(PageHuge(page))) { > - extern pgoff_t hugetlb_basepage_index(struct page *page); > + if (unlikely(PageHuge(page))) > return hugetlb_basepage_index(page); > - } > return page_to_index(page); > } > > -- > 2.30.2