From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C97ABC74A44 for ; Tue, 14 Mar 2023 03:26:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8F56785D92; Tue, 14 Mar 2023 04:26:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id AF97E85DE9; Tue, 14 Mar 2023 04:26:10 +0100 (CET) Received: from mail-m11874.qiye.163.com (mail-m11874.qiye.163.com [115.236.118.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EA368858FF for ; Tue, 14 Mar 2023 04:26:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11874.qiye.163.com (Hmail) with ESMTPA id 4D38D3C00FB; Tue, 14 Mar 2023 11:25:55 +0800 (CST) Message-ID: <808c67d3-1243-e962-e13e-56bb9aee5d5d@rock-chips.com> Date: Tue, 14 Mar 2023 11:25:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 09/12] mmc: rockchip_dw_mmc: Fix get_mmc_clk return value Content-Language: en-US To: Jonas Karlman , Simon Glass , Philipp Tomsich , Peng Fan , Jaehoon Chung Cc: Jagan Teki , Eugen Hristev , u-boot@lists.denx.de References: <20230314003755.512696-1-jonas@kwiboo.se> <20230314003755.512696-10-jonas@kwiboo.se> From: Kever Yang In-Reply-To: <20230314003755.512696-10-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGkoaT1ZIQkpIGE4YQkpCTh5VEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSkpLSEpMVUpLS1VLWQ Y+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NC46GSo6ET0VMS0jQxE6GD1I LjkaCTFVSlVKTUxDTE1PSE5OQkpIVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFJQ05PNwY+ X-HM-Tid: 0a86de272fb62eb0kusn4d38d3c00fb X-HM-MType: 1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2023/3/14 08:38, Jonas Karlman wrote: > The get_mmc_clk ops is expected to set a clock rate and return the > configured rate as an unsigned value. However, if clk_set_rate fails, > e.g. using a fixed rate clock, a negative error value is returned. > > The mmc core will treat this as a valid unsigned rate and tries to > configure a divider based on this bogus clock rate. > > Use 0 as the return value when setting clock rate fails, the mmc core > will configure to use bypass mode instead of using a bogus divider. > > Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever > --- > drivers/mmc/rockchip_dw_mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/rockchip_dw_mmc.c b/drivers/mmc/rockchip_dw_mmc.c > index 3661ce33143e..72c820ee6330 100644 > --- a/drivers/mmc/rockchip_dw_mmc.c > +++ b/drivers/mmc/rockchip_dw_mmc.c > @@ -52,7 +52,7 @@ static uint rockchip_dwmmc_get_mmc_clk(struct dwmci_host *host, uint freq) > ret = clk_set_rate(&priv->clk, freq); > if (ret < 0) { > debug("%s: err=%d\n", __func__, ret); > - return ret; > + return 0; > } > > return freq;