From: Joe Perches <joe@perches.com>
To: Zong Li <zong.li@sifive.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Subject: Re: [PATCH] scripts/Lindent: increase the maximum line length to 100
Date: Fri, 03 Jul 2020 01:51:51 -0700 [thread overview]
Message-ID: <80902e5d0d5ef752e71672e9c5794d0f5f9ccd15.camel@perches.com> (raw)
In-Reply-To: <050476a0ee608046569588936394159d650ab535.1593763492.git.zong.li@sifive.com>
On Fri, 2020-07-03 at 16:08 +0800, Zong Li wrote:
> As the patch 'bdc48fa11e46 ("checkpatch/coding-style: deprecate
> 80-column warning")', increase the default limit to 100 characters,
> we also increase the maximum line length to 100 for indent script.
I'd prefer to delete Lindent instead.
Also any reformatting tool like this will
_always_ use up to whatever the maximum
line length is rather than use a preferred
length of 80 and and only use the allowed
maximum length of 100 when necessary for
human readability.
> Signed-off-by: Zong Li <zong.li@sifive.com>
> ---
> scripts/Lindent | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Lindent b/scripts/Lindent
> index 1688c44c2df6..11f14a4f2048 100755
> --- a/scripts/Lindent
> +++ b/scripts/Lindent
> @@ -1,7 +1,7 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
>
> -PARAM="-npro -kr -i8 -ts8 -sob -l80 -ss -ncs -cp1"
> +PARAM="-npro -kr -i8 -ts8 -sob -l100 -ss -ncs -cp1"
>
> RES=`indent --version | cut -d' ' -f3`
> if [ "$RES" = "" ]; then
next prev parent reply other threads:[~2020-07-03 8:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 8:08 [PATCH] scripts/Lindent: increase the maximum line length to 100 Zong Li
2020-07-03 8:51 ` Joe Perches [this message]
2020-07-03 9:19 ` Zong Li
2020-07-03 9:39 ` Miguel Ojeda
2020-07-03 9:41 ` Miguel Ojeda
2020-07-03 9:51 ` Joe Perches
2020-07-03 10:22 ` Zong Li
2020-07-03 10:32 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80902e5d0d5ef752e71672e9c5794d0f5f9ccd15.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.