From: Johannes Berg <johannes@sipsolutions.net>
To: Aloka Dixit <quic_alokad@quicinc.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 3/6] wifi: nl80211: configure puncturing in NL80211_CMD_CHANNEL_SWITCH
Date: Mon, 30 Jan 2023 09:43:19 +0100 [thread overview]
Message-ID: <80942093ceebd3978dea562de42f618c7d9d5450.camel@sipsolutions.net> (raw)
In-Reply-To: <20230130072239.26345-4-quic_alokad@quicinc.com>
On Sun, 2023-01-29 at 23:22 -0800, Aloka Dixit wrote:
>
> + * @punct_bitmap: Preamble puncturing bitmap. Each bit represents a 20 MHz
> + * channel with lowest bit corresponding to the lowest frequency. Bit set
> + * to 1 indicates that the channel is punctured. Higher 16 bits are
> + * currently unused.
> @@ -1384,6 +1388,7 @@ struct cfg80211_csa_settings {
> bool radar_required;
> bool block_tx;
> u8 count;
> + u32 punct_bitmap;
again internally I think we can stick to u16 for now
> +++ b/net/mac80211/cfg.c
> @@ -1297,9 +1297,8 @@ static int ieee80211_start_ap(struct wiphy *wiphy, struct net_device *dev,
> }
>
> if (params->eht_cap) {
> - if (!ieee80211_valid_disable_subchannel_bitmap(
> - ¶ms->punct_bitmap,
> - params->chandef.width))
> + if (!ieee80211_valid_disable_subchannel_bitmap(¶ms->punct_bitmap,
> + params->chandef.width))
> return -EINVAL;
That got rebased into the wrong patch maybe?
johannes
next prev parent reply other threads:[~2023-01-30 8:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 7:22 [PATCH v3 0/6] Puncturing support in AP mode Aloka Dixit
2023-01-30 7:22 ` [PATCH v3 1/6] wifi: nl80211: configure puncturing bitmap in NL80211_CMD_START_AP Aloka Dixit
2023-01-30 8:40 ` Johannes Berg
2023-01-30 19:35 ` Aloka Dixit
2023-01-30 19:40 ` Aloka Dixit
2023-01-30 7:22 ` [PATCH v3 2/6] wifi: mac80211: validate and configure puncturing bitmap in start_ap() Aloka Dixit
2023-01-30 8:42 ` Johannes Berg
2023-01-30 7:22 ` [PATCH v3 3/6] wifi: nl80211: configure puncturing in NL80211_CMD_CHANNEL_SWITCH Aloka Dixit
2023-01-30 8:43 ` Johannes Berg [this message]
2023-01-30 7:22 ` [PATCH v3 4/6] wifi: mac80211: configure puncturing bitmap in channel_switch() Aloka Dixit
2023-01-30 8:44 ` Johannes Berg
2023-01-30 7:22 ` [PATCH v3 5/6] wifi: cfg80211: add puncturing bitmap in channel switch notifications Aloka Dixit
2023-01-30 8:45 ` Johannes Berg
2023-01-30 7:22 ` [PATCH v3 6/6] wifi: nl80211: add puncturing bitmap in channel switch events Aloka Dixit
2023-01-30 8:48 ` [PATCH v3 0/6] Puncturing support in AP mode Johannes Berg
2023-01-30 19:44 ` Aloka Dixit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80942093ceebd3978dea562de42f618c7d9d5450.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_alokad@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.