From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752525AbeEOIbF (ORCPT ); Tue, 15 May 2018 04:31:05 -0400 Received: from lb3-smtp-cloud9.xs4all.net ([194.109.24.30]:55691 "EHLO lb3-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752139AbeEOIbD (ORCPT ); Tue, 15 May 2018 04:31:03 -0400 Subject: Re: [RFC PATCH 5/5] media: platform: Add Chrome OS EC CEC driver To: Neil Armstrong , airlied@linux.ie, hans.verkuil@cisco.com, lee.jones@linaro.org, olof@lixom.net, seanpaul@google.com Cc: sadolfsson@google.com, felixe@google.com, bleung@google.com, darekm@google.com, marcheu@chromium.org, fparent@baylibre.com, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1526337639-3568-1-git-send-email-narmstrong@baylibre.com> <1526337639-3568-6-git-send-email-narmstrong@baylibre.com> <331d45a4-e496-d0f0-5a0b-ead2cc66da6f@xs4all.nl> <43b84663-da56-25fd-8e16-ba67f5a7c762@baylibre.com> From: Hans Verkuil Message-ID: <809adc05-90a1-03f4-d0d6-23cd47f0da1a@xs4all.nl> Date: Tue, 15 May 2018 10:30:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <43b84663-da56-25fd-8e16-ba67f5a7c762@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfKQ7IuwhtIBn7TL45/rIezhmkwaVFRfN1TkCXwblD/A/Igy4fvULP6Mdoo+mpKcEbLP7sFEl33E0G7gJNzF8wytb5YQjx9IUWwwtTOjxoh5LbSHwk5a5 XF3/GGJIdAJBSjJ3urxzdI+5omnCY175L6q86SLALE519VgO/g9s7cR0zfLKoT5eC8DBkPbFSjS8hjb6gPRtzTQYOB+CVCjRi32Qhg32Fp/VbBfzAWvrzHGQ UyH6VuVG5k8FmzqnTFK4LVJCdHVUOHgPdZnwBIXxP37QHhfK9ilStXal32s5WbSNoUqCiTitRHrzde2o0yuw2U2kVLcG7pVziLOIzaPUJDglDQEUR1jIirA/ xyPfEz4EjvVkORB1ab7uVDrL9KQqpRy2WumyJypiWfowpIgf/IMI/RvsY/RKRcytYGly4XN7sh8lJs139o++Q0aKyFdM0Ff/HVC8OPpBbosDD3+Es9o5k8pG 5W7wjsK8PtSPpBPp6gDoPIZ9hSH4excYqjSCPRfpfL2TEVAP1SVrXVZ5UWBALRDP8UYXL2FhhFGIXHUYnyRDoVZCcbWDxSD9m3kz/4hl9opCa+zltEz6K05G NKA6dPwP4c8a/sj8eOpNV1KxwK9wLB3bDynbgQQ7ZX+X1M11l/ym5+/CHwYfkJMtNhG5Db7L4FAkhUy/DuehyhaUCU4GJFt+b1QutXzc+sgYEhfKeFfDDWNX WX2G8mYv7srONoCTwH1kdC3ZC8vNYdG6wZLh4SyGOMUxo3SS/+tHPZuhkB7MJkkc8SSMX8QXcWhUy6Zl5JqxJGMvbuj2axILpXgANwruEmR2mDgAvaWMEQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/15/18 10:28, Neil Armstrong wrote: >>>>> + int ret; >>>>> + >>>>> + cros_ec_cec = devm_kzalloc(&pdev->dev, sizeof(*cros_ec_cec), >>>>> + GFP_KERNEL); >>>>> + if (!cros_ec_cec) >>>>> + return -ENOMEM; >>>>> + >>>>> + platform_set_drvdata(pdev, cros_ec_cec); >>>>> + cros_ec_cec->cros_ec = cros_ec; >>>>> + >>>>> + ret = cros_ec_cec_get_notifier(&cros_ec_cec->notify); >>>>> + if (ret) { >>>>> + dev_warn(&pdev->dev, "no CEC notifier available\n"); >>>>> + cec_caps |= CEC_CAP_PHYS_ADDR; >>>> >>>> Can this happen? What hardware has this? I am strongly opposed to CEC drivers >>>> using this capability unless there is no other option. It's a pain for userspace. >>> >>> It's in case an HW having a CEC capable FW but not in the cec_dmi_match_table, in this case >>> it won't fail but still enable the CEC interface without a notifier. >> >> I don't think that's a good idea. CAP_PHYS_ADDR should *only* be used in situations >> where it is truly impossible to tell which output is connected to the CEC adapter. >> That's the case with e.g. USB CEC dongles where you have no idea how the user >> connected the HDMI cables. >> >> But I assume that in this case it just means that the cec_dmi_match_table needs >> to be updated, i.e. it is a driver bug. > > Yep, maybe a dev_warn should be added to notify this bug ? Yes, a dev_warn and then return -ENODEV. > >> >> Another thing: this driver assumes that there is only one CEC adapter for only >> one HDMI output. But what if there are more HDMI outputs? Will there be one >> CEC adapter for each output? Or does the hardware have no provisions for that? > > The current EC interface only exposes a single CEC interface for now, there is no > plan yet for multiple HDMI outputs handling. > >> >> Something should be mentioned about this in a comment. > > Ok Thanks! Hans From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Subject: Re: [RFC PATCH 5/5] media: platform: Add Chrome OS EC CEC driver Date: Tue, 15 May 2018 10:30:57 +0200 Message-ID: <809adc05-90a1-03f4-d0d6-23cd47f0da1a@xs4all.nl> References: <1526337639-3568-1-git-send-email-narmstrong@baylibre.com> <1526337639-3568-6-git-send-email-narmstrong@baylibre.com> <331d45a4-e496-d0f0-5a0b-ead2cc66da6f@xs4all.nl> <43b84663-da56-25fd-8e16-ba67f5a7c762@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <43b84663-da56-25fd-8e16-ba67f5a7c762@baylibre.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Neil Armstrong , airlied@linux.ie, hans.verkuil@cisco.com, lee.jones@linaro.org, olof@lixom.net, seanpaul@google.com Cc: sadolfsson@google.com, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, fparent@baylibre.com, felixe@google.com, bleung@google.com, darekm@google.com, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gMDUvMTUvMTggMTA6MjgsIE5laWwgQXJtc3Ryb25nIHdyb3RlOgo+Pj4+PiArCWludCByZXQ7 Cj4+Pj4+ICsKPj4+Pj4gKwljcm9zX2VjX2NlYyA9IGRldm1fa3phbGxvYygmcGRldi0+ZGV2LCBz aXplb2YoKmNyb3NfZWNfY2VjKSwKPj4+Pj4gKwkJCQkgICBHRlBfS0VSTkVMKTsKPj4+Pj4gKwlp ZiAoIWNyb3NfZWNfY2VjKQo+Pj4+PiArCQlyZXR1cm4gLUVOT01FTTsKPj4+Pj4gKwo+Pj4+PiAr CXBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIGNyb3NfZWNfY2VjKTsKPj4+Pj4gKwljcm9zX2Vj X2NlYy0+Y3Jvc19lYyA9IGNyb3NfZWM7Cj4+Pj4+ICsKPj4+Pj4gKwlyZXQgPSBjcm9zX2VjX2Nl Y19nZXRfbm90aWZpZXIoJmNyb3NfZWNfY2VjLT5ub3RpZnkpOwo+Pj4+PiArCWlmIChyZXQpIHsK Pj4+Pj4gKwkJZGV2X3dhcm4oJnBkZXYtPmRldiwgIm5vIENFQyBub3RpZmllciBhdmFpbGFibGVc biIpOwo+Pj4+PiArCQljZWNfY2FwcyB8PSBDRUNfQ0FQX1BIWVNfQUREUjsKPj4+Pgo+Pj4+IENh biB0aGlzIGhhcHBlbj8gV2hhdCBoYXJkd2FyZSBoYXMgdGhpcz8gSSBhbSBzdHJvbmdseSBvcHBv c2VkIHRvIENFQyBkcml2ZXJzCj4+Pj4gdXNpbmcgdGhpcyBjYXBhYmlsaXR5IHVubGVzcyB0aGVy ZSBpcyBubyBvdGhlciBvcHRpb24uIEl0J3MgYSBwYWluIGZvciB1c2Vyc3BhY2UuCj4+Pgo+Pj4g SXQncyBpbiBjYXNlIGFuIEhXIGhhdmluZyBhIENFQyBjYXBhYmxlIEZXIGJ1dCBub3QgaW4gdGhl IGNlY19kbWlfbWF0Y2hfdGFibGUsIGluIHRoaXMgY2FzZQo+Pj4gaXQgd29uJ3QgZmFpbCBidXQg c3RpbGwgZW5hYmxlIHRoZSBDRUMgaW50ZXJmYWNlIHdpdGhvdXQgYSBub3RpZmllci4KPj4KPj4g SSBkb24ndCB0aGluayB0aGF0J3MgYSBnb29kIGlkZWEuIENBUF9QSFlTX0FERFIgc2hvdWxkICpv bmx5KiBiZSB1c2VkIGluIHNpdHVhdGlvbnMKPj4gd2hlcmUgaXQgaXMgdHJ1bHkgaW1wb3NzaWJs ZSB0byB0ZWxsIHdoaWNoIG91dHB1dCBpcyBjb25uZWN0ZWQgdG8gdGhlIENFQyBhZGFwdGVyLgo+ PiBUaGF0J3MgdGhlIGNhc2Ugd2l0aCBlLmcuIFVTQiBDRUMgZG9uZ2xlcyB3aGVyZSB5b3UgaGF2 ZSBubyBpZGVhIGhvdyB0aGUgdXNlcgo+PiBjb25uZWN0ZWQgdGhlIEhETUkgY2FibGVzLgo+Pgo+ PiBCdXQgSSBhc3N1bWUgdGhhdCBpbiB0aGlzIGNhc2UgaXQganVzdCBtZWFucyB0aGF0IHRoZSBj ZWNfZG1pX21hdGNoX3RhYmxlIG5lZWRzCj4+IHRvIGJlIHVwZGF0ZWQsIGkuZS4gaXQgaXMgYSBk cml2ZXIgYnVnLgo+IAo+IFllcCwgbWF5YmUgYSBkZXZfd2FybiBzaG91bGQgYmUgYWRkZWQgdG8g bm90aWZ5IHRoaXMgYnVnID8KClllcywgYSBkZXZfd2FybiBhbmQgdGhlbiByZXR1cm4gLUVOT0RF Vi4KCj4gCj4+Cj4+IEFub3RoZXIgdGhpbmc6IHRoaXMgZHJpdmVyIGFzc3VtZXMgdGhhdCB0aGVy ZSBpcyBvbmx5IG9uZSBDRUMgYWRhcHRlciBmb3Igb25seQo+PiBvbmUgSERNSSBvdXRwdXQuIEJ1 dCB3aGF0IGlmIHRoZXJlIGFyZSBtb3JlIEhETUkgb3V0cHV0cz8gV2lsbCB0aGVyZSBiZSBvbmUK Pj4gQ0VDIGFkYXB0ZXIgZm9yIGVhY2ggb3V0cHV0PyBPciBkb2VzIHRoZSBoYXJkd2FyZSBoYXZl IG5vIHByb3Zpc2lvbnMgZm9yIHRoYXQ/Cj4gCj4gVGhlIGN1cnJlbnQgRUMgaW50ZXJmYWNlIG9u bHkgZXhwb3NlcyBhIHNpbmdsZSBDRUMgaW50ZXJmYWNlIGZvciBub3csIHRoZXJlIGlzIG5vCj4g cGxhbiB5ZXQgZm9yIG11bHRpcGxlIEhETUkgb3V0cHV0cyBoYW5kbGluZy4KPiAKPj4KPj4gU29t ZXRoaW5nIHNob3VsZCBiZSBtZW50aW9uZWQgYWJvdXQgdGhpcyBpbiBhIGNvbW1lbnQuCj4gCj4g T2sKClRoYW5rcyEKCglIYW5zCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=