From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98905C04A68 for ; Wed, 27 Jul 2022 13:56:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2FC008407F; Wed, 27 Jul 2022 15:56:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="ZKYE6nqo"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 65FA28407F; Wed, 27 Jul 2022 15:56:15 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2D2A583FAE for ; Wed, 27 Jul 2022 15:56:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1658930168; bh=KmG8UWIrtrvENWZSHEwtHOi449Q5nqIusafAwe9/a2k=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References:In-Reply-To; b=ZKYE6nqoBsDxHbg+jBruE5Wnda8+AoXFABXXfK+5lHBIv/LlpWgun4G4RoblE0Cq9 ey1qRizxaDAgk3wisKziHD5z2nLuu/trqr6N4jZ2ZRepFQTZpWbj9n/tOS5YgmPmlb WSdrdDPD7pXJlo22Haq9RW31+L114eWo9IY4vADs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.8.186] ([87.49.44.169]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MCbEp-1o8CvT0jYp-009i5w; Wed, 27 Jul 2022 15:56:08 +0200 Message-ID: <809d36a7-12a8-669b-e9e5-07a398e0f746@gmx.de> Date: Wed, 27 Jul 2022 15:56:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.0 Subject: Re: [PATCH v4] Improve Windows build documentation Content-Language: en-US From: Heinrich Schuchardt To: Martin Bonner Cc: Bin Meng , u-boot@lists.denx.de References: <18521899-b63c-6f91-971e-3efb6067fdb9@gmx.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Hsb82zUsuuLiYSgzOTWiFozFOPeWRQ1z4/ATWrnwSCnoue/Dj5o E8eYzacjXVN0xO9u7zxEC3fyhGleN9s1m0V3k3K+MhME9Vcl1XK3QOU53lDfmmzDetCF99o 9g4e/r4O/doCv0s+kb55KrcAQwkOMPq8SEJv3Pb7S2BmO8yndJln6xKq84FYqpTAHj8gJkN G23kWAL7QyOoyaNuOStAw== X-UI-Out-Filterresults: notjunk:1;V03:K0:CQXmuLTLwQY=:kaN+/qX1wnj+iD0OwrNwFt +1U8uYuej8oT9oiqaQ1mN4n8q2Ru0pevrHV8Les43dc2ecDqBirT9NdPz97Unas5l3ETf41Wg y0gYW8Uhyl+FiszcYNm5rHMzXKLjW5fL/IVy+hWk/lBE7Yf7DYWFdut8UjAIXQOO8vj58+ZL7 fNXckRObiDpgr6fd+ejoaSMdWEfCFNj/LiFAgmEJ893VEdqn3Wf9OkWzhSpB6bxZ/sHy5B5u2 yBH7K/FqYpnBjaOkd25gn9heujJhfw3M1jKl//IV6ucyzwmTgu0JjGin+FqGJK7f3JNUg75PV oKtMgR1063pb49dYc2MGHW2/J0J8J2o7FKWsx3wIrzsoz3T6zodj0L8VF0Yb5yNOvshbXY69k 9yVPQN33cegyWzsEFlUr6b2x7RafbLoxKBLh1EkC5FFA0kVT/wsLjTm/ytprM3/1RdFu7OjK3 VDmMJRWQo/OhbyM59JBC5mk5kxLw38T3NPNPqvpkKgp1RWApdF9wseWpoFmaTVUyc1qH+j2GQ A7/Jbgv714JD0xS4yuMBIXkT6aaTt3FySr1TeRqbvk3x53OdIt4bibBFeC5X08TmTynCz4ecz 5TPY3r38JUZuD/QE4D9iGLhsTUhIOGwcB+ci0VmwtoUifZUZLu5a9uekYBPj01dZj697/JSfd HWnIWAvQALrcmgzblMQc4yRHWqjTTXReGQnAxQco51Jd9JhQyaIvgpE53pauIPGocZKPWcx3L bS8OV9SY9W3LejE+tvjuCcl/ttA4yfLgxg89dnc5VieYPyfr043LO9vwrInNR9J6k0Ocz3cwv aFfljKlipPH8kgq5vhuwjuaLhPNYaG2m3Q+WACAIjVpF4jQxxfD+IHZCYxGtY61x5mRFOQ5Tt elJWvMg0i/wxtqlKkxVafCjEaBtcuW6znpWE94vh+gK8J/tnFfLmfxRPc8hQjfd99g9bP+oHl QWjDICHdKQ3ggofcXjsEXnshSm+GkjUN2cu0nFjKdhK6J1xxeEMuaaqcoNFbl8BVH58tqzCrP U+Otj7mbWBfanA4SQUKHISFp7boW9K87gbOMTz1RpTpNgbj/auIdl7Eh0/gq1KJ25PXfMTYsa izBLnT4hcSJ+JRdydPrDO3a+86H2eb56o742xKTy/wS57tJMZzWCtFZNA== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 7/27/22 15:51, Heinrich Schuchardt wrote: > On 7/27/22 15:29, Heinrich Schuchardt wrote: >> On 7/25/22 09:42, Martin Bonner wrote: >>> * Add three more modules that are required. >>> * Remove the version numbers (because they are hard to keep in sync >>> =C2=A0=C2=A0 with the latest MSYS2 versions) >>> * Add a pacman command line to install everything. >>> >>> Signed-off-by: Martin Bonner >> >> Your mail is not a valid patch: >> >> $ git am /tmp/0.patch >> Applying: Improve Windows build documentation >> error: corrupt patch at line 10 >> Patch failed at 0001 Improve Windows build documentation >> >> Please, use 'git send-email' for sending patches. >> >> Best regards >> >> Heinrich >> >>> --- >>> =C2=A0 doc/build/tools.rst | 22 ++++++++++++++-------- >>> =C2=A0 1 file changed, 14 insertions(+), 8 deletions(-) >>> >>> diff --git a/doc/build/tools.rst b/doc/build/tools.rst >>> index c06f915274..5f8a04a31b 100644 >>> --- a/doc/build/tools.rst >>> +++ b/doc/build/tools.rst >>> @@ -24,14 +24,20 @@ you can use MSYS2, a software distro and building >>> platform for Windows. >>> =C2=A0 Download the MSYS2 installer from https://www.msys2.org. Make s= ure >>> you have >>> =C2=A0 installed all required packages below in order to build these h= ost >>> tools:: >>> >>> -=C2=A0=C2=A0 * gcc (9.1.0) >>> -=C2=A0=C2=A0 * make (4.2.1) >>> -=C2=A0=C2=A0 * bison (3.4.2) >>> -=C2=A0=C2=A0 * diffutils (3.7) >>> -=C2=A0=C2=A0 * openssl-devel (1.1.1.d) >>> - >>> -Note the version numbers in these parentheses above are the package >>> versions >>> -at the time being when writing this document. The MSYS2 installer >>> tested is >>> +=C2=A0=C2=A0 * gcc >>> +=C2=A0=C2=A0 * make >>> +=C2=A0=C2=A0 * bison >>> +=C2=A0=C2=A0 * diffutils >>> +=C2=A0=C2=A0 * openssl-devel >>> +=C2=A0=C2=A0 * flex >>> +=C2=A0=C2=A0 * libgnutls-devel >>> +=C2=A0=C2=A0 * libuuid-devel > > This should not be pre-formatted text but simply a list. > >>> + >>> +You probably want ``git`` as well.=C2=A0 You can install all these wi= th:: > > Allow for syntax highlighting: > > .. code-block:: bash > >>> + >>> +=C2=A0=C2=A0=C2=A0 $ pacman -S gcc make bison diffutils openssl-devel= flex >>> libgnutls-devel libuuid-devel git > > The line should be limited to 80 characters. Use \. > Please, remove the leading $. > > Best regards > > Heinrich > >>> + >>> +The MSYS2 installer tested is >>> =C2=A0 http://repo.msys2.org/distrib/x86_64/msys2-x86_64-20190524.exe. Do you really suggest to download a 3 year old version? Shouldn't we simply remove this sentence? Best regards Heinrich >>> >>> =C2=A0 There are 3 MSYS subsystems installed: MSYS2, MinGW32 and MinGW= 64. >>> Each >>> -- >>> Martin Bonner >