From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2CE8C6FD18 for ; Fri, 31 Mar 2023 08:12:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231461AbjCaIMY (ORCPT ); Fri, 31 Mar 2023 04:12:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231140AbjCaIMW (ORCPT ); Fri, 31 Mar 2023 04:12:22 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19C1F26BD for ; Fri, 31 Mar 2023 01:12:20 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pi9rc-00078K-Vo; Fri, 31 Mar 2023 10:12:01 +0200 Message-ID: <809d5523-e0b4-cad4-f6ab-ddc0e4fe482d@pengutronix.de> Date: Fri, 31 Mar 2023 10:11:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH V3 7/7] arm64: dts: imx8mp: add interconnect for hsio blk ctrl Content-Language: en-US To: Markus Niebel , Greg Ungerer , Marco Felsch Cc: peng.fan@nxp.com, Alexander Stein , abailon@baylibre.com, krzysztof.kozlowski+dt@linaro.org, festevam@gmail.com, abelvesa@kernel.org, marex@denx.de, paul.elder@ideasonboard.com, linux-imx@nxp.com, devicetree@vger.kernel.org, "Peng Fan (OSS)" , linux-pm@vger.kernel.org, s.hauer@pengutronix.de, robh+dt@kernel.org, aford173@gmail.com, "linux-arm-kernel@lists.infradead.org" , laurent.pinchart@ideasonboard.com, linux-kernel@vger.kernel.org, kernel@pengutronix.de, djakov@kernel.org, shawnguo@kernel.org, l.stach@pengutronix.de References: <20220703091451.1416264-8-peng.fan@oss.nxp.com> <20230327045037.593326-1-gerg@linux-m68k.org> <2678294.mvXUDI8C0e@steina-w> <20230328073302.jj64u5hvdpc6axa5@pengutronix.de> <426b4776-104c-cb47-c8cc-c26515fcb6e3@linux-m68k.org> <20230328134201.yaxrdtetjygkgkmz@pengutronix.de> <20230328135100.rbmnfelphe7juhxo@pengutronix.de> <20230328151100.msl46qupstwplkgw@pengutronix.de> <792028b9-cd4c-4ff4-a7cb-e60c518aa573@kernel.org> <2924b1a62f126678870160bdbbf4e5d51aceb8d4.camel@ew.tq-group.com> From: Ahmad Fatoum In-Reply-To: <2924b1a62f126678870160bdbbf4e5d51aceb8d4.camel@ew.tq-group.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31.03.23 09:45, Markus Niebel wrote: > Am Freitag, dem 31.03.2023 um 15:55 +1000 schrieb Greg Ungerer: >> On 29/3/23 01:11, Marco Felsch wrote: >>> On 23-03-29, Greg Ungerer wrote: >> I agree this is the problem, I don't agree that the boot loader is >> the >> only place to fix this :-) I should be able to generate a working >> devicetree >> blob from the kernel that is good, and ready to use no runtime >> changes >> required I figure. >> > > Just to point out: the approach of run time fixing in boot loader is > used for the other i.MX8M SOC, too. If you know exactly what SOC type > is assembled, you could disable non available IP in the board part of > your tree. > >> It is not overly difficult to break out the vpu nodes and have them >> only included when you have a board that has the iMX8MP-quad with the >> VPU hardware blocks. This breaks out-of-tree DTs that include imx8mp.dtsi. Logic should be the other way round: imx8mp.dtsi is full-featured SoC and any new includes strip away, not add nodes. > Depending on the SOC type there is more to look for than the VPU: core > count, ISP, NPU - just to mention a few. Current approach allows to > keep a single tree for all types. +1. @Greg, does your board always ship with an i.MX8MPLite? If so, just disable VPUs in your board DT. If it ships with either VPUs available or not and you don't want to do bootloader fixups, you may want to check out Kbuild's ability to apply DT overlays at build time. This would give you separate DTs for each variant while not having an extra file for every combination. Cheers, Ahmad > > Regards, Markus > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C611C6FD18 for ; Fri, 31 Mar 2023 08:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HeYSZGlTw2J1D74jDfpWV0VwZWOpCZg1qgzGgoihk1s=; b=XHUuCW1j89Y7gE xE0SPR6U2+d6YfPZ+Zjl+dP2R/qSqarUspPxQjj9w/iSWo3I+GC5SJ/cnLG30jxUwOM5ww/uLgsUy 37+SqdW5+WJNu6ezNGZsQf/8lSTkMBPEd1R/WqmaCmWUIpVSnZXpTirhXxRuGAi81HttsG+RkMXLS bEOZ13kx6mNTLejJNLinUGZE91yAmJ/gs0W1cJAdAVWamT9wAe8XiJquc7tigvHd2YX1mmJlai7t5 Mk9A0GaNUqnRrUKk0Jmd55xr/I6MzyU4JVPTp2DVZJ3dGmklZ6ewCSP+OIAwH8rftzBAm9Jr43oRM 8pUXNPxL76z3sCxrLZgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pi9sA-006Iqb-2C; Fri, 31 Mar 2023 08:12:34 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pi9s2-006InU-30 for linux-arm-kernel@lists.infradead.org; Fri, 31 Mar 2023 08:12:28 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pi9rc-00078K-Vo; Fri, 31 Mar 2023 10:12:01 +0200 Message-ID: <809d5523-e0b4-cad4-f6ab-ddc0e4fe482d@pengutronix.de> Date: Fri, 31 Mar 2023 10:11:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH V3 7/7] arm64: dts: imx8mp: add interconnect for hsio blk ctrl Content-Language: en-US To: Markus Niebel , Greg Ungerer , Marco Felsch Cc: peng.fan@nxp.com, Alexander Stein , abailon@baylibre.com, krzysztof.kozlowski+dt@linaro.org, festevam@gmail.com, abelvesa@kernel.org, marex@denx.de, paul.elder@ideasonboard.com, linux-imx@nxp.com, devicetree@vger.kernel.org, "Peng Fan (OSS)" , linux-pm@vger.kernel.org, s.hauer@pengutronix.de, robh+dt@kernel.org, aford173@gmail.com, "linux-arm-kernel@lists.infradead.org" , laurent.pinchart@ideasonboard.com, linux-kernel@vger.kernel.org, kernel@pengutronix.de, djakov@kernel.org, shawnguo@kernel.org, l.stach@pengutronix.de References: <20220703091451.1416264-8-peng.fan@oss.nxp.com> <20230327045037.593326-1-gerg@linux-m68k.org> <2678294.mvXUDI8C0e@steina-w> <20230328073302.jj64u5hvdpc6axa5@pengutronix.de> <426b4776-104c-cb47-c8cc-c26515fcb6e3@linux-m68k.org> <20230328134201.yaxrdtetjygkgkmz@pengutronix.de> <20230328135100.rbmnfelphe7juhxo@pengutronix.de> <20230328151100.msl46qupstwplkgw@pengutronix.de> <792028b9-cd4c-4ff4-a7cb-e60c518aa573@kernel.org> <2924b1a62f126678870160bdbbf4e5d51aceb8d4.camel@ew.tq-group.com> From: Ahmad Fatoum In-Reply-To: <2924b1a62f126678870160bdbbf4e5d51aceb8d4.camel@ew.tq-group.com> X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230331_011226_973165_2DB7185B X-CRM114-Status: GOOD ( 23.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31.03.23 09:45, Markus Niebel wrote: > Am Freitag, dem 31.03.2023 um 15:55 +1000 schrieb Greg Ungerer: >> On 29/3/23 01:11, Marco Felsch wrote: >>> On 23-03-29, Greg Ungerer wrote: >> I agree this is the problem, I don't agree that the boot loader is >> the >> only place to fix this :-) I should be able to generate a working >> devicetree >> blob from the kernel that is good, and ready to use no runtime >> changes >> required I figure. >> > > Just to point out: the approach of run time fixing in boot loader is > used for the other i.MX8M SOC, too. If you know exactly what SOC type > is assembled, you could disable non available IP in the board part of > your tree. > >> It is not overly difficult to break out the vpu nodes and have them >> only included when you have a board that has the iMX8MP-quad with the >> VPU hardware blocks. This breaks out-of-tree DTs that include imx8mp.dtsi. Logic should be the other way round: imx8mp.dtsi is full-featured SoC and any new includes strip away, not add nodes. > Depending on the SOC type there is more to look for than the VPU: core > count, ISP, NPU - just to mention a few. Current approach allows to > keep a single tree for all types. +1. @Greg, does your board always ship with an i.MX8MPLite? If so, just disable VPUs in your board DT. If it ships with either VPUs available or not and you don't want to do bootloader fixups, you may want to check out Kbuild's ability to apply DT overlays at build time. This would give you separate DTs for each variant while not having an extra file for every combination. Cheers, Ahmad > > Regards, Markus > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel