From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Jacques Hiblot Date: Thu, 1 Jun 2017 10:59:39 +0200 Subject: [U-Boot] [PATCH v5 3/5] drivers: phy: Set phy->dev to NULL when generic_phy_get_by_index() fails In-Reply-To: <1496304865-23909-4-git-send-email-patrice.chotard@st.com> References: <1496304865-23909-1-git-send-email-patrice.chotard@st.com> <1496304865-23909-4-git-send-email-patrice.chotard@st.com> Message-ID: <809df087-8517-f426-5e10-d3e1cdf36f7f@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Patrice, On 01/06/2017 10:14, patrice.chotard at st.com wrote: > From: Patrice Chotard > > phy->dev need to be set to NULL in case of generic_phy_get_by_index() > fails. Then phy->dev can be used to check if the phy is valid > > Reported-by: Jean-Jacques Hiblot > Signed-off-by: Patrice Chotard > Reviewed-by: Simon Glass > --- > v5: _ none > v4: _ ensure that phy->dev is set to NULL in case of > generic_phy_get_by_index() fails > > drivers/phy/phy-uclass.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/phy-uclass.c b/drivers/phy/phy-uclass.c > index d8b8d58..68e518f 100644 > --- a/drivers/phy/phy-uclass.c > +++ b/drivers/phy/phy-uclass.c > @@ -45,6 +45,7 @@ int generic_phy_get_by_index(struct udevice *dev, int index, > debug("%s(dev=%p, index=%d, phy=%p)\n", __func__, dev, index, phy); > > assert(phy); > + phy->dev = NULL; > ret = dev_read_phandle_with_args(dev, "phys", "#phy-cells", 0, index, > &args); > if (ret) { Reviewed-by: Jean-Jacques Hiblot