From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4353C282C0 for ; Fri, 25 Jan 2019 15:57:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3C39218E2 for ; Fri, 25 Jan 2019 15:57:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=tronnes.org header.i=@tronnes.org header.b="J+zdXcWH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729090AbfAYP5X (ORCPT ); Fri, 25 Jan 2019 10:57:23 -0500 Received: from smtp.domeneshop.no ([194.63.252.55]:41264 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726122AbfAYP5W (ORCPT ); Fri, 25 Jan 2019 10:57:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tronnes.org; s=ds201810; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=/iEQy0u3GPVn3U5+xqQA+Cs/2Du+LC74rX1ka8Pt184=; b=J+zdXcWHVgorP5uNqI0Ca8uKagyW37xZnTldqMKkSkn8NJ12Wphx0BVje6JPyQiee3mw8bbpNldItQfW5JjGKLyVEMnTfHPnYLv2JyUvfhqp24Sq6qj4gJoUlyktMlQ/5iBhc36fB7O0ZgMay5d9oPzc1awBj54jK85k3dJG2G2FSUidIghp4LhvzDpY2FZCKlS7yx3vRgaGBeOPUvEl4p0bY30LZchgGkEIPTr4/MaRB0sib7PrQxnCbr+JAEjMnUiVSjtjyj2OFeGYhHV1YUbFL8mXRqVnDm6xBWGTIqB+xCgqw5mQFoLRwl4hMlhH9t/Uejnvp/BMvNPKW4ciPg==; Received: from 211.81-166-168.customer.lyse.net ([81.166.168.211]:49312 helo=[192.168.10.176]) by smtp.domeneshop.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1gn3r6-0003R5-7T; Fri, 25 Jan 2019 16:57:20 +0100 Subject: Re: [PATCH v3 06/23] drm/qxl: use separate offset spaces for the two slots / ttm memory types. To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: David Airlie , open list , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie References: <20190118122020.27596-1-kraxel@redhat.com> <20190118122020.27596-7-kraxel@redhat.com> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: <80a3d205-78d2-f723-e452-b56c01a73b34@tronnes.org> Date: Fri, 25 Jan 2019 16:57:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190118122020.27596-7-kraxel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Without that ttm offsets are not unique, they can refer to objects > in both VRAM and PRIV memory (aka main and surfaces slot). > > One of those "why things didn't blow up without this" moments. > Probably offset conflicts are rare enough by pure luck. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Subject: Re: [PATCH v3 06/23] drm/qxl: use separate offset spaces for the two slots / ttm memory types. Date: Fri, 25 Jan 2019 16:57:16 +0100 Message-ID: <80a3d205-78d2-f723-e452-b56c01a73b34@tronnes.org> References: <20190118122020.27596-1-kraxel@redhat.com> <20190118122020.27596-7-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190118122020.27596-7-kraxel@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: David Airlie , open list , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie List-Id: dri-devel@lists.freedesktop.org Den 18.01.2019 13.20, skrev Gerd Hoffmann: > Without that ttm offsets are not unique, they can refer to objects > in both VRAM and PRIV memory (aka main and surfaces slot). > > One of those "why things didn't blow up without this" moments. > Probably offset conflicts are rare enough by pure luck. > > Signed-off-by: Gerd Hoffmann > --- Acked-by: Noralf Trønnes