On 12/06/2017 08:45 AM, Stefan Hajnoczi wrote: > QMP 'transaction' blockdev-snapshot-sync with multiple disks in an > IOThread is an untested code path. Several bugs have been found in > connection with this command. This patch adds a test case to prevent > future regressions. > > Signed-off-by: Stefan Hajnoczi > --- > tests/qemu-iotests/202 | 95 ++++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/202.out | 11 ++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 107 insertions(+) > create mode 100755 tests/qemu-iotests/202 > create mode 100644 tests/qemu-iotests/202.out > > +# Creator/Owner: Stefan Hajnoczi There's another cleanup series posted that drops these sorts of lines in favor of git history. > +++ b/tests/qemu-iotests/202.out > @@ -0,0 +1,11 @@ > +Launching VM... > +Adding IOThread... > +{u'return': {}} > +Adding blockdevs... > +{u'return': {}} > +{u'return': {}} > +Setting iothread... > +{u'return': {}} > +{u'return': {}} > +Creating external snapshots... > +{u'return': {}} Yay - a python test with sane output - if I had to, I could actually debug this test without too much effort! Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org