From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E27CCECAAD3 for ; Mon, 5 Sep 2022 16:12:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231277AbiIEQM3 (ORCPT ); Mon, 5 Sep 2022 12:12:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229812AbiIEQMW (ORCPT ); Mon, 5 Sep 2022 12:12:22 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F0B0550BC for ; Mon, 5 Sep 2022 09:12:20 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id bt10so13766118lfb.1 for ; Mon, 05 Sep 2022 09:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=rrWMFV+N+f8aARUW0ZNrAlxPcv8JN7PD06T7jx57Q7s=; b=SS3wEpx17GrNgX9Fc+X/k3B/9tRMakRxRbH8xMVvVDq2ZdruXjZG7LTGx+p+6x1mMu jepfNNJGN6O3or1m/v60nbMJcuavuaBqS1W9ZbCI7/Ya5z3pgt0zpvsfZ+Vf0Gm/heYu eczsXHy88W6Mg1JHIpbb0P7YNYSyzRYzGs+l0DVwXxSOlLg2rcR5CeqOo6OzBjLvGMqL DrJTFyVARk/EwFRMAPsXNAFdKReDopalSto5lm+nfMqaF87QF8hAYfYpMcjonMW2EaP1 wK9l1oULRf5bFySVuoLUYG40Bgn4zumjoEnRwUzL7guqlm2k3GdQGr1Y8UYGB929y+Qm M9dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=rrWMFV+N+f8aARUW0ZNrAlxPcv8JN7PD06T7jx57Q7s=; b=2XuqrAHKZQkfjQqhh2agY7JQPLV2MC9sQ/TCDPNXU+yL9JsPjRDVk++T0tFcFWukVl DlLL2qRwLeV9UEptZjqlSc/rAuBu7g4I21vuGFrftHSzl8YFCrxpcdGahux44cf4dPDA QVu7FTz1DFT3uJpyr7onuqq3Tdc6YcW04NXRztTzQD+szL4SyYwu9RC/e1rZXh9vOJ7P XkUcHjXRvVqhwuoDF7+4Ok2+ObbqL93oWYLbEVjKB5kuFJskoJK2i7StVMO2YEifdG7U 6YjlHS+O6zNdSeK6zXSDXe6nFRzfngq0bT3g+XjbkSrq/pCCZpG+pEo8ZoToCFoT7Lka FEDA== X-Gm-Message-State: ACgBeo1SGb1Kg7lLpIHtFkaQ7UDowAhnXUJYSOLri880ANTRU5rO4AzD fS0r4yk0Ba7e6VRbieNU+vKBKw== X-Google-Smtp-Source: AA6agR5YbCPHG0VF+WgTYH8U/Qyjr4JX1+miUiqvPBNw4ceg3bXl8ITHJX7z4VES5+HrNXJDFKZYSw== X-Received: by 2002:ac2:5ccd:0:b0:495:79c7:f2f7 with SMTP id f13-20020ac25ccd000000b0049579c7f2f7mr3651296lfq.647.1662394338923; Mon, 05 Sep 2022 09:12:18 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id f19-20020ac25333000000b0048a9a756763sm1235025lfh.19.2022.09.05.09.12.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Sep 2022 09:12:18 -0700 (PDT) Message-ID: <80abf192-0313-aade-7780-604f4c9c6810@linaro.org> Date: Mon, 5 Sep 2022 18:12:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 2/5] dt-bindings: mfd: atmel,at91-usart: convert to json-schema Content-Language: en-US To: Sergiu.Moga@microchip.com, lee@kernel.org Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, Claudiu.Beznea@microchip.com, radu_nicolae.pirea@upb.ro, richard.genoud@gmail.com, mturquette@baylibre.com, sboyd@kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, admin@hifiphile.com, Kavyasree.Kotagiri@microchip.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org References: <20220817075517.49575-1-sergiu.moga@microchip.com> <20220817075517.49575-3-sergiu.moga@microchip.com> <942accc5-70aa-3bb2-63dd-306a39ee5ea4@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/09/2022 17:22, Sergiu.Moga@microchip.com wrote: > On 05.09.2022 17:37, Lee Jones wrote: >> >> On Fri, 19 Aug 2022, Sergiu.Moga@microchip.com wrote: >> >>> On 18.08.2022 11:39, Krzysztof Kozlowski wrote: >>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>>> >>>> On 17/08/2022 10:55, Sergiu Moga wrote: >>>>> Convert at91 USART DT Binding for Atmel/Microchip SoCs to >>>>> json-schema format. >>>>> >>>>> Signed-off-by: Sergiu Moga >>>>> --- >>>>> .../bindings/mfd/atmel,at91-usart.yaml | 190 ++++++++++++++++++ >>>>> .../devicetree/bindings/mfd/atmel-usart.txt | 98 --------- >>>>> 2 files changed, 190 insertions(+), 98 deletions(-) >>>>> create mode 100644 Documentation/devicetree/bindings/mfd/atmel,at91-usart.yaml >>>>> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-usart.txt >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/mfd/atmel,at91-usart.yaml >>>>> new file mode 100644 >>>>> index 000000000000..cf15d73fa1e8 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/mfd/atmel,at91-usart.yaml >>>> One more thing - I think this should be in serial directory, not mfd, >>>> even though it includes SPI. MFD is just a Linux naming/wrapper device. >>>> >>>> Best regards, >>>> Krzysztof >>> >>> I would rather keep it in this directory, since its corresponding driver >>> is also in the mfd directory. >> >> Looks like a UART driver to me. >> >> Which MFD driver does this pertain to? >> >> -- >> Lee Jones [李琼斯] > > Hi, > > It's this one: drivers/mfd/at91-usart.c[1] > > > [1] > https://elixir.bootlin.com/linux/v6.0-rc4/source/drivers/mfd/at91-usart.c Which is not a "real MFD driver" because it probes exactly one child (depending on the chosen serial protocol). Aren't MFD supposed to have more then one child? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55E14ECAAD3 for ; Mon, 5 Sep 2022 18:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YVioBgdXEFEIeKqhDfeGX5PlICwJv+LFeXy4ojiakck=; b=yz8r4osru8h8pQ 6JlBYHBqYuR5WfGn5Gw4KiVhVAcYvllQx9VzAkrMfjFtYUQLhnn5Nda9gL8EsFmdv6+Bd9IKtiTlV XNSMHdBmXaVPrVn61YIqRurDtoqwY4heUIhcJL4MOWquPVOXiR14EP7XR0ePxlq5QJdqXztsvZcuJ rU6pl/Rsh/j7UbYQLu805enFnhEbw46Cm/rArPVDQGsWL619Cfc1WIx1QYvvVvuf/NFs7Qlr08/Yx SiXf3qYkx/lv27Q/2S/VLwGIA6C8QqX4YINkptcGOgSzCfIRBoFaCEru43JxzDiyCF/xyxbcB4n3r Jank6GUhF8ht0loyXY4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVGmw-008N4S-Qg; Mon, 05 Sep 2022 18:25:39 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVEhy-006diE-Py for linux-arm-kernel@lists.infradead.org; Mon, 05 Sep 2022 16:12:24 +0000 Received: by mail-lf1-x132.google.com with SMTP id j14so13748028lfu.4 for ; Mon, 05 Sep 2022 09:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=rrWMFV+N+f8aARUW0ZNrAlxPcv8JN7PD06T7jx57Q7s=; b=SS3wEpx17GrNgX9Fc+X/k3B/9tRMakRxRbH8xMVvVDq2ZdruXjZG7LTGx+p+6x1mMu jepfNNJGN6O3or1m/v60nbMJcuavuaBqS1W9ZbCI7/Ya5z3pgt0zpvsfZ+Vf0Gm/heYu eczsXHy88W6Mg1JHIpbb0P7YNYSyzRYzGs+l0DVwXxSOlLg2rcR5CeqOo6OzBjLvGMqL DrJTFyVARk/EwFRMAPsXNAFdKReDopalSto5lm+nfMqaF87QF8hAYfYpMcjonMW2EaP1 wK9l1oULRf5bFySVuoLUYG40Bgn4zumjoEnRwUzL7guqlm2k3GdQGr1Y8UYGB929y+Qm M9dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=rrWMFV+N+f8aARUW0ZNrAlxPcv8JN7PD06T7jx57Q7s=; b=66UcjYnKhVkWMqVt9SptRwKjhg1t535rAaTq/uXeAyo3gdob6IRQ1n0Jt3FSWSSLru 4hYF8CEWhK17RzzEQNV7Q6a5PpKWF804x2vetUMyLnmVn/uqdWnT8cg8he/sJzq4uX7X HUuleD3SplHbAPucXzda+NGFTvD+VOgxtrlzwWU5nktpcy+MK8ylTcSE8UAu+tIL34nz jhE65oK1ZkTU/O0YSfnCc0q54lUUjsIr9rnQ13ZAIE6cNeIxbhPY0O0doBTb85zY0+V/ 3kiBZ4MbRo2vT+IZVAowSctkAtiHhe23Y4I4t8Do3CUHbY0pNY42ifj9UKWbV4NdGK11 WIHA== X-Gm-Message-State: ACgBeo0QLIfFMT5e4LiqxBDXncYw+wcs4ljlr6G3wnh1o068vp8vMuhR TPdV93o0EMm7ztmzD0w9Ywg70A== X-Google-Smtp-Source: AA6agR5YbCPHG0VF+WgTYH8U/Qyjr4JX1+miUiqvPBNw4ceg3bXl8ITHJX7z4VES5+HrNXJDFKZYSw== X-Received: by 2002:ac2:5ccd:0:b0:495:79c7:f2f7 with SMTP id f13-20020ac25ccd000000b0049579c7f2f7mr3651296lfq.647.1662394338923; Mon, 05 Sep 2022 09:12:18 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id f19-20020ac25333000000b0048a9a756763sm1235025lfh.19.2022.09.05.09.12.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Sep 2022 09:12:18 -0700 (PDT) Message-ID: <80abf192-0313-aade-7780-604f4c9c6810@linaro.org> Date: Mon, 5 Sep 2022 18:12:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 2/5] dt-bindings: mfd: atmel,at91-usart: convert to json-schema Content-Language: en-US To: Sergiu.Moga@microchip.com, lee@kernel.org References: <20220817075517.49575-1-sergiu.moga@microchip.com> <20220817075517.49575-3-sergiu.moga@microchip.com> <942accc5-70aa-3bb2-63dd-306a39ee5ea4@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_091223_048126_B691F15B X-CRM114-Status: GOOD ( 17.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, linux-clk@vger.kernel.org, Kavyasree.Kotagiri@microchip.com, richard.genoud@gmail.com, gregkh@linuxfoundation.org, radu_nicolae.pirea@upb.ro, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, admin@hifiphile.com, krzysztof.kozlowski+dt@linaro.org, linux-serial@vger.kernel.org, sboyd@kernel.org, jirislaby@kernel.org, Claudiu.Beznea@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDUvMDkvMjAyMiAxNzoyMiwgU2VyZ2l1Lk1vZ2FAbWljcm9jaGlwLmNvbSB3cm90ZToKPiBP biAwNS4wOS4yMDIyIDE3OjM3LCBMZWUgSm9uZXMgd3JvdGU6Cj4+Cj4+IE9uIEZyaSwgMTkgQXVn IDIwMjIsIFNlcmdpdS5Nb2dhQG1pY3JvY2hpcC5jb20gd3JvdGU6Cj4+Cj4+PiBPbiAxOC4wOC4y MDIyIDExOjM5LCBLcnp5c3p0b2YgS296bG93c2tpIHdyb3RlOgo+Pj4+IEVYVEVSTkFMIEVNQUlM OiBEbyBub3QgY2xpY2sgbGlua3Mgb3Igb3BlbiBhdHRhY2htZW50cyB1bmxlc3MgeW91IGtub3cg dGhlIGNvbnRlbnQgaXMgc2FmZQo+Pj4+Cj4+Pj4gT24gMTcvMDgvMjAyMiAxMDo1NSwgU2VyZ2l1 IE1vZ2Egd3JvdGU6Cj4+Pj4+IENvbnZlcnQgYXQ5MSBVU0FSVCBEVCBCaW5kaW5nIGZvciBBdG1l bC9NaWNyb2NoaXAgU29DcyB0bwo+Pj4+PiBqc29uLXNjaGVtYSBmb3JtYXQuCj4+Pj4+Cj4+Pj4+ IFNpZ25lZC1vZmYtYnk6IFNlcmdpdSBNb2dhIDxzZXJnaXUubW9nYUBtaWNyb2NoaXAuY29tPgo+ Pj4+PiAtLS0KPj4+Pj4gICAgLi4uL2JpbmRpbmdzL21mZC9hdG1lbCxhdDkxLXVzYXJ0LnlhbWwg ICAgICAgIHwgMTkwICsrKysrKysrKysrKysrKysrKwo+Pj4+PiAgICAuLi4vZGV2aWNldHJlZS9i aW5kaW5ncy9tZmQvYXRtZWwtdXNhcnQudHh0ICAgfCAgOTggLS0tLS0tLS0tCj4+Pj4+ICAgIDIg ZmlsZXMgY2hhbmdlZCwgMTkwIGluc2VydGlvbnMoKyksIDk4IGRlbGV0aW9ucygtKQo+Pj4+PiAg ICBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21m ZC9hdG1lbCxhdDkxLXVzYXJ0LnlhbWwKPj4+Pj4gICAgZGVsZXRlIG1vZGUgMTAwNjQ0IERvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZmQvYXRtZWwtdXNhcnQudHh0Cj4+Pj4+Cj4+ Pj4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWZkL2F0 bWVsLGF0OTEtdXNhcnQueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9t ZmQvYXRtZWwsYXQ5MS11c2FydC55YW1sCj4+Pj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4+Pj4+ IGluZGV4IDAwMDAwMDAwMDAwMC4uY2YxNWQ3M2ZhMWU4Cj4+Pj4+IC0tLSAvZGV2L251bGwKPj4+ Pj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9hdG1lbCxhdDkx LXVzYXJ0LnlhbWwKPj4+PiBPbmUgbW9yZSB0aGluZyAtIEkgdGhpbmsgdGhpcyBzaG91bGQgYmUg aW4gc2VyaWFsIGRpcmVjdG9yeSwgbm90IG1mZCwKPj4+PiBldmVuIHRob3VnaCBpdCBpbmNsdWRl cyBTUEkuIE1GRCBpcyBqdXN0IGEgTGludXggbmFtaW5nL3dyYXBwZXIgZGV2aWNlLgo+Pj4+Cj4+ Pj4gQmVzdCByZWdhcmRzLAo+Pj4+IEtyenlzenRvZgo+Pj4KPj4+IEkgd291bGQgcmF0aGVyIGtl ZXAgaXQgaW4gdGhpcyBkaXJlY3RvcnksIHNpbmNlIGl0cyBjb3JyZXNwb25kaW5nIGRyaXZlcgo+ Pj4gaXMgYWxzbyBpbiB0aGUgbWZkIGRpcmVjdG9yeS4KPj4KPj4gTG9va3MgbGlrZSBhIFVBUlQg ZHJpdmVyIHRvIG1lLgo+Pgo+PiBXaGljaCBNRkQgZHJpdmVyIGRvZXMgdGhpcyBwZXJ0YWluIHRv Pwo+Pgo+PiAtLQo+PiBMZWUgSm9uZXMgW+adjueQvOaWr10KPiAKPiBIaSwKPiAKPiBJdCdzIHRo aXMgb25lOiBkcml2ZXJzL21mZC9hdDkxLXVzYXJ0LmNbMV0KPiAKPiAKPiBbMV0gCj4gaHR0cHM6 Ly9lbGl4aXIuYm9vdGxpbi5jb20vbGludXgvdjYuMC1yYzQvc291cmNlL2RyaXZlcnMvbWZkL2F0 OTEtdXNhcnQuYwoKV2hpY2ggaXMgbm90IGEgInJlYWwgTUZEIGRyaXZlciIgYmVjYXVzZSBpdCBw cm9iZXMgZXhhY3RseSBvbmUgY2hpbGQKKGRlcGVuZGluZyBvbiB0aGUgY2hvc2VuIHNlcmlhbCBw cm90b2NvbCkuIEFyZW4ndCBNRkQgc3VwcG9zZWQgdG8gaGF2ZQptb3JlIHRoZW4gb25lIGNoaWxk PwoKCkJlc3QgcmVnYXJkcywKS3J6eXN6dG9mCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==