From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751591AbdGaUnq (ORCPT ); Mon, 31 Jul 2017 16:43:46 -0400 Received: from vern.gendns.com ([206.190.152.46]:40710 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbdGaUno (ORCPT ); Mon, 31 Jul 2017 16:43:44 -0400 Subject: Re: [PATCH v2 0/2] Invert margin colors when terminal is inverted To: Alan Cox Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org References: <1501528185-9976-1-git-send-email-david@lechnology.com> <20170731203025.6a59fdbd@alans-desktop> From: David Lechner Message-ID: <80ad0768-069f-a7e7-2f4f-c0ed6b58b910@lechnology.com> Date: Mon, 31 Jul 2017 15:43:38 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170731203025.6a59fdbd@alans-desktop> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/31/2017 02:30 PM, Alan Cox wrote: > On Mon, 31 Jul 2017 14:09:43 -0500 > David Lechner wrote: > >> This is v2 of "fbcon: Use background color for margins​"[1]. >> >> It turns out that using the text background color was not a good choice. So, >> I've started over. > > Can you explain why making the margins simply match the border colour > (when possible) isn't a better option ? They are after all simply > software extensions to the border. > So, basically, you are proposing that it would be better to add a module parameter to select the margin color? That does sound like a better option to me. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Lechner Date: Mon, 31 Jul 2017 20:43:38 +0000 Subject: Re: [PATCH v2 0/2] Invert margin colors when terminal is inverted Message-Id: <80ad0768-069f-a7e7-2f4f-c0ed6b58b910@lechnology.com> List-Id: References: <1501528185-9976-1-git-send-email-david@lechnology.com> <20170731203025.6a59fdbd@alans-desktop> In-Reply-To: <20170731203025.6a59fdbd@alans-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: Alan Cox Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org On 07/31/2017 02:30 PM, Alan Cox wrote: > On Mon, 31 Jul 2017 14:09:43 -0500 > David Lechner wrote: >=20 >> This is v2 of "fbcon: Use background color for margins=E2=80=8B"[1]. >> >> It turns out that using the text background color was not a good choice.= So, >> I've started over. >=20 > Can you explain why making the margins simply match the border colour > (when possible) isn't a better option ? They are after all simply > software extensions to the border. >=20 So, basically, you are proposing that it would be better to add a module=20 parameter to select the margin color? That does sound like a better=20 option to me.