From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Michal Marek <michal.lkml@markovi.net>,
linux-kbuild@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
Nathan Chancellor <nathan@kernel.org>,
clang-built-linux@googlegroups.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH kernel v2] powerpc/makefile: Do not redefine $(CPP) for preprocessor
Date: Wed, 12 May 2021 13:48:53 +1000 [thread overview]
Message-ID: <80ae1561-ed8d-cf3a-f3bb-d89cd07bfc24@ozlabs.ru> (raw)
In-Reply-To: <20210511231635.GR10366@gate.crashing.org>
On 5/12/21 09:16, Segher Boessenkool wrote:
> On Tue, May 11, 2021 at 11:30:17PM +1000, Alexey Kardashevskiy wrote:
>>> In any case, please mention the reasoning (and the fact that you are
>>> removing these flags!) in the commit message. Thanks!
>>
>> but i did mention this, the last paragraph... they are duplicated.
>
> Oh! I completely missed those few lines. Sorry for that :-(
Well, I probably should have made it a separate patch anyway, I'll
repost separately.
> To compensate a bit:
>
>> It still puzzles me why we need -C
>> (preserve comments in the preprocessor output) flag here.
>
> It is so that a human can look at the output and read it. Comments are
> very significant to human readers :-)
I seriously doubt anyone ever read those :) I suspect this is to pull
all the licenses in one place and do some checking but I did not dig deep.
--
Alexey
next prev parent reply other threads:[~2021-05-12 3:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 4:48 [PATCH kernel v2] powerpc/makefile: Do not redefine $(CPP) for preprocessor Alexey Kardashevskiy
2021-05-11 4:48 ` Alexey Kardashevskiy
2021-05-11 11:20 ` Segher Boessenkool
2021-05-11 11:20 ` Segher Boessenkool
2021-05-11 13:30 ` Alexey Kardashevskiy
2021-05-11 23:16 ` Segher Boessenkool
2021-05-12 3:48 ` Alexey Kardashevskiy [this message]
2021-05-12 10:26 ` Segher Boessenkool
2021-05-14 3:10 ` Masahiro Yamada
2021-05-14 3:10 ` Masahiro Yamada
2021-05-11 19:18 ` Nathan Chancellor
2021-05-11 19:18 ` Nathan Chancellor
2021-05-12 3:52 ` Alexey Kardashevskiy
2021-05-12 3:52 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ae1561-ed8d-cf3a-f3bb-d89cd07bfc24@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=npiggin@gmail.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.