From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: perf: Allow the use of the PMUv3 driver on 32bit ARM
Date: Thu, 4 May 2017 12:31:34 +0100 [thread overview]
Message-ID: <80bb9c65-d456-a49b-5ab1-5683c991c1b5@arm.com> (raw)
In-Reply-To: <74692e75-1cb7-21da-be83-7a315e9a84b6@arm.com>
On 04/05/17 12:00, Vladimir Murzin wrote:
> Hi Marc,
>
> On 24/03/17 12:15, Marc Zyngier wrote:
>> The only thing stopping the PMUv3 driver from compiling on 32bit
>> is the lack of defined system registers names. This is easily
>> solved by providing the sysreg accessors and updating the Kconfig entry.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>> ---
>> arch/arm/include/asm/arm_pmuv3.h | 115 +++++++++++++++++++++++++++++++++++++++
>> drivers/perf/Kconfig | 4 +-
>> 2 files changed, 117 insertions(+), 2 deletions(-)
>> create mode 100644 arch/arm/include/asm/arm_pmuv3.h
>>
>> diff --git a/arch/arm/include/asm/arm_pmuv3.h b/arch/arm/include/asm/arm_pmuv3.h
>> new file mode 100644
>> index 000000000000..df14de3d7bdf
>> --- /dev/null
>> +++ b/arch/arm/include/asm/arm_pmuv3.h
>> @@ -0,0 +1,115 @@
>> +/*
>> + * Copyright (C) 2012 ARM Ltd.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
>> + */
>> +
>> +#ifndef __ASM_PMUV3_H
>> +#define __ASM_PMUV3_H
>> +
>> +#include <asm/cp15.h>
>> +
>> +#define pmcr __ACCESS_CP15(c9, 0, c12, 0)
>> +#define pmselr __ACCESS_CP15(c9, 0, c12, 5)
>> +#define pmccntr __ACCESS_CP15_64(0, c9)
>> +#define pmxevcntr __ACCESS_CP15(c9, 0, c13, 2)
>> +#define pmxevtyper __ACCESS_CP15(c9, 0, c13, 1)
>> +#define pmcntenset __ACCESS_CP15(c9, 0, c12, 1)
>> +#define pmcntenclr __ACCESS_CP15(c9, 0, c12, 2)
>> +#define pmintenset __ACCESS_CP15(c9, 0, c12, 1)
>
> Encoding is not right here
>
> To access the PMINTENSET:
>
> MRC p15,0,<Rt>,c9,c14,1 ; Read PMINTENSET into Rt
>
> MCR p15,0,<Rt>,c9,c14,1 ; Write Rt to PMINTENSET
>
>
>> +#define pmintenclr __ACCESS_CP15(c9, 0, c12, 2)
>
> Ditto
>
> To access the PMINTENCLR:
>
> MRC p15,0,<Rt>,c9,c14,2 ; Read PMINTENCLR into Rt
>
> MCR p15,0,<Rt>,c9,c14,2 ; Write Rt to PMINTENCLR
Arghh, -ECOPYPASTE. Thanks for the heads up!
>
>
>> +#define pmovsclr __ACCESS_CP15(c9, 0, c12, 3)
>
> Nit: in 32-bit world it is named as PMOVSR.
>
>> +#define pmceid0 __ACCESS_CP15(c9, 0, c12, 6)
>> +#define pmceid1 __ACCESS_CP15(c9, 0, c12, 7)
>
> Can all these defines be done in uppercase to be in align with existent users
> of __ACCESS_CP15() macro?
Sure, that shouldn't be an issue.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2017-05-04 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 12:15 [PATCH 0/4] perf: Enabling PMUv3 on 32bit ARM systems Marc Zyngier
2017-03-24 12:15 ` [PATCH 1/4] arm64: perf: Move PMUv3 driver to drivers/perf Marc Zyngier
2017-03-24 12:15 ` [PATCH 2/4] arm64: perf: Abstract system register accesses away Marc Zyngier
2017-03-24 12:15 ` [PATCH 3/4] ARM: perf: Allow the use of the PMUv3 driver on 32bit ARM Marc Zyngier
2017-05-04 11:00 ` Vladimir Murzin
2017-05-04 11:31 ` Marc Zyngier [this message]
2017-03-24 12:15 ` [PATCH 4/4] ARM: mach-virt: Select PMUv3 driver by default Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80bb9c65-d456-a49b-5ab1-5683c991c1b5@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.