From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8D71C43461 for ; Mon, 14 Sep 2020 15:06:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14EE8216C4 for ; Mon, 14 Sep 2020 15:06:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VNtSPikn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14EE8216C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHq3N-0006v7-PO for qemu-devel@archiver.kernel.org; Mon, 14 Sep 2020 11:06:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHq1Y-0005GQ-Qi for qemu-devel@nongnu.org; Mon, 14 Sep 2020 11:04:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:54593) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kHq1V-0007h8-4w for qemu-devel@nongnu.org; Mon, 14 Sep 2020 11:04:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600095843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B+WHGEW4wfBaTo9YpovlrsnXJqxzth1wmkfeuzHHlGE=; b=VNtSPiknrphnWsZpnkZg0Dl4XQ1Cqmup0oTY1rv3SnVVAAOXc+YojblDcBFfOjY0AbvFff MN4AaPxc0QillPdg6Gmu2CAtaljap8VelMKfAWE58/zsU3jWbsuIh1QWBp0D8ADp3w2hr4 uWBz0x4DqevpGbdpAiv4Wdu9IIaARI4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-500--NIvXcueOaupLIhM6toXuA-1; Mon, 14 Sep 2020 11:03:59 -0400 X-MC-Unique: -NIvXcueOaupLIhM6toXuA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3EB2E1007468; Mon, 14 Sep 2020 15:03:58 +0000 (UTC) Received: from [10.3.113.68] (ovpn-113-68.phx2.redhat.com [10.3.113.68]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BDB9360DA0; Mon, 14 Sep 2020 15:03:57 +0000 (UTC) Subject: Re: [PATCH] tests/check-block: Do not run the iotests with old versions of bash To: Thomas Huth , qemu-devel@nongnu.org, Max Reitz References: <20200912121412.10999-1-thuth@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <80c1a6a5-df83-8f48-309a-4dc8d3982a43@redhat.com> Date: Mon, 14 Sep 2020 10:03:57 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200912121412.10999-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=63.128.21.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/14 02:55:39 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -38 X-Spam_score: -3.9 X-Spam_bar: --- X-Spam_report: (-3.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.792, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Daniel_P_=2e_Berrang=c3=a9?= , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/12/20 7:14 AM, Thomas Huth wrote: > macOS is shipped with a very old version of the bash (3.2), which > is currently not suitable for running the iotests anymore. Add > a check to skip the iotests in this case - if someone still wants > to run the iotests on macOS, they can install a newer version from > homebrew, for example. > > Signed-off-by: Thomas Huth > --- > tests/check-block.sh | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/check-block.sh b/tests/check-block.sh > index 8e29c868e5..bfe1630c1e 100755 > --- a/tests/check-block.sh > +++ b/tests/check-block.sh > @@ -46,6 +46,11 @@ if ! command -v bash >/dev/null 2>&1 ; then > exit 0 > fi > > +if bash --version | grep 'GNU bash, version [123]' > /dev/null 2>&1 ; then We're already running bash - why do we need to spawn another bash and a grep, when we can just check $BASH_VERSION? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org