All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 8/8] arm64: tegra: Add NVIDIA Jetson Nano Developer Kit support
Date: Thu, 4 Apr 2019 15:47:36 +0100	[thread overview]
Message-ID: <80c8da2c-799f-64e6-5c95-5e90a1327430@nvidia.com> (raw)
In-Reply-To: <20190404112511.28118-8-thierry.reding@gmail.com>


On 04/04/2019 12:25, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The Jetson Nano Developer Kit is a Tegra X1 based development board. It
> is similar to Jetson TX1 but it is not pin compatible. It features 4 GB
> of LPDDR4, an SPI NOR flash for early boot firmware and an SD card slot
> used for storage.
> 
> HDMI 2.0 or DP 1.2 are available for display, four USB ports (3 USB 2.0
> and 1 USB 3.0) can be used to attach a variety of peripherals and a PCI
> Ethernet controller provides onboard network connectivity.
> 
> A 40-pin header on the board can be used to extend the capabilities and
> exposed interfaces of the Jetson Nano.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Changes in v2:
> - add obsolete PCIe and XUSB power supplies for backwards compatibility
> - remove pinmux node
> 
>  arch/arm64/boot/dts/nvidia/Makefile           |   1 +
>  .../boot/dts/nvidia/tegra210-p3450-0000.dts   | 648 ++++++++++++++++++
>  2 files changed, 649 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts

...

> +	hda@70030000 {
> +		status = "okay";

Do you mind adding the following here ...

		nvidia,model = "jetson-nano-hda";

This will be consistent with what Sameer has added for Jetson TX1, TX2
and Xavier. Probably not so important for Tegra210 because there is only
one output stream but nonetheless consistent.

Otherwise ...

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic

  reply	other threads:[~2019-04-04 14:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 11:25 [PATCH 1/8] dt-bindings: phy: tegra-xusb: List PLL power supplies Thierry Reding
2019-04-04 11:25 ` [PATCH 2/8] ARM: tegra: apalis: Move PLL power supplies to XUSB pad controller Thierry Reding
2019-04-04 11:25 ` [PATCH 3/8] ARM: tegra: jetson-tk1: " Thierry Reding
2019-04-04 11:25 ` [PATCH 4/8] ARM: tegra: nyan: " Thierry Reding
2019-04-04 11:25 ` [PATCH 5/8] ARM: tegra: venice2: " Thierry Reding
2019-04-04 11:25 ` [PATCH 6/8] arm64: tegra: jetson-tx1: " Thierry Reding
2019-04-04 11:25 ` [PATCH 7/8] arm64: tegra: smaug: " Thierry Reding
2019-04-04 11:25 ` [PATCH v2 8/8] arm64: tegra: Add NVIDIA Jetson Nano Developer Kit support Thierry Reding
2019-04-04 14:47   ` Jon Hunter [this message]
2019-04-04 16:51     ` Vidya Sagar
2019-04-08  7:50   ` Nicolas Chauvet
2019-04-10 14:13 ` [PATCH 1/8] dt-bindings: phy: tegra-xusb: List PLL power supplies Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80c8da2c-799f-64e6-5c95-5e90a1327430@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.