From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B70AC3DA7D for ; Sat, 31 Dec 2022 09:36:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7605285312; Sat, 31 Dec 2022 10:36:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1672479369; bh=Bkpo5cMQiAwyVepf+WkVZvX6MbpN6q9s1VJkOtReqbo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Reply-To:From; b=NahzwbZCmMPK7L9YX3xIDM1rxI/v+n9E/utFc33pQPu/ksHGXTCOdnkdLNEdORnjX busLD4WJkuigvPoQIv+wz1a/vjzLjE9OLCAl61D5gJ12bA6cSOAQ/Uj/aoc2CphBp5 xai/wJSs644+7njcZyoaiRh0ESCFCo2yGcil0SSRLNcdhUabuZvlrKJRU3QGvyxPuh lULndlzWw+t/pZr6GwvwwohpaXfI3/xcPtomzWC9PF09ux6lW6KyhJ9Vk9LtIqCQs5 Zz4unnd+CnMBVNbrYPStatFrumC5pFgg9xdI7CuCyhyAhuDimztGlOu3yq7R/SKITN d/OsSYz3s6ZkA== Received: from [192.168.1.107] (82-131-201-218.pool.digikabel.hu [82.131.201.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hs@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id DDE8385062; Sat, 31 Dec 2022 10:36:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1672479365; bh=Bkpo5cMQiAwyVepf+WkVZvX6MbpN6q9s1VJkOtReqbo=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=r0KOHtBXDpdDcopR+bvmsq0yHZqj/zYOcng1aZNU0mhRjqTQM9AciLtDOlJWI5e86 pxB4ZPMQwg2KSaVhEXDMogP1NzCri5KyUrlmkbcWX+As5zy6O+i3SPckW8wL4LUVC6 KPqp/7qiqZuFcZ1zrfPTsmA+ij69v8DzjPcuOacOSQGPxd8o1/imlp2mNDu0cE7jA5 PH4ylzn6jdaMGPEcXu49XyDA2anLiRBklqmWGx7uv6Hugga/YwT4aB4wqtV4GR0Bxm 1BNJUOBXExChHAMN7Q+jzGDjQMhnl+58RJ9ri6iaJMlb27U9yd52kBif8Y1OSqp/PQ KYOvtCv1VW4oQ== Subject: Re: [PATCH u-boot] powerpc/mpc85xx: socrates: Re-enable building u-boot-socrates.bin To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Tom Rini Cc: u-boot@lists.denx.de References: <20221228181839.22003-1-pali@kernel.org> From: Heiko Schocher Message-ID: <80cb040a-ccc1-e022-2a37-34e682b46918@denx.de> Date: Sat, 31 Dec 2022 10:36:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20221228181839.22003-1-pali@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: hs@denx.de Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hello Pali, On 28.12.22 19:18, Pali Rohár wrote: > U-Boot build system builds final U-Boot binary for socrates board in custom > file u-boot-socrates.bin (instead of standard u-boot.bin). Output target > file u-boot-socrates.bin is generated by binman as defined in board binman > config file arch/powerpc/dts/socrates-u-boot.dtsi. > > But binman was disabled in commit 5af42eafd7e1 ("Makefile: Reduce usage of > custom mpc85xx u-boot.bin target") for all mpc85xx boards which do not use > standard powerpc binman config file arch/powerpc/dts/u-boot.dtsi and boards > which do not require binman at all. > > The only such mpc85xx board is socrates. So since that commit, U-Boot does > not final binary for socrates board anymore. > > Fix this issue by re-enabling binman for socrates board. And build process > starts again producing u-boot-socrates.bin binary. > > Note that build process for this socrates board always produce u-boot.bin > binary which is broken and not usable for socrates board. Long term > solution should be to disable building broken binary u-boot.bin and then > renaming u-boot-socrates.bin to u-boot.bin, or switching to use common > powerpc binman config file arch/powerpc/dts/socrates-u-boot.dtsi (if it is > possible). > > Fixes: 5af42eafd7e1 ("Makefile: Reduce usage of custom mpc85xx u-boot.bin target") > Signed-off-by: Pali Rohár > --- > Heiko Schocher: Could you test if u-boot is still working on this board? > > Tom Rini: Cannot be this issue handled by CI? For example that CI check > build process produce required output binaries? > --- > arch/powerpc/cpu/mpc85xx/Kconfig | 1 + > 1 file changed, 1 insertion(+) With this patch, u-boot-socrates.bin is build again, so yes... Tested-by: Heiko Schocher ... but current u-boot does not boot anymore on this board ... I have to dig into, obvious difference I see in hexdump is: old (2022.01) u-boot: """ 00001930 74 65 00 6f 66 66 73 65 74 00 73 74 64 6f 75 74 |te.offset.stdout| 00001940 2d 70 61 74 68 00 ff ff ff ff ff ff ff ff ff ff |-path...........| 00001950 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff |................| * 00020000 27 05 19 56 3c 60 e4 01 60 63 3f 10 38 63 fb f0 |'..V<`..`c?.8c..| 00020010 3c 80 e4 01 60 84 40 00 38 00 00 00 38 84 ff fc |<...`.@.8...8...| 00020020 90 04 00 00 7c 04 18 40 40 82 ff f4 3c 80 e4 01 |....|..@@...<...| """ New """ 00001930 74 65 00 6f 66 66 73 65 74 00 73 74 64 6f 75 74 |te.offset.stdout| 00001940 2d 70 61 74 68 00 ff ff ff ff ff ff ff ff ff ff |-path...........| 00001950 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff |................| * 00020000 3c 60 e4 01 60 63 3f 10 38 63 fb f0 3c 80 e4 01 |<`..`c?.8c..<...| 00020010 60 84 40 00 38 00 00 00 38 84 ff fc 90 04 00 00 |`.@.8...8.......| 00020020 7c 04 18 40 40 82 ff f4 3c 80 e4 01 60 84 3f 20 ||..@@...<...`.? | """ So "U-Boot magic" is misssing ... reset vector at end of image is for both the same: 000bfff0 ff ff ff ff ff ff ff ff ff ff ff ff 4b ff f0 04 |............K...| 000c0000 I have to dig deeper into it, to find out what have changed in the meantime, (Think I start a "git bisect") just find some more time for it... Nevertheless, I think, this patch can go in... bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de