From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 01/17] dt-bindings: remoteproc: Add OMAP remoteproc bindings References: <20191028124238.19224-1-t-kristo@ti.com> <20191028124238.19224-2-t-kristo@ti.com> <20191106032727.GA21162@bogus> <25d55648-1fad-7de2-0937-5efeee8672eb@ti.com> From: Tero Kristo Message-ID: <80d28cf5-1219-fb49-a416-5a879f719ebd@ti.com> Date: Wed, 6 Nov 2019 15:50:35 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: Rob Herring Cc: Bjorn Andersson , Ohad Ben-Cohen , "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" , "linux-kernel@vger.kernel.org" , linux-omap , Suman Anna , devicetree@vger.kernel.org List-ID: On 06/11/2019 15:27, Rob Herring wrote: > On Wed, Nov 6, 2019 at 6:44 AM Tero Kristo wrote: >> >> On 06/11/2019 05:27, Rob Herring wrote: >>> On Mon, Oct 28, 2019 at 02:42:22PM +0200, Tero Kristo wrote: >>>> From: Suman Anna >>>> >>>> Add the device tree bindings document for the IPU and DSP >>>> remote processor devices on OMAP4+ SoCs. >>>> >>>> Cc: Rob Herring >>>> Cc: devicetree@vger.kernel.org >>>> Signed-off-by: Suman Anna >>>> Signed-off-by: Tero Kristo >>>> --- >>>> .../remoteproc/ti,omap-remoteproc.txt | 205 ++++++++++++++++++ >>>> 1 file changed, 205 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.txt >>>> >>> >>> Looks to be in pretty good shape, but how about doing a schema. >> >> iommu / mailbox is not in schema format, can I just convert this one to >> schema without considering those? If yes, I can go ahead and do it. > > The client side both have schema (in dt-schema repo). > >>>> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.txt b/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.txt >>>> new file mode 100644 >>>> index 000000000000..e2bcfcab21c1 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.txt >>>> @@ -0,0 +1,205 @@ >>>> +OMAP4+ Remoteproc Devices >>>> +========================= >>>> + >>>> +The OMAP family of SoCs usually have one or more slave processor sub-systems >>>> +that are used to offload some of the processor-intensive tasks, or to manage >>>> +other hardware accelerators, for achieving various system level goals. >>>> + >>>> +The processor cores in the sub-system are usually behind an IOMMU, and may >>>> +contain additional sub-modules like Internal RAM and/or ROMs, L1 and/or L2 >>>> +caches, an Interrupt Controller, a Cache Controller etc. >>>> + >>>> +The OMAP SoCs usually have a DSP processor sub-system and/or an IPU processor >>>> +sub-system. The DSP processor sub-system can contain any of the TI's C64x, >>>> +C66x or C67x family of DSP cores as the main execution unit. The IPU processor >>>> +sub-system usually contains either a Dual-Core Cortex-M3 or Dual-Core Cortex-M4 >>>> +processors. >>>> + >>>> +Remote Processor Node: >>>> +====================== >>>> +Each remote processor sub-system is represented as a single DT node. Each node >>>> +has a number of required or optional properties that enable the OS running on >>>> +the host processor (MPU) to perform the device management of the remote >>>> +processor and to communicate with the remote processor. The various properties >>>> +can be classified as constant or variable. The constant properties are dictated >>>> +by the SoC and does not change from one board to another having the same SoC. >>>> +Examples of constant properties include 'iommus', 'reg'. The variable properties >>>> +are dictated by the system integration aspects such as memory on the board, or >>>> +configuration used within the corresponding firmware image. Examples of variable >>>> +properties include 'mboxes', 'memory-region', 'timers', 'watchdog-timers' etc. >>>> + >>>> +Required properties: >>>> +-------------------- >>>> +The following are the mandatory properties: >>>> + >>>> +- compatible: Should be one of the following, >>>> + "ti,omap4-dsp" for DSPs on OMAP4 SoCs >>>> + "ti,omap5-dsp" for DSPs on OMAP5 SoCs >>>> + "ti,dra7-dsp" for DSPs on DRA7xx/AM57xx SoCs >>>> + "ti,omap4-ipu" for IPUs on OMAP4 SoCs >>>> + "ti,omap5-ipu" for IPUs on OMAP5 SoCs >>>> + "ti,dra7-ipu" for IPUs on DRA7xx/AM57xx SoCs >>>> + >>>> +- iommus: phandles to OMAP IOMMU nodes, that need to be programmed >>>> + for this remote processor to access any external RAM memory or >>>> + other peripheral device address spaces. This property usually >>>> + has only a single phandle. Multiple phandles are used only in >>>> + cases where the sub-system has different ports for different >>>> + sub-modules within the processor sub-system (eg: DRA7 DSPs), >>>> + and need the same programming in both the MMUs. >> >> ^ the target of this is not in schema. > > You mean the OMAP IOMMU binding? That doesn't matter at all. Yeah, OMAP IOMMU. Ok, if it does not matter, I will just convert this all. Will send v2 once I am done. -Tero -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C0DBC5DF62 for ; Wed, 6 Nov 2019 13:50:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D21DF214D8 for ; Wed, 6 Nov 2019 13:50:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="xj54XUR6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731780AbfKFNun (ORCPT ); Wed, 6 Nov 2019 08:50:43 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:50138 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726673AbfKFNun (ORCPT ); Wed, 6 Nov 2019 08:50:43 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id xA6Dod3r078580; Wed, 6 Nov 2019 07:50:39 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1573048239; bh=JBEs1A2urMLjy0KcP/S/vkPdWlz5mh2fUZWBFV44Gkw=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=xj54XUR6dXTuBlKGKVP1kGZmvQYo8m+4Gcbibjr0+RiqbxWGxtIqs5QbmrFAH/FvD Aj+dagzieo0lM4viCfYRD9zTAHjNgS5cTebxJ3Zzmd8j0ZYMwPjcWcF36egZsovl9W ZJbr5n+aB4gMdN+PMBmBQ9Vm/2gcIMitvmJPE7zY= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id xA6DodN3038794 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 6 Nov 2019 07:50:39 -0600 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Wed, 6 Nov 2019 07:50:24 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Wed, 6 Nov 2019 07:50:24 -0600 Received: from [127.0.0.1] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id xA6Doaxd121369; Wed, 6 Nov 2019 07:50:36 -0600 Subject: Re: [PATCH 01/17] dt-bindings: remoteproc: Add OMAP remoteproc bindings To: Rob Herring CC: Bjorn Andersson , Ohad Ben-Cohen , "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" , "linux-kernel@vger.kernel.org" , linux-omap , Suman Anna , References: <20191028124238.19224-1-t-kristo@ti.com> <20191028124238.19224-2-t-kristo@ti.com> <20191106032727.GA21162@bogus> <25d55648-1fad-7de2-0937-5efeee8672eb@ti.com> From: Tero Kristo Message-ID: <80d28cf5-1219-fb49-a416-5a879f719ebd@ti.com> Date: Wed, 6 Nov 2019 15:50:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/11/2019 15:27, Rob Herring wrote: > On Wed, Nov 6, 2019 at 6:44 AM Tero Kristo wrote: >> >> On 06/11/2019 05:27, Rob Herring wrote: >>> On Mon, Oct 28, 2019 at 02:42:22PM +0200, Tero Kristo wrote: >>>> From: Suman Anna >>>> >>>> Add the device tree bindings document for the IPU and DSP >>>> remote processor devices on OMAP4+ SoCs. >>>> >>>> Cc: Rob Herring >>>> Cc: devicetree@vger.kernel.org >>>> Signed-off-by: Suman Anna >>>> Signed-off-by: Tero Kristo >>>> --- >>>> .../remoteproc/ti,omap-remoteproc.txt | 205 ++++++++++++++++++ >>>> 1 file changed, 205 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.txt >>>> >>> >>> Looks to be in pretty good shape, but how about doing a schema. >> >> iommu / mailbox is not in schema format, can I just convert this one to >> schema without considering those? If yes, I can go ahead and do it. > > The client side both have schema (in dt-schema repo). > >>>> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.txt b/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.txt >>>> new file mode 100644 >>>> index 000000000000..e2bcfcab21c1 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.txt >>>> @@ -0,0 +1,205 @@ >>>> +OMAP4+ Remoteproc Devices >>>> +========================= >>>> + >>>> +The OMAP family of SoCs usually have one or more slave processor sub-systems >>>> +that are used to offload some of the processor-intensive tasks, or to manage >>>> +other hardware accelerators, for achieving various system level goals. >>>> + >>>> +The processor cores in the sub-system are usually behind an IOMMU, and may >>>> +contain additional sub-modules like Internal RAM and/or ROMs, L1 and/or L2 >>>> +caches, an Interrupt Controller, a Cache Controller etc. >>>> + >>>> +The OMAP SoCs usually have a DSP processor sub-system and/or an IPU processor >>>> +sub-system. The DSP processor sub-system can contain any of the TI's C64x, >>>> +C66x or C67x family of DSP cores as the main execution unit. The IPU processor >>>> +sub-system usually contains either a Dual-Core Cortex-M3 or Dual-Core Cortex-M4 >>>> +processors. >>>> + >>>> +Remote Processor Node: >>>> +====================== >>>> +Each remote processor sub-system is represented as a single DT node. Each node >>>> +has a number of required or optional properties that enable the OS running on >>>> +the host processor (MPU) to perform the device management of the remote >>>> +processor and to communicate with the remote processor. The various properties >>>> +can be classified as constant or variable. The constant properties are dictated >>>> +by the SoC and does not change from one board to another having the same SoC. >>>> +Examples of constant properties include 'iommus', 'reg'. The variable properties >>>> +are dictated by the system integration aspects such as memory on the board, or >>>> +configuration used within the corresponding firmware image. Examples of variable >>>> +properties include 'mboxes', 'memory-region', 'timers', 'watchdog-timers' etc. >>>> + >>>> +Required properties: >>>> +-------------------- >>>> +The following are the mandatory properties: >>>> + >>>> +- compatible: Should be one of the following, >>>> + "ti,omap4-dsp" for DSPs on OMAP4 SoCs >>>> + "ti,omap5-dsp" for DSPs on OMAP5 SoCs >>>> + "ti,dra7-dsp" for DSPs on DRA7xx/AM57xx SoCs >>>> + "ti,omap4-ipu" for IPUs on OMAP4 SoCs >>>> + "ti,omap5-ipu" for IPUs on OMAP5 SoCs >>>> + "ti,dra7-ipu" for IPUs on DRA7xx/AM57xx SoCs >>>> + >>>> +- iommus: phandles to OMAP IOMMU nodes, that need to be programmed >>>> + for this remote processor to access any external RAM memory or >>>> + other peripheral device address spaces. This property usually >>>> + has only a single phandle. Multiple phandles are used only in >>>> + cases where the sub-system has different ports for different >>>> + sub-modules within the processor sub-system (eg: DRA7 DSPs), >>>> + and need the same programming in both the MMUs. >> >> ^ the target of this is not in schema. > > You mean the OMAP IOMMU binding? That doesn't matter at all. Yeah, OMAP IOMMU. Ok, if it does not matter, I will just convert this all. Will send v2 once I am done. -Tero -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki