From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C370DC433F5 for ; Thu, 9 Sep 2021 09:25:51 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3812E61108 for ; Thu, 9 Sep 2021 09:25:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3812E61108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 220A883244; Thu, 9 Sep 2021 11:25:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="WLFuQEip"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ECDCE8322B; Thu, 9 Sep 2021 11:25:45 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8427D83216 for ; Thu, 9 Sep 2021 11:25:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1631179539; bh=9rTEdJJFqvLHCGPqP2OoPCdOAtCBJZE/9eocSbUeAes=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=WLFuQEipMTERHw59mhFBaKnS6X0jdNj9lCXQRR/1UfCv9olgbSB4wQd2BPO460W2G ThGCoFQe9c9gFM2IsLwfbDybr7BKAAElOncgJ8AOBdZBA94MR+JOrjNvu8SE1Hl86H CMlc28Ou4tIH/FotQgTWb72M1s84U+x1tnsvM3PY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.55] ([88.152.144.157]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N95eJ-1n33002VV9-0163fW; Thu, 09 Sep 2021 11:25:39 +0200 Subject: Re: [PATCH 02/35] x86: Create a new header for EFI To: Simon Glass Cc: U-Boot Mailing List , Ilias Apalodimas , Bin Meng , Tom Rini , Christian Melki References: <20210908133405.696481-1-sjg@chromium.org> <20210908073355.2.If4a31ab38420baccea0f0caf799c85966900e784@changeid> From: Heinrich Schuchardt Message-ID: <80db89d7-1dd9-3029-b3cd-ed8c961f1107@gmx.de> Date: Thu, 9 Sep 2021 11:25:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:1tBxSzl1KMHTZ3tQq8qC63QPU5uJB+hRV7HsFO3wkn6kEB9Stvj FkKD1V7FwnR1ohD4dFUwAQZiiIxfLhv8mktN1AKu8Am9sCn/doiDFRiBo81eh6QnoXuXLac 8bIx2HTBOeu5lz+3Y2lHLxhI5Y3qtezMKJFPq3hQTiPXln7QRY/o4A5GoUzY2hQfbstXme+ 3xvCcfTeKMXmUnzFoKD+A== X-UI-Out-Filterresults: notjunk:1;V03:K0:p8E90HNiVwM=:cIy2lxgFrm4Cto8MKwmkNY RwlnpvuH/zZsoOPugmpd5XiV+WPCNJVhp+g3kAIaNYpGyB/V23/ALyuY/FCh1WzzAcrhD05W0 u/2oAoSlqxj1nMY+TSSoi2TO+z/2QPyAyHDFzD9brl+W3IikhINuD4ekeb5llTKp8ZfY8Hmf2 E9yA8MwQ/xU6kuwkwllUCeypCJg92c/dL3KzOPPRoAFqOjUKQrqt+HAeolVLU2b0q5szEv+an t9ywbEnc0ALjNoSvKtfJvhTtdNIAkXyPomztJZXYK+aPm/MSjYoaY37IeoYhzvAn2J8JV9iF+ 9Q7Mn3XCqTJDl57oUoYT79AnOcfkmtr7sJ6KDo/38RwaTEIi/lsHTxYDFwIt2jJ3bDOUj2KKb h2ARkOza2to7l4JMtzN4U0A/lAhFeaMRDhlP+9pVDK5bg7X0haHHZ+dA+PMiIRhCZ48rfqkJf XnCoJexPVNVWvVbBgPuE8cwSd/dRHuRDq6A/Hred6msN8qKSn5RwKDJ4UNjmg4mog6MVMNhAA 89Dxs00WOAsZDxok2N2o5kh5OCD6CZqtaFfp7UX3EE886iffHfxoZDvnSbylLOA+3XWOmwVcG o5u58eE/tKp4AG7gDbjwBt2e5IBPJpblFLqEiSsJceoQLWFiJMrp9DBM91Ws2spgPq8uOySuW cNsby+mT0IVXbC8ravgq//LFU9dDtnfvyARyr6bMqZ/1RNeSSt8CsWxbZIhcmh4ViIzbJtlHb qNHUgbQ2HKJUCnkn/uJQu3kWNaGPrp9cuKlxQN9ahpEo82+/AETdKhoQz3uZuSOmlHryNDZNo ornFg0uqOcw0Rv0ZK0GTpvqZbyqUS5uxhCm58THZA36GlB4wfg52jFy+9vl1UKh82ozn7695E JWmqT6+B1TLon2uh5+/S3vwUWsd0MBsohSrfaLYO4ZTdZSpZJNevL9qGSPa+kioheqeH1nLYY N+zW5jHra46oy+6gVJHuImsYP9EWIQVo43vUHu4qDcpsSGFVOoXH/fvkCsszasu9n0HWtwtPU hSg3vFs74LSs9SIjkfFXQlMyWTw39ydn1m7TTobFINDPYQVN/C6yNjSjv+hhwGnG9tn+tVQTv bkeOBNL+X9IVqc= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 9/9/21 10:57 AM, Simon Glass wrote: > Hi Heinrich, > > On Wed, 8 Sept 2021 at 11:27, Heinrich Schuchardt w= rote: >> >> >> >> On 9/8/21 3:33 PM, Simon Glass wrote: >>> The setup routines are called from zimage but don't really belong in t= he >>> zimage header. Add a new EFI header to house these. Add comments so it= is >>> clear what the functions do. >>> >>> Signed-off-by: Simon Glass >>> --- >>> >>> arch/x86/include/asm/efi.h | 32 ++++++++++++++++++++++++++++++++ >>> arch/x86/include/asm/zimage.h | 3 --- >>> arch/x86/lib/zimage.c | 1 + >>> 3 files changed, 33 insertions(+), 3 deletions(-) >>> create mode 100644 arch/x86/include/asm/efi.h >> >> In the future we should be able to run the EFI app on any UEFI >> architecture. Given this background are the function definitions really >> x86 specific? > > Well firstly that seems like that would be future work for someone. I did not expect that you do that work. But we should not make that work more difficult than necessary. > Secondly, this relates to zimage which is really only used by x86 as > far as I am aware. setup_video() and setup_efi_info() do not sound like zImage nor like x86 specific. Best regards Heinrich