All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>,
	Kirti Wankhede <kwankhede@nvidia.com>
Cc: cohuck@redhat.com, cjia@nvidia.com, zhi.wang.linux@gmail.com,
	aik@ozlabs.ru, Zhengxiao.zx@Alibaba-inc.com,
	shuangtai.tst@alibaba-inc.com, qemu-devel@nongnu.org,
	peterx@redhat.com, eauger@redhat.com, artemp@nvidia.com,
	yi.l.liu@intel.com, quintela@redhat.com, ziye.yang@intel.com,
	armbru@redhat.com, mlevitsk@redhat.com, pasic@linux.ibm.com,
	felipe@nutanix.com, zhi.a.wang@intel.com, mcrossley@nvidia.com,
	kevin.tian@intel.com, yan.y.zhao@intel.com, dgilbert@redhat.com,
	changpeng.liu@intel.com, eskultet@redhat.com, Ken.Xue@amd.com,
	jonathan.davies@nutanix.com, dnigam@nvidia.com
Subject: Re: [PATCH v29 10/17] memory: Set DIRTY_MEMORY_MIGRATION when IOMMU is enabled
Date: Mon, 26 Oct 2020 17:58:27 +0100	[thread overview]
Message-ID: <80e2181b-80ca-01d4-31ac-3839972393bb@redhat.com> (raw)
In-Reply-To: <20201026104748.589b207d@w520.home>

On 26/10/20 17:47, Alex Williamson wrote:
> Paolo,
> 
> Any objection to this change?  Thanks,

Not at all.  Sorry I missed this change.

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo

> Alex
> 
> On Mon, 26 Oct 2020 15:06:20 +0530
> Kirti Wankhede <kwankhede@nvidia.com> wrote:
> 
>> mr->ram_block is NULL when mr->is_iommu is true, then fr.dirty_log_mask
>> wasn't set correctly due to which memory listener's log_sync doesn't
>> get called.
>> This patch returns log_mask with DIRTY_MEMORY_MIGRATION set when
>> IOMMU is enabled.
>>
>> Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
>> Reviewed-by: Yan Zhao <yan.y.zhao@intel.com>
>> ---
>>  softmmu/memory.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/softmmu/memory.c b/softmmu/memory.c
>> index 403ff3abc99b..94f606e9d9d9 100644
>> --- a/softmmu/memory.c
>> +++ b/softmmu/memory.c
>> @@ -1792,7 +1792,7 @@ bool memory_region_is_ram_device(MemoryRegion *mr)
>>  uint8_t memory_region_get_dirty_log_mask(MemoryRegion *mr)
>>  {
>>      uint8_t mask = mr->dirty_log_mask;
>> -    if (global_dirty_log && mr->ram_block) {
>> +    if (global_dirty_log && (mr->ram_block || memory_region_is_iommu(mr))) {
>>          mask |= (1 << DIRTY_MEMORY_MIGRATION);
>>      }
>>      return mask;
> 



  reply	other threads:[~2020-10-26 17:00 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26  9:36 [PATCH v29 00/17] Add migration support for VFIO devices Kirti Wankhede
2020-10-26  9:36 ` [PATCH v29 01/17] vfio: Add function to unmap VFIO region Kirti Wankhede
2020-10-26  9:36 ` [PATCH v29 02/17] vfio: Add vfio_get_object callback to VFIODeviceOps Kirti Wankhede
2020-10-26  9:36 ` [PATCH v29 03/17] vfio: Add save and load functions for VFIO PCI devices Kirti Wankhede
2020-10-26  9:36 ` [PATCH v29 04/17] vfio: Add migration region initialization and finalize function Kirti Wankhede
2020-10-26 16:23   ` Cornelia Huck
2020-10-26  9:36 ` [PATCH v29 05/17] vfio: Add VM state change handler to know state of VM Kirti Wankhede
2020-10-26 13:00   ` Alex Williamson
2020-10-26 13:48     ` Kirti Wankhede
2020-10-26 14:02       ` Alex Williamson
2020-10-26 14:37         ` Kirti Wankhede
2020-10-26  9:36 ` [PATCH v29 06/17] vfio: Add migration state change notifier Kirti Wankhede
2020-10-26  9:36 ` [PATCH v29 07/17] vfio: Register SaveVMHandlers for VFIO device Kirti Wankhede
2020-10-26  9:36 ` [PATCH v29 08/17] vfio: Add save state functions to SaveVMHandlers Kirti Wankhede
2020-10-26  9:36 ` [PATCH v29 09/17] vfio: Add load " Kirti Wankhede
2020-10-26  9:36 ` [PATCH v29 10/17] memory: Set DIRTY_MEMORY_MIGRATION when IOMMU is enabled Kirti Wankhede
2020-10-26 16:47   ` Alex Williamson
2020-10-26 16:58     ` Paolo Bonzini [this message]
2020-10-26  9:36 ` [PATCH v29 11/17] vfio: Get migration capability flags for container Kirti Wankhede
2020-10-26  9:36 ` [PATCH v29 12/17] vfio: Add function to start and stop dirty pages tracking Kirti Wankhede
2020-10-26  9:36 ` [PATCH v29 13/17] vfio: Add vfio_listener_log_sync to mark dirty pages Kirti Wankhede
2020-10-26  9:36 ` [PATCH v29 14/17] vfio: Dirty page tracking when vIOMMU is enabled Kirti Wankhede
2020-10-26  9:36 ` [PATCH v29 15/17] vfio: Add ioctl to get dirty pages bitmap during dma unmap Kirti Wankhede
2020-10-26  9:36 ` [PATCH v29 16/17] vfio: Make vfio-pci device migration capable Kirti Wankhede
2020-10-26  9:36 ` [PATCH v29 17/17] qapi: Add VFIO devices migration stats in Migration stats Kirti Wankhede
2021-03-15 13:08   ` Thomas Huth
2021-03-16 13:22   ` Eric Blake
2021-03-16 13:24     ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80e2181b-80ca-01d4-31ac-3839972393bb@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=Ken.Xue@amd.com \
    --cc=Zhengxiao.zx@Alibaba-inc.com \
    --cc=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=armbru@redhat.com \
    --cc=artemp@nvidia.com \
    --cc=changpeng.liu@intel.com \
    --cc=cjia@nvidia.com \
    --cc=cohuck@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=dnigam@nvidia.com \
    --cc=eauger@redhat.com \
    --cc=eskultet@redhat.com \
    --cc=felipe@nutanix.com \
    --cc=jonathan.davies@nutanix.com \
    --cc=kevin.tian@intel.com \
    --cc=kwankhede@nvidia.com \
    --cc=mcrossley@nvidia.com \
    --cc=mlevitsk@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=shuangtai.tst@alibaba-inc.com \
    --cc=yan.y.zhao@intel.com \
    --cc=yi.l.liu@intel.com \
    --cc=zhi.a.wang@intel.com \
    --cc=zhi.wang.linux@gmail.com \
    --cc=ziye.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.