From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: agross@kernel.org, linux-kernel@vger.kernel.org,
konrad.dybcio@somainline.org, marijn.suijten@somainline.org,
martin.botka@somainline.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-i2c@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: i2c: qcom,i2c-qup: Document noise rejection properties
Date: Thu, 14 Jan 2021 19:05:23 +0100 [thread overview]
Message-ID: <80ecc187-9694-9be9-a910-e03366968e0a@somainline.org> (raw)
In-Reply-To: <YACGU7Di1RnD9nYL@builder.lan>
Il 14/01/21 18:58, Bjorn Andersson ha scritto:
> On Thu 14 Jan 11:49 CST 2021, AngeloGioacchino Del Regno wrote:
>
>> Document the new noise rejection properties "qcom,noise-reject-sda"
>> and "qcom,noise-reject-scl".
>>
>
> I presume these are unit-less levels?
>
>
Yes, there is no unit.
Sorry, I've sent v3 before seeing your R-b on this.
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Regards,
> Bjorn
>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
>> ---
>> .../devicetree/bindings/i2c/qcom,i2c-qup.yaml | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml
>> index c5c7db3ac2a6..3f14dd65c6b9 100644
>> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml
>> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.yaml
>> @@ -58,6 +58,20 @@ properties:
>> '#size-cells':
>> const: 0
>>
>> + qcom,noise-reject-sda:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description: Noise rejection level for the SDA line.
>> + minimum: 0
>> + maximum: 3
>> + default: 0
>> +
>> + qcom,noise-reject-scl:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description: Noise rejection level for the SCL line.
>> + minimum: 0
>> + maximum: 3
>> + default: 0
>> +
>> required:
>> - compatible
>> - clocks
>> --
>> 2.29.2
>>
prev parent reply other threads:[~2021-01-14 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 17:49 [PATCH v2 0/3] QCOM QUP I2C - Add noise rejection, convert to YAML AngeloGioacchino Del Regno
2021-01-14 17:49 ` [PATCH v2 1/3] dt-bindings: i2c: qcom,i2c-qup: Convert txt to YAML schema AngeloGioacchino Del Regno
2021-01-14 17:49 ` [PATCH v2 2/3] i2c: qup: Introduce SCL/SDA noise rejection AngeloGioacchino Del Regno
2021-01-14 17:57 ` Bjorn Andersson
2021-01-14 17:49 ` [PATCH v2 3/3] dt-bindings: i2c: qcom,i2c-qup: Document noise rejection properties AngeloGioacchino Del Regno
2021-01-14 17:58 ` Bjorn Andersson
2021-01-14 18:05 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ecc187-9694-9be9-a910-e03366968e0a@somainline.org \
--to=angelogioacchino.delregno@somainline.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.