From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755196AbdJIV0L (ORCPT ); Mon, 9 Oct 2017 17:26:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:43962 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754794AbdJIV0J (ORCPT ); Mon, 9 Oct 2017 17:26:09 -0400 Subject: Re: [PATCH] scsi: libiscsi: fix shifting of DID_REQUEUE host byte To: Johannes Thumshirn , "Martin K . Petersen" Cc: Linux Kernel Mailinglist , Linux SCSI Mailinglist , Hannes Reinecke , Bart Van Assche , Chris Leech References: <20171009113319.9505-1-jthumshirn@suse.de> From: Lee Duncan Organization: SUSE Message-ID: <80ee964c-5e48-9059-12fa-7aa61d6b893d@suse.com> Date: Mon, 9 Oct 2017 14:26:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171009113319.9505-1-jthumshirn@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/09/2017 04:33 AM, Johannes Thumshirn wrote: > The SCSI host byte should be shifted left by 16 in order to have > scsi_decide_disposition() do the right thing (.i.e. requeue the command). > > Signed-off-by: Johannes Thumshirn > Fixes: 661134ad3765 ("[SCSI] libiscsi, bnx2i: make bound ep check common") > Cc: Lee Duncan > Cc: Hannes Reinecke > Cc: Bart Van Assche > Cc: Chris Leech > --- > drivers/scsi/libiscsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c > index bd4605a34f54..9cba4913b43c 100644 > --- a/drivers/scsi/libiscsi.c > +++ b/drivers/scsi/libiscsi.c > @@ -1728,7 +1728,7 @@ int iscsi_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *sc) > > if (test_bit(ISCSI_SUSPEND_BIT, &conn->suspend_tx)) { > reason = FAILURE_SESSION_IN_RECOVERY; > - sc->result = DID_REQUEUE; > + sc->result = DID_REQUEUE << 16; > goto fault; > } > > Good catch. I know you're working on fixing all drivers to use the correct macros rather than rolling there own. Acked-by: Lee Duncan -- Lee Duncan SUSE Labs