From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCHSET v6] blk-mq scheduling framework To: Hannes Reinecke , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org References: <1484170803-9311-1-git-send-email-axboe@fb.com> <5850a4ad-74a1-8d30-e865-fbd35679e84f@suse.de> <2e968ed9-7269-488b-4c38-b318ad99ed3f@fb.com> <3cda10cb-b74e-0f6c-bbda-37d366b92ad0@suse.de> <62478d65-8bfb-49bf-c26e-d64daf37c001@suse.de> Cc: osandov@osandov.com, bart.vanassche@sandisk.com From: Jens Axboe Message-ID: <80fc3190-3607-b909-66fb-c69ced180335@kernel.dk> Date: Fri, 13 Jan 2017 09:02:19 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 List-ID: On 01/13/2017 09:00 AM, Jens Axboe wrote: > On 01/13/2017 08:59 AM, Hannes Reinecke wrote: >> On 01/13/2017 04:34 PM, Jens Axboe wrote: >>> On 01/13/2017 08:33 AM, Hannes Reinecke wrote: >> [ .. ] >>>> Ah, indeed. >>>> There is an ominous udev rule here, trying to switch to 'deadline'. >>>> >>>> # cat 60-ssd-scheduler.rules >>>> # do not edit this file, it will be overwritten on update >>>> >>>> ACTION!="add", GOTO="ssd_scheduler_end" >>>> SUBSYSTEM!="block", GOTO="ssd_scheduler_end" >>>> >>>> IMPORT{cmdline}="elevator" >>>> ENV{elevator}=="*?", GOTO="ssd_scheduler_end" >>>> >>>> KERNEL=="sd*[!0-9]", ATTR{queue/rotational}=="0", >>>> ATTR{queue/scheduler}="deadline" >>>> >>>> LABEL="ssd_scheduler_end" >>>> >>>> Still shouldn't crash the kernel, though ... >>> >>> Of course not, and it's not a given that it does, it could just be >>> triggering after the device load and failing like expected. But just in >>> case, can you try and disable that rule and see if it still crashes with >>> MQ_DEADLINE set as the default? >>> >> Yes, it does. >> Same stacktrace as before. > > Alright, that's as expected. I've tried with your rule and making > everything modular, but it still boots fine for me. Very odd. Can you > send me your .config? And are all the SCSI disks hanging off ahci? Or > sdb specifically, is that ahci or something else? Also, would be great if you could pull: git://git.kernel.dk/linux-block blk-mq-sched into current 'master' and see if it still reproduces. I expect that it will, but just want to ensure that it's a problem in the current code base as well. -- Jens Axboe