From: Joe Perches <joe@perches.com>
To: Jakub Kicinski <kuba@kernel.org>, zhangsongyi.cgel@gmail.com
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
zhang.songyi@zte.com.cn, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] net: atm: Convert to use sysfs_emit()/sysfs_emit_at() APIs
Date: Wed, 28 Sep 2022 16:00:02 -0700 [thread overview]
Message-ID: <8101cb98ab2993bf24720507be13f8d54233a161.camel@perches.com> (raw)
In-Reply-To: <20220927070134.7cde492d@kernel.org>
On Tue, 2022-09-27 at 07:01 -0700, Jakub Kicinski wrote:
> On Tue, 27 Sep 2022 06:46:49 +0000 zhangsongyi.cgel@gmail.com wrote:
> > From: zhang songyi <zhang.songyi@zte.com.cn>
> >
> > Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> > should only use sysfs_emit() or sysfs_emit_at() when formatting the value
> > to be returned to user space.
>
> Is there an end goal to this?
To make it easier to validate all other kernel uses of
sprintf/snprintf/scnprintf.
> If the code is correct let's leave
> it as is. ATM is hopefully going to be deleted soon.
<shrug> The code is correct as-is.
prev parent reply other threads:[~2022-09-28 23:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 6:46 [PATCH linux-next] net: atm: Convert to use sysfs_emit()/sysfs_emit_at() APIs zhangsongyi.cgel
2022-09-27 14:01 ` Jakub Kicinski
2022-09-28 23:00 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8101cb98ab2993bf24720507be13f8d54233a161.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zealci@zte.com.cn \
--cc=zhang.songyi@zte.com.cn \
--cc=zhangsongyi.cgel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.