Re: [PATCH] gic:vgic: avoid excessive conversions

From: Andrii Anisov <andrii.anisov@gmail.com>
To: Julien Grall <julien.grall@arm.com>
Cc: xen-devel@lists.xenproject.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Andrii Anisov <andrii_anisov@epam.com>
Subject: Re: [PATCH] gic:vgic: avoid excessive conversions
Date: Mon, 19 Nov 2018 14:02:41 +0200	[thread overview]
Message-ID: <81077db3-73a0-6037-cb20-a5dd1510c95e@gmail.com> (raw)
In-Reply-To: <fb41738a-282e-a633-ff60-ac3fca664cee@arm.com>

Hello Julien,

On 16.11.18 19:27, Julien Grall wrote:
>>           if ( !list_empty(&p->inflight) &&
>>                !test_bit(GIC_IRQ_GUEST_VISIBLE, &p->status) )
>> -            gic_raise_guest_irq(v, p->irq, p->lpi_priority);
>> +            gic_raise_guest_irq(v, p);
>
> The interface is not behaving the same way now. I understand that 
> nobody is using the 3 parameters but that's actually a bug with the ITS.
>
> Because the LPI will not be set with expected priority.
But it is not the issue of the interface, you know. Keeping in mind that 
both an inflight and an lr_pending queues are sorted by p->priority, the 
field p->lpi_priority looks odd anyway.

>> -extern void gic_raise_guest_irq(struct vcpu *v, unsigned int irq,
>> -        unsigned int priority);
>> -extern void gic_raise_inflight_irq(struct vcpu *v, unsigned int 
>> virtual_irq);
>> +extern void gic_raise_guest_irq(struct vcpu *v, struct pending_irq *p);
>> +extern void gic_raise_inflight_irq(struct vcpu *v, struct 
>> pending_irq *n);
>
> That code is not going to compile with the new vGIC as pending_irq 
> only exists for the current vGIC.

Yep, I did miss that.

I guess wrapping it with `#ifndef CONFIG_NEW_VGIC` must be enough here. 
Those two functions are not used by, nor defined by new-vgic.

-- 
Sincerely,
Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel