From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blxF0-0006sj-9z for qemu-devel@nongnu.org; Mon, 19 Sep 2016 08:00:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1blxEw-0007v2-8U for qemu-devel@nongnu.org; Mon, 19 Sep 2016 08:00:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44472) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1blxEw-0007uK-2g for qemu-devel@nongnu.org; Mon, 19 Sep 2016 08:00:02 -0400 References: <1473750714-48290-1-git-send-email-aik@ozlabs.ru> <67d4a40e-420f-f9b0-a499-0ca385e93f2e@redhat.com> <062ab708-1616-561c-5606-25042949597f@ozlabs.ru> From: Paolo Bonzini Message-ID: <81194f18-3bc8-a134-5b32-84690f2d9863@redhat.com> Date: Mon, 19 Sep 2016 13:59:57 +0200 MIME-Version: 1.0 In-Reply-To: <062ab708-1616-561c-5606-25042949597f@ozlabs.ru> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org On 19/09/2016 02:33, Alexey Kardashevskiy wrote: > On 15/09/16 07:04, Paolo Bonzini wrote: >> >> >> On 13/09/2016 09:11, Alexey Kardashevskiy wrote: >>> The tap backend is already using qemu-bridge-helper to attach tap >>> interface to a bridge but (unlike the bridge backend) it always uses >>> the default bridge name - br0. >>> >>> This adds a "br" property support to the tap backend. >>> >>> Signed-off-by: Alexey Kardashevskiy >> >> Stupid question ahead: how does -netdev bridge compare to -netdev tap >> after this patch? Is there a case left where you must use -netdev bridge? >> >> Or can we make -netdev bridge a synonym for "-netdev >> tap,helper=/default/path/to/helper"? > > I looked through history but I could not understand why "bridge" was > introduced in the first place as even there (a7c36ee4920ea) is an example of > > -netdev tap,helper="/usr/local/libexec/qemu-bridge-helper --br=qemubr0",id=hn0 > > so it was assumed even then that people might want tap on a specific bridge. > > So my stupid question is - what do I have to do to get this accepted > (besides a note that it is 2.8+) or it is not interesting to anyone? :) I think the patch is even more interesting because it lets us simplify the code for -netdev bridge. Paolo