From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marco Berizzi <pupilla@libero.it>
Subject: Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy
Date: Wed, 31 Oct 2018 13:42:23 +0100 (CET)
Message-ID: <812768811.1116529.1540989743196@mail.libero.it>
References: <20181024153249.15374-1-dsahern@kernel.org>
 <1305358874.1795395.1540553653206@mail.libero.it>
 <CAM_iQpWzthb3JoHyMv0AtJZQNVr9CQgkoJ8jOpsZpMSX1R7WKg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
        dsahern@kernel.org
To: Cong Wang <xiyou.wangcong@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from smtp-32-i2.italiaonline.it ([213.209.12.32]:35987 "EHLO
        libero.it" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1728930AbeJaVkS (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 31 Oct 2018 17:40:18 -0400
In-Reply-To: <CAM_iQpWzthb3JoHyMv0AtJZQNVr9CQgkoJ8jOpsZpMSX1R7WKg@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> Il 26 ottobre 2018 alle 20.19 Cong Wang <xiyou.wangcong@gmail.com> ha scritto:
> 
> On Fri, Oct 26, 2018 at 4:35 AM Marco Berizzi <pupilla@libero.it> wrote:
> 
> > Apologies for bothering you again.
> > I applied your patch to 4.19, but after issuing this
> > command:
> > 
> > root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
> > root@Calimero:~# ping 10.81.104.1
> > PING 10.81.104.1 (10.81.104.1) 56(84) bytes of data.
> > ^C
> > --- 10.81.104.1 ping statistics ---
> > 2 packets transmitted, 0 received, 100% packet loss, time 1001ms
> > 
> > I'm losing ipv4 connectivity.
> > If I remove the qdisc everything is going to work again:
> 
> Did this really work before?
> 
> You specify a default class without adding it, so the packets are dropped.
> 
> How would you expect this to work? :)

:-) yes indeed. Apologies for the noise.