From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754597AbcAMWw2 (ORCPT ); Wed, 13 Jan 2016 17:52:28 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:50777 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752004AbcAMWw0 (ORCPT ); Wed, 13 Jan 2016 17:52:26 -0500 From: Arnd Bergmann To: Kalle Valo Cc: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Hauke Mehrtens , Michael Buesch , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] ssb: host_soc depends on sprom Date: Wed, 13 Jan 2016 23:51:43 +0100 Message-ID: <8128014.DbbgBtKY3z@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:qf3MfOAjxyTMT+zbPmgOFoj6CnQXJVnKFJj8MM2r7T0XFz5sSkl Hbs8mgoDbEjNAh36lhSc/YRJmMhN4X1xMUpfQvo0VHEa9ztYw2oqCRpdDVqFo4qAO+3drQI ZfYeeCcID/RpeEs1NHcG1thWy9kcRKpDrnG3Mnxu7f+yRwcGAAFEhmNXH1ubp94qdiAfJ/K xBHi5BvzVjyAdc9CE2ziA== X-UI-Out-Filterresults: notjunk:1;V01:K0:99gYFoNzJ9k=:WoH8pasRVrCiCgxcGd9crr njCHP9wAEgXpZkLt3yLnDnzby9Lm0afd01hX2+F4gfAzq1H7zbTpUpGtOtfv99u0xjdQn1Ld7 tjlh2ZHZ7EnaOmuoE6xGMOYBjcquglG2SvEbJSRYzhL9BPZubSf5FuXfrfj8hgcMlOTxcm2yy 1JU4oxbAesn0cKe+P5yQFbl9FmKgLOpgmF1Dnfn2n+jFH/EMwoDagcqpJsnwRU1mK55YJFVGX SJPh9qXe1T+WSNdoWT6zh/NlqHysgor6ClfMpaMI8ctzZqYKciMjo7oOMzvYevzrXAxFqoYN5 lQ5xckCbWXOM/DVi2fc82kK/Lit0/dY3mq7Sgm32P7Ug3e5nJ0bzqQJqG5kjeJvobL+EynxbX 8xkO9mpND846GEt1pIGmDtoNC/xiCTcbZY2k4yvAtjleBYMUPIGttwRZOzvyBsNX6o81ADKgD mgqd4QFAbrL0yQBQcCXmo+fH6tJmIsbeBEKD4OO+BqmIM+b8oHjh/WSlh0uYbbQt9ON1TMSRE nFOASpIItrhwlRIfHOlk5U7LwN26YWaE9CSMPdEzB2vs5pWmjyNqlTYCcJ3zN2vWgvvN9Xd3R 2PBHVSdhcDcn+yFvTIgOMl7TwaXcBEf7JaCV0xYbAQ46TLoD1xbsFiL8EvtMN8/G5s8U8NHom xFAV6kO+DFWE5g+O/Yl67Mx7Qcax8VjIJevccimXmn+RtYWvFI0Xt6QxMR4ozYDEz4TDfhs70 /skRbFTA9Ol0LCtw Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drivers that use the SSB sprom functionality typically 'select SSB_SPROM' from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in a build failure unless at least one of the other drivers that selects it is enabled: drivers/built-in.o: In function `ssb_host_soc_get_invariants': (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback' This adds the same select statement that is used elsewhere. Signed-off-by: Arnd Bergmann Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch") --- I'm not sure who the right person is to pick up the fix. The patch that introduced the problem was merged by Kalle through the iwlwifi tree. diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig index 0c675861623f..d8e4219c2324 100644 --- a/drivers/ssb/Kconfig +++ b/drivers/ssb/Kconfig @@ -83,6 +83,7 @@ config SSB_SDIOHOST config SSB_HOST_SOC bool "Support for SSB bus on SoC" depends on SSB && BCM47XX_NVRAM + select SSB_SPROM help Host interface for a SSB directly mapped into memory. This is for some Broadcom SoCs from the BCM47xx and BCM53xx lines. From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 13 Jan 2016 23:51:43 +0100 Subject: [PATCH] ssb: host_soc depends on sprom Message-ID: <8128014.DbbgBtKY3z@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Drivers that use the SSB sprom functionality typically 'select SSB_SPROM' from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in a build failure unless at least one of the other drivers that selects it is enabled: drivers/built-in.o: In function `ssb_host_soc_get_invariants': (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback' This adds the same select statement that is used elsewhere. Signed-off-by: Arnd Bergmann Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch") --- I'm not sure who the right person is to pick up the fix. The patch that introduced the problem was merged by Kalle through the iwlwifi tree. diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig index 0c675861623f..d8e4219c2324 100644 --- a/drivers/ssb/Kconfig +++ b/drivers/ssb/Kconfig @@ -83,6 +83,7 @@ config SSB_SDIOHOST config SSB_HOST_SOC bool "Support for SSB bus on SoC" depends on SSB && BCM47XX_NVRAM + select SSB_SPROM help Host interface for a SSB directly mapped into memory. This is for some Broadcom SoCs from the BCM47xx and BCM53xx lines.