From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935014AbeCEM7b (ORCPT ); Mon, 5 Mar 2018 07:59:31 -0500 Received: from mail-lf0-f51.google.com ([209.85.215.51]:35026 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934109AbeCEM72 (ORCPT ); Mon, 5 Mar 2018 07:59:28 -0500 X-Google-Smtp-Source: AG47ELtaY4bsuOjnkj0AUmijXfkGtEUiG6U5xGJstfp2AfB7iZ58wuSkzcKfPA02Cbn4131cjcXXPA== Subject: Re: [PATCH 7/9] drm/xen-front: Implement KMS/connector handling To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, daniel.vetter@intel.com, seanpaul@chromium.org, gustavo@padovan.org, jgross@suse.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, Oleksandr Andrushchenko References: <1519200222-20623-1-git-send-email-andr2000@gmail.com> <1519200222-20623-8-git-send-email-andr2000@gmail.com> <20180305092353.GI22212@phenom.ffwll.local> From: Oleksandr Andrushchenko Message-ID: <8132411b-ee50-fe42-2e62-8816a1f85433@gmail.com> Date: Mon, 5 Mar 2018 14:59:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180305092353.GI22212@phenom.ffwll.local> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/05/2018 11:23 AM, Daniel Vetter wrote: > On Wed, Feb 21, 2018 at 10:03:40AM +0200, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko >> >> Implement kernel modesetiing/connector handling using >> DRM simple KMS helper pipeline: >> >> - implement KMS part of the driver with the help of DRM >> simple pipepline helper which is possible due to the fact >> that the para-virtualized driver only supports a single >> (primary) plane: >> - initialize connectors according to XenStore configuration >> - handle frame done events from the backend >> - generate vblank events >> - create and destroy frame buffers and propagate those >> to the backend >> - propagate set/reset mode configuration to the backend on display >> enable/disable callbacks >> - send page flip request to the backend and implement logic for >> reporting backend IO errors on prepare fb callback >> >> - implement virtual connector handling: >> - support only pixel formats suitable for single plane modes >> - make sure the connector is always connected >> - support a single video mode as per para-virtualized driver >> configuration >> >> Signed-off-by: Oleksandr Andrushchenko > I think once you've removed the midlayer in the previous patch it would > makes sense to merge the 2 patches into 1. ok, will squash the two > > Bunch more comments below. > -Daniel > >> --- >> drivers/gpu/drm/xen/Makefile | 2 + >> drivers/gpu/drm/xen/xen_drm_front_conn.c | 125 +++++++++++++ >> drivers/gpu/drm/xen/xen_drm_front_conn.h | 35 ++++ >> drivers/gpu/drm/xen/xen_drm_front_drv.c | 15 ++ >> drivers/gpu/drm/xen/xen_drm_front_drv.h | 12 ++ >> drivers/gpu/drm/xen/xen_drm_front_kms.c | 299 +++++++++++++++++++++++++++++++ >> drivers/gpu/drm/xen/xen_drm_front_kms.h | 30 ++++ >> 7 files changed, 518 insertions(+) >> create mode 100644 drivers/gpu/drm/xen/xen_drm_front_conn.c >> create mode 100644 drivers/gpu/drm/xen/xen_drm_front_conn.h >> create mode 100644 drivers/gpu/drm/xen/xen_drm_front_kms.c >> create mode 100644 drivers/gpu/drm/xen/xen_drm_front_kms.h >> >> diff --git a/drivers/gpu/drm/xen/Makefile b/drivers/gpu/drm/xen/Makefile >> index d3068202590f..4fcb0da1a9c5 100644 >> --- a/drivers/gpu/drm/xen/Makefile >> +++ b/drivers/gpu/drm/xen/Makefile >> @@ -2,6 +2,8 @@ >> >> drm_xen_front-objs := xen_drm_front.o \ >> xen_drm_front_drv.o \ >> + xen_drm_front_kms.o \ >> + xen_drm_front_conn.o \ >> xen_drm_front_evtchnl.o \ >> xen_drm_front_shbuf.o \ >> xen_drm_front_cfg.o >> diff --git a/drivers/gpu/drm/xen/xen_drm_front_conn.c b/drivers/gpu/drm/xen/xen_drm_front_conn.c >> new file mode 100644 >> index 000000000000..d9986a2e1a3b >> --- /dev/null >> +++ b/drivers/gpu/drm/xen/xen_drm_front_conn.c >> @@ -0,0 +1,125 @@ >> +/* >> + * Xen para-virtual DRM device >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * Copyright (C) 2016-2018 EPAM Systems Inc. >> + * >> + * Author: Oleksandr Andrushchenko >> + */ >> + >> +#include >> +#include >> + >> +#include