From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 592A3C2BA19 for ; Tue, 14 Apr 2020 16:06:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20AAD2076B for ; Tue, 14 Apr 2020 16:06:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z2aluzzw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20AAD2076B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOO53-0004Fj-O2 for qemu-devel@archiver.kernel.org; Tue, 14 Apr 2020 12:06:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47541) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOO0a-0007Vf-L1 for qemu-devel@nongnu.org; Tue, 14 Apr 2020 12:02:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOO0U-0008Bh-GK for qemu-devel@nongnu.org; Tue, 14 Apr 2020 12:01:55 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:22812 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jOO0U-0008BA-9C for qemu-devel@nongnu.org; Tue, 14 Apr 2020 12:01:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586880109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BPKN/eZSreBtCfpg+PAM2VGxJ4Mdmq8P0K4hWkWqD4Y=; b=Z2aluzzwUQk3kyu3EJvZda04e1Y30NpO+Upoa2S++dlh2NKwNqIbyi0a9KsSz9KpoxQx/0 UEpR6a/Q6dOA97ekqulq4fYmSunH9ca9pVl49KGmRRiYpJpVc7GdhhyqGe7m230+Z/S5T4 EdGPSK5QGEjD7TbF3Rtmi5r6Uv89cXA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-v4cgDZbNNUOF3NwhS-wSJQ-1; Tue, 14 Apr 2020 12:01:47 -0400 X-MC-Unique: v4cgDZbNNUOF3NwhS-wSJQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8DA4D1083E80; Tue, 14 Apr 2020 16:01:45 +0000 (UTC) Received: from [10.3.115.59] (ovpn-115-59.phx2.redhat.com [10.3.115.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CAFB79A248; Tue, 14 Apr 2020 16:01:43 +0000 (UTC) Subject: Re: [PATCH v4 11/30] qcow2: Add l2_entry_size() To: Alberto Garcia , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org References: <58d1fa17-91ea-9f8d-c39a-4141783d1234@virtuozzo.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <81446480-40cc-3e6f-ac0f-8b18422ae9f4@redhat.com> Date: Tue, 14 Apr 2020 11:01:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Denis V . Lunev" , Anton Nefedov , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/14/20 7:20 AM, Alberto Garcia wrote: >> Hmm. How to avoid it? Maybe, at least, refactor the code, to drop all >> sizeof(uint64_t), converting them to L2_ENTRY_SIZE, L1_ENTRY_SIZE, >> REFTABLE_ENTRY_SIZE etc? > > That wouldn't be a bad thing I guess but, again, for a separate patch or > series. > >> And all occurrences of pure '8' (not many of them exist) > > I think most/all nowadays only refer to the number of bits per byte. CHAR_BIT (from ) is good for that. > > Maybe there's a couple that still need to be fixed, but we have been > removing a lot of numeric literals from the qcow2 code (see for example > b6c246942b, 3afea40243 or a35f87f50d). > > Berto > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org