From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42F0CC4727D for ; Tue, 22 Sep 2020 10:40:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F558206FB for ; Tue, 22 Sep 2020 10:40:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zLnAswGs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F558206FB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=85HKTJN10IZoX6NZPwega5qtP+iKY+GT8pMNzUBfOEc=; b=zLnAswGsh4d1dsKgi4sxStxsH QFqygcVlwanwVovSeCm/mLJRisCBW0M8aBGLzo5NF+uWHimN6lQXiVzeDLpsq6yMMzAKwHXCKt8Nh vTqbN0RbIq7IL37OhenvuwHZeTkBwAmRPwDrS6XVvEK+T4ZuqlaU+hymecHkSWBTthY+nVYcrh9FL u6tmIoGnrPo/yWjpZDaZVNHDBCjtdLlvVG6Vy9cG9uKW/GXgDYDjOwlPKfeyyJeKrPtmOSZRUKDzM cHqiF58i6hiruUfAP8bx4p2Ko9YIiDCbS5QawMgJFypaRjtTudmYTQFec5wnItPDNVsLksCFbItpW qAzJ8XsVA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKfhn-0005Ie-6H; Tue, 22 Sep 2020 10:39:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKfhk-0005Hx-B7 for linux-arm-kernel@lists.infradead.org; Tue, 22 Sep 2020 10:39:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2F4E3D6E; Tue, 22 Sep 2020 03:39:23 -0700 (PDT) Received: from [10.57.51.251] (unknown [10.57.51.251]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C9D3C3F718; Tue, 22 Sep 2020 03:39:21 -0700 (PDT) Subject: Re: [PATCH 11/19] coresight: etm4x: Check for OS and Software Lock To: mike.leach@linaro.org References: <20200911084119.1080694-1-suzuki.poulose@arm.com> <20200911084119.1080694-12-suzuki.poulose@arm.com> From: Suzuki K Poulose Message-ID: <814857b0-4136-5ba7-cb3d-d51de3890468@arm.com> Date: Tue, 22 Sep 2020 11:44:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200922_063924_483966_7604F2F1 X-CRM114-Status: GOOD ( 18.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, anshuman.khandual@arm.com, mathieu.poirier@linaro.org, linux-arm-kernel@lists.infradead.org, leo.yan@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/18/2020 04:35 PM, Mike Leach wrote: > Hi Suzuki > > On Fri, 11 Sep 2020 at 09:41, Suzuki K Poulose wrote: >> >> An ETM instance may not implement the OS/Software Lock. This >> is advertised via TRCOSLSR/TRCLSR respectively. Detect the >> presence of these lock registers and skip the lock/unlock >> if they are not implemented. >> >> Signed-off-by: Suzuki K Poulose >> --- >> drivers/hwtracing/coresight/coresight-etm4x.c | 77 +++++++++++++++---- >> drivers/hwtracing/coresight/coresight-etm4x.h | 24 +++++- >> 2 files changed, 83 insertions(+), 18 deletions(-) >> >> >> +/* >> + * ETM may or may not implement the Software Lock and the OS Lock. >> + * Detect this before we attempt to do any locking. >> + */ >> +static void etm_detect_lock_status(struct etmv4_drvdata *drvdata, >> + struct csdev_access *csa) >> +{ >> + u32 sw_lsr = etm4x_relaxed_read32(csa, TRCLSR); > > 7.3.48 - ETMv4.5 spec -> TRCLSR accessible only from the memory mapped > interface. > Good point, I have fixed this now. >> + u32 os_lsr = etm4x_relaxed_read32(csa, TRCOSLSR); > > This is unneeded. 7.3.50 of the ETM4.5 spec says for OS lock bits > "always 0b10 for Armv8-A/R, Armv7-A/R,". So always implemented. Agreed, I will drop this for now. Cheers Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel