From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rao, Nikhil" Subject: Re: [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues Date: Wed, 16 Aug 2017 10:36:35 +0530 Message-ID: <81597f6e-0038-41e8-9289-3cd7a34a0ecb@intel.com> References: <20170729151252.GA25166@jerin> <7b9ca757-f428-3675-b997-794ec6e96f2a@intel.com> <20170801164242.GA6467@jerin> <9184057F7FC11744A2107296B6B8EB1E01F00701@FMSMSX108.amr.corp.intel.com> <20170803062315.GA14704@jerin> <9184057F7FC11744A2107296B6B8EB1E01F030FC@FMSMSX108.amr.corp.intel.com> <20170809161946.GA6650@jerin> <9184057F7FC11744A2107296B6B8EB1E01F0EEF4@FMSMSX108.amr.corp.intel.com> <20170810165319.GA6051@jerin> <3fe6768a-7422-8006-5d37-961b0b31afa3@intel.com> <20170814111001.GA12530@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "Eads, Gage" , "dev@dpdk.org" , "thomas@monjalon.net" , "Richardson, Bruce" , "Van Haaren, Harry" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Vangati, Narender" , "Gujjar, Abhinandan S" To: Jerin Jacob Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 95D812B91 for ; Wed, 16 Aug 2017 07:06:41 +0200 (CEST) In-Reply-To: <20170814111001.GA12530@jerin> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/14/2017 4:41 PM, Jerin Jacob wrote: > -----Original Message----- >> Date: Mon, 14 Aug 2017 14:18:15 +0530 >> From: "Rao, Nikhil" >> To: Jerin Jacob , "Eads, Gage" >> >> CC: "dev@dpdk.org" , "thomas@monjalon.net" >> , "Richardson, Bruce" , >> "Van Haaren, Harry" , "hemant.agrawal@nxp.com" >> , "nipun.gupta@nxp.com" , >> "Vangati, Narender" , "Gujjar, Abhinandan S" >> >> Subject: Re: [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues >> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 >> Thunderbird/52.2.1 >> >> On 8/10/2017 10:23 PM, Jerin Jacob wrote: >>> -----Original Message----- >>>> Date: Wed, 9 Aug 2017 19:24:30 +0000 >>>> From: "Eads, Gage" >>>> Makes sense. Are you thinking the helper function would do stop + reconfig with additional port + start + setup port, or just setup the port with an ID the app supplies (only when a port is required, of course)? The second one could be done with little additional code -- the app just needs to check if an additional port is needed when configuring the eventdev, and another helper function could take a list of pairs and return true if any don't have an inbuilt port. >>> >>> I am in favor adding more logic in helper function(I believe, first one ) so that it will help >>> application reuse the helper functions for the normal case. >>> >> >> Hi Jerin, > > Hi Nikhil, > >> >> My understanding of the discussion above is that the simple API adapter >> creation API is >> >> int rte_event_eth_rx_adapter_create(id, eventdev_id) >> >> And the raw API is >> >> typedef int (*rx_adapter_conf_cb) (id, eventdev_id, >> struct rte_event_eth_rx_adapter_conf *conf, void *arg); >> >> struct rte_event_eth_rx_adapter_conf { >> uint8_t rx_event_port_id; >> uint32_t max_nb_rx; >> }; >> >> int rte_event_eth_rx_adapter_create_ext(id, eventdev_id, conf_cb, >> conf_arg) >> >> The conf_cb is invoked if the rte_event_eth_rx_adapter_conf struct needs to >> be filled out. the _create_ext() API is used internally by >> rte_event_eth_rx_adapter_create() >> >> Does that look OK to you ? > > Just elaborating with additional detail. Let me know my understating is correct > or not? Yes. Thanks for the clarification. > > default_cb(id, eventdev_id, conf) > { > > conf->rx_event_port_id = rte_event_port() + 1; > conf->max_nb_rx = ...; > .... > } > > rte_event_eth_rx_adapter_create(id, eventdev_id) > { > struct rte_event_eth_rx_adapter_conf default_conf_arg; > > rte_event_eth_rx_adapter_create_ext(id, eventdev_id, > default_cb, &default_conf_arg); > } > > Application is free to use rte_event_eth_rx_adapter_create() or > rte_event_eth_rx_adapter_create_ext(). rte_event_eth_rx_adapter_create_ext() > will be used by application when "default_cb" handler is not enough for > the use cases. > > >> >> Nikhil >> >