From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7762FC4338F for ; Wed, 4 Aug 2021 21:43:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 282F760C3F for ; Wed, 4 Aug 2021 21:43:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 282F760C3F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=seco.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4E43F82DD4; Wed, 4 Aug 2021 23:43:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.b="fSSgcAjl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9FBF582C48; Wed, 4 Aug 2021 23:43:51 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on0608.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe08::608]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 39F3680C89 for ; Wed, 4 Aug 2021 23:43:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kaPkKMcJswrR8gppNY01CBy6ZjgjL3zPsRlHa4v9L5D8vSQH80mpMjyypqoz6Dis+eeMO0zVi4SFf8pzK0MorHyhMO0Fn53X9h9a+pDFqJN5kFIIWemdPnFr3SNP7vdqSAEO+R03Csib8TsXF/9bJ8H/lWtCfnL9apDJWjgAZ8zg+BxG/itSk/ZaG+QBrouakaBO3CPNbEu5bmDuR9K81rMyQBDBuExYyli/E7B/jD0hcSFQjuc++i3I8WSvFvSmEi3t0ocJAvh+Ot4M6PxnPFIOrFQjL/gKU50uBg/KXRWzGQQZ3dWu7nVa7V3nBfLZXdPbm9ruqO2FZ+DxoESHfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BYHMxV5CN1zVJOopaTHq4PEVU1GFyu3CK45FefCRNpY=; b=LwzqZ0+jxL1xbLveLMiwGGYajbNobZviFNkM77I/L45Y2jRDnIjmi7J5yzovCwbLAeWC0E3RY37SJeg7BLaNgzTeHNnHJQjfnhT3FtP9WBiPQUDZ2D+xRpDehKgCsqsbjymPkc1kRG+Dm5FD/acaFCWC+Xzm5n4yaqXJbQAyRbtRg5kQpcbWslNM5jyDx07QBPXKbUcoPonDV2dY3aN7hfRu2UNDcuMgLYTfVRzOmcse1d/lCiwvUGdvCJVpdHOkPQKsM+NbPJlIsy6ZoX1arHiOTrcF/tN6CYkMQZX3QCJQdal8QmwOcmtNkwLGXRULREyapeXrYRKzvRqUC1cINg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secospa.onmicrosoft.com; s=selector2-secospa-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BYHMxV5CN1zVJOopaTHq4PEVU1GFyu3CK45FefCRNpY=; b=fSSgcAjlFdw7jwZfZm8MAoqN+AjuH2/yRRkhtMUwAHToRdGEZ2NSS7W97t4Pg+4XtYa2XTwV/KmkXBYffHHv1NzkKL4jM5MF0/PfzLL5uzE2nrjQ6MXJGGycOlQveUGUBUcjheUPZTFJHwZhG2+aqkE6WDSUvS75JnIyFWXxtAU= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) by DB6PR0302MB2822.eurprd03.prod.outlook.com (2603:10a6:4:ae::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.16; Wed, 4 Aug 2021 21:43:46 +0000 Received: from DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::dc6c:815b:2062:d1f1]) by DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::dc6c:815b:2062:d1f1%7]) with mapi id 15.20.4394.016; Wed, 4 Aug 2021 21:43:46 +0000 From: Sean Anderson Subject: Re: [PATCH 11/11] Remove including timestamp.h in version.h To: Simon Glass , =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Wolfgang Denk , Priyanka Jain , Christophe Leroy , Bin Meng , =?UTF-8?Q?Marek_Beh=c3=ban?= , Tom Rini , U-Boot Mailing List References: <20210802131838.21097-1-pali@kernel.org> <20210802131838.21097-12-pali@kernel.org> Message-ID: <815b40e2-aa57-abfb-901f-979507a9e3b7@seco.com> Date: Wed, 4 Aug 2021 17:43:41 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BLAPR03CA0070.namprd03.prod.outlook.com (2603:10b6:208:329::15) To DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [172.27.1.65] (50.195.82.171) by BLAPR03CA0070.namprd03.prod.outlook.com (2603:10b6:208:329::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.21 via Frontend Transport; Wed, 4 Aug 2021 21:43:44 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8f7903fd-f5a5-4590-f73d-08d95790efcb X-MS-TrafficTypeDiagnostic: DB6PR0302MB2822: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f4Y0Mkwr1bVeCUxUFLS/MmElPnKd7Z+aI0Thq8NTJAK2eRL0oixwsAaMrbn0eh5ajZcHkMtGtrJUzVWA7ABegOfxsJtSPJEyR4EkEt+VOPo2R4CJkmjE0+bcUcPCjqHnRBQCKWh72q/C8Qxu1mhP90shUSZeieKIZQ57yszH8OIb8Y8HKZg7aUlwSN9qUKKm84jLcpYlYmVbvynl1fG4gaH74fsS0QSsu7KLv+OzKpzRZyPrnomlMfFIoYGidKP+a4dLeu4zb6ho+3NYG4mj4kAC0r6cNZmzZhFcZU9gtpHy3qtKJrx38SBHCpVXLjBSVE/Z93Yf7MjYzasl2DK2/OjMubx6tArSu1jfAR2Gt5qr5sc8ZAVFsm4j9Q+MolTFwREPVWPVUQapzF9F1rrCsGHFYzfnZrLjHwuLE9bUlp3s41CbSIXKQLHQIbbAWYLRsSmFZLfw6bDADUqc4br+CPJywbZvuNAG8WVXqwMZoRsezQtcab4uFyQ0mlJnoOOALy/e3PsVMcXG1uCXGP4wKea3MEHbRZFTcFc2IzlMMZsUkD98ymMFq4gx9fSY8Fwe4lU/Oj7YQUWQ+8ch576aOxy1NiBxsVOqwxm+HkElrVbEzYN996p/LCwYrSPETXxZTBZtuMZY2Kc+IPk+sUu1hdg2u9RlxU3ZscjIIUUleovj/C88bfa5OJKiIs2wpLH/wGqsu++nGPNkS6tqHCBVl8gOX2K9O8jnK1UklZlY3ddb59/3fUST3oEUUV+YsdvG6JxE61Tn/8AQ3/pRiZPBcA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4523.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(366004)(396003)(39830400003)(376002)(136003)(6486002)(8936002)(52116002)(86362001)(8676002)(5660300002)(2906002)(66946007)(66476007)(2616005)(478600001)(186003)(956004)(31696002)(16576012)(54906003)(316002)(44832011)(6666004)(66556008)(110136005)(26005)(36756003)(38350700002)(7416002)(83380400001)(66574015)(4326008)(38100700002)(31686004)(53546011)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFNuaitocmo1YVpQRjl4WDFhWFZ6VlVTZGVVVmJMQkdHQ0VTZE1WZlg2NHJI?= =?utf-8?B?M1dKUjloSjBEQzZWVUtGOU0zOWxzdFVXMGVHTU1rblVOZmIydGh2NHZUQVEv?= =?utf-8?B?Q0dFd0l1VTJWZ2V1eWIzd3hKZ2g0ZWhOSlV5NGNtSzYza3AxMVNxdWlmTUs1?= =?utf-8?B?TjZDMDFuWlFQaE5OeG1LL3c3bUoxS0pUUVNUYmRXeW1ZZ0xGL3l1OStLQWV1?= =?utf-8?B?YnA2alRjTVhCT1pybUM1ZEVRalVONG9PVURTczgwOUxTb3NHK1YyYjdjWndq?= =?utf-8?B?c1gyYjhYVmoyc2V3WllqeXhiZTNYTXluRVRzcVVoK1RJamRVVmpoazU2NnMx?= =?utf-8?B?RWptYUVBRkVvaGxLc2M4NklaRkJqNUI5M0JJYnEySDU5NzBEc3pXdHBabzFs?= =?utf-8?B?d1BBcUZQRGpwam1qa3kzSWxKeStQZ1JGMm9Lai9kRTBOUmFHbVJITk41L0Er?= =?utf-8?B?MitWTlpkYUdySktRWmsxRmlxVXdnSEZud3RJQll1eEdtTFpnb3lqWHJFYWwx?= =?utf-8?B?U1E2ZEhnQ3Rpa2M4WWFpWTJiQkoxOEtBSlpKYVcya0dQbUpjSll0b1p4Ujkw?= =?utf-8?B?SDIzbjhMZGFKcEJFM3dEV25RWmlwQU1tMjh5MG9taGhiUHdIV0FFbEEwbnBQ?= =?utf-8?B?bzFjQVIvbGJPWjBVNzQzckFSS0dpWHZ2aTBnd21rVmxqOTFtWkxCcnhBRFlV?= =?utf-8?B?Q1JYdjZXblhxNmdReXdJMFdrMTczbmNyYjN5U29hM0lZTGVZaEVUbkRpdkha?= =?utf-8?B?eGwrTk9lNyt2cC9EaUdXaGRmTHhKckdLY09yN2xrMXB3TDJzQW84d0kraC9O?= =?utf-8?B?clJsTlFnclQ4VmNuY2ZpeHNibHhJSlFCSWU3K2JGdmFrMTI5Q0w2U3FBb1M2?= =?utf-8?B?OVMyWVBxTnhoNFlkYjR4eXlMLzlhMStUKzV2a05VK1p2elNaWWZ5VXhsTXRT?= =?utf-8?B?RHpPc21Gc011T2Nhc2E4cVZURGR4OERqRDNhMVBUdkVGZkZvbmlTUTdhSTYv?= =?utf-8?B?eldKaDBkNWNibm9pZGFrM1BYR2JTa3k1bmt0c2JnMHdURDljYkRNZWRxRVBx?= =?utf-8?B?Ym9YV0JHZG4rWWFLckNmamNJZ2N5WThqQThYczd5aTRQRmNUUUpPYW1IbGd6?= =?utf-8?B?SU1BempnV1dKcEFWSWxpV25ycUZBWERTUCs4elEzUUdSLy9idWE4Y0ZPcjQ5?= =?utf-8?B?OVI2cC9JeXZtSzZjMXJCMWMxRTRmWC9NVHMrdU0zYk5wektVa2I3d2pBUmYz?= =?utf-8?B?aEZUN2VVQ0VYcGhvSnBMTk5LelFHcHFVV2lxS3krSzJ1ZmExUlE2T1owV3FT?= =?utf-8?B?S2czajRsS1VEVXdGY1k1K0RSTVpjNWZTb3orcW1aVEdxQklhWmZ2VXMyaGVn?= =?utf-8?B?TFYvQllpWTdEVHByVmZHVmZmOXE1ZGV0OXFsTzltWFJwVGMxRUdqclBid0p4?= =?utf-8?B?dkY3OUloWmp5eE9ObUJybGFzcXBOdWhUeE15Y3c5cXhpaVlXcGtkZkVUcElC?= =?utf-8?B?RFhXZU5rQ0haMU9lK0M4MmJXRU1KZ0hyZnBZemhKYmhTVE5rWEJFYVE2VENl?= =?utf-8?B?cFh5akdiNXM1akovNGlXNG9ydENXQjlEcXBuVWRBK2hucjNSUjlSS21tZWpq?= =?utf-8?B?MnZjMVdsQUh2aFkydlhRU3c3Y1p2ZytBN0s1WUttcHNaVnN4VmxFcVdHZE1P?= =?utf-8?B?NVVsZ3o1SFZNei85WFF0NEkxdmI0SEIzZ2MvdktOcHV5VnhXak1nR0ppSDcw?= =?utf-8?Q?g6x5oibCRROaUpqYJmZUOr0sgrh9vvM8p90mhs7?= X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f7903fd-f5a5-4590-f73d-08d95790efcb X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2021 21:43:46.1143 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kbsbRt4d9zW8cL6qJ+4JEgay0i6jRHQ0KhsOmkqrIb0fnwx3rt3UlFVFztxpy0jQn07Q1RfezHEPKGqKa0kTmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0302MB2822 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 8/2/21 3:21 PM, Simon Glass wrote: > Hi Pali, > > On Mon, 2 Aug 2021 at 07:20, Pali Rohár wrote: >> >> Header file version.h does not use anything from timestamp.h. Including of >> timestamp.h has side effect which cause recompiling object file at every >> make run because timestamp.h changes at every run. >> >> So remove timestamp.h from version.h and include timestamp.h in files >> which needs it. >> >> This change reduce recompilation time of final U-Boot binary when U-Boot >> source files were not changed as less source files needs to be recompiled. >> >> Signed-off-by: Pali Rohár >> --- >> arch/arm/mach-rockchip/tpl.c | 4 ++++ >> board/work-microwave/work_92105/work_92105_display.c | 1 + >> cmd/version.c | 1 + >> common/spl/spl.c | 4 ++++ >> drivers/rtc/emul_rtc.c | 2 +- >> include/version.h | 2 -- >> 6 files changed, 11 insertions(+), 3 deletions(-) > > Reviewed-by: Simon Glass > > I assume we do actually want to regenerate the timestamp when U-Boot > builds, even if nothing has changed. Is that right? I know this is the current behavior, but it would be nice if this was not the case. If one is building U-Boot as part of a larger project, one might want to have a makefile rule like u-boot/u-boot.bin: $(MAKE) -C u-boot $(@F) but u-boot/u-boot.bin will always be remade even if no changes have been done. This will cause make to remake all dependents of U-Boot as well (which can be rather time-consuming). At the moment, I just use U-Boot as an order-only dependency and remake it manually. But I would love it if U-Boot was only remade if dependencies had actually changed, since this would make it easier to integrate it with the rest of my build system. --Sean