From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1414C35247 for ; Tue, 4 Feb 2020 00:54:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9155D2084E for ; Tue, 4 Feb 2020 00:54:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="M0sqb1E6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727156AbgBDAyb (ORCPT ); Mon, 3 Feb 2020 19:54:31 -0500 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:53789 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726872AbgBDAyb (ORCPT ); Mon, 3 Feb 2020 19:54:31 -0500 Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 35C81886BF for ; Tue, 4 Feb 2020 13:54:28 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1580777668; bh=tKQC6Ipa66JarTP+nI+/F28NSi13XpZtVs3kbVJL2vA=; h=From:To:CC:Subject:Date:References:In-Reply-To; b=M0sqb1E68F0qUCN8SZtCYA4EcSGqM8y88CK9Z2MFzPUJaMIxvRbjpiwFsFzlWJOTZ FYW7pKgK/pZ0/RxVz/xZnKKpnBHCUJHyK1AqgtqILuN23QaekqimUAmOKQ9etomlBJ 9mFzqUtwCq74AeWUzQqfL/PQ6ncVofyOSFV05nVU9cXXDOXquOCaiAcD4FbtJuMWVj MIlf1JPfAqD+Ie5E4wk6SxqeYDhqQj/vITtymmApV+UvBZ0f2NNMMmTEUf7Ry1lKsU HzGQ7dQbt6AXM9Zryl584xpMY165fYFJDCLDmKVHLyJoCFHE99jDkMQdcbCuqTUf0E 76lQrrtkTxPPQ== Received: from svr-chch-ex1.atlnz.lc (Not Verified[10.32.16.77]) by mmarshal3.atlnz.lc with Trustwave SEG (v7,5,8,10121) id ; Tue, 04 Feb 2020 13:54:29 +1300 Received: from svr-chch-ex1.atlnz.lc (2001:df5:b000:bc8::77) by svr-chch-ex1.atlnz.lc (2001:df5:b000:bc8::77) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 4 Feb 2020 13:54:27 +1300 Received: from svr-chch-ex1.atlnz.lc ([fe80::409d:36f5:8899:92e8]) by svr-chch-ex1.atlnz.lc ([fe80::409d:36f5:8899:92e8%12]) with mapi id 15.00.1473.005; Tue, 4 Feb 2020 13:54:27 +1300 From: Chris Packham To: "linux@roeck-us.net" , "gregkh@linuxfoundation.org" CC: "linux-kernel@vger.kernel.org" , "wambui.karugax@gmail.com" , "devel@driverdev.osuosl.org" , "julia.lawall@lip6.fr" Subject: Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN Thread-Topic: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN Thread-Index: AQHV2vWmtCtKfNrhHkKtpp3ao2yroA== Date: Tue, 4 Feb 2020 00:54:26 +0000 Message-ID: <8168627a60e9e851860f8cc295498423828401c9.camel@alliedtelesis.co.nz> References: <20191202141836.9363-1-linux@roeck-us.net> <20191202165231.GA728202@kroah.com> <20191202173620.GA29323@roeck-us.net> <20191202181505.GA732872@kroah.com> In-Reply-To: <20191202181505.GA732872@kroah.com> Accept-Language: en-NZ, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.32.28.97] Content-Type: text/plain; charset="utf-8" Content-ID: <8642AD139CC0B24498FBF8659832B143@atlnz.lc> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGkgR3JlZyAmIEFsbCwNCg0KT24gTW9uLCAyMDE5LTEyLTAyIGF0IDE5OjE1ICswMTAwLCBHcmVn IEtyb2FoLUhhcnRtYW4gd3JvdGU6DQo+IE9uIE1vbiwgRGVjIDAyLCAyMDE5IGF0IDA5OjM2OjIw QU0gLTA4MDAsIEd1ZW50ZXIgUm9lY2sgd3JvdGU6DQo+ID4gT24gTW9uLCBEZWMgMDIsIDIwMTkg YXQgMDU6NTI6MzFQTSArMDEwMCwgR3JlZyBLcm9haC1IYXJ0bWFuIHdyb3RlOg0KPiA+ID4gT24g TW9uLCBEZWMgMDIsIDIwMTkgYXQgMDY6MTg6MzZBTSAtMDgwMCwgR3VlbnRlciBSb2VjayB3cm90 ZToNCj4gPiA+ID4gVGhlIGNvZGUgZG9lc24ndCBjb21waWxlIGR1ZSB0byBpbmNvbXBhdGlibGUg cG9pbnRlciBlcnJvcnMNCj4gPiA+ID4gc3VjaCBhcw0KPiA+ID4gPiANCj4gPiA+ID4gZHJpdmVy cy9zdGFnaW5nL29jdGVvbi9ldGhlcm5ldC10eC5jOjY0OTo1MDogZXJyb3I6DQo+ID4gPiA+IAlw YXNzaW5nIGFyZ3VtZW50IDEgb2YgJ2N2bXhfd3FlX2dldF9ncnAnIGZyb20NCj4gPiA+ID4gaW5j b21wYXRpYmxlIHBvaW50ZXIgdHlwZQ0KPiA+ID4gPiANCj4gPiA+ID4gVGhpcyBpcyBkdWUgdG8g bWl4aW5nLCBmb3IgZXhhbXBsZSwgY3ZteF93cWVfdCB3aXRoICdzdHJ1Y3QNCj4gPiA+ID4gY3Zt eF93cWUnLg0KPiA+ID4gPiANCj4gPiA+ID4gVW5mb3J0dW5hdGVseSwgb25lIGNhbiBub3QganVz dCByZXZlcnQgdGhlIHByaW1hcnkgb2ZmZW5kaW5nDQo+ID4gPiA+IGNvbW1pdCwgYXMgZG9pbmcg c28NCj4gPiA+ID4gcmVzdWx0cyBpbiBzZWNvbmRhcnkgZXJyb3JzLiBUaGlzIGlzIG1hZGUgd29y c2UgYnkgdGhlIGZhY3QNCj4gPiA+ID4gdGhhdCB0aGUgInJlbW92ZWQiDQo+ID4gPiA+IHR5cGVk ZWZzIHN0aWxsIGV4aXN0IGFuZCBhcmUgdXNlZCB3aWRlbHkgb3V0c2lkZSB0aGUgc3RhZ2luZw0K PiA+ID4gPiBkaXJlY3RvcnksDQo+ID4gPiA+IG1ha2luZyB0aGUgZW50aXJlIHNldCBvZiAicmVt b3ZlIHR5cGVkZWYiIGNoYW5nZXMgcG9pbnRsZXNzIGFuZA0KPiA+ID4gPiB3cm9uZy4NCj4gPiA+ IA0KPiA+ID4gVWdoLCBzb3JyeSBhYm91dCB0aGF0Lg0KPiA+ID4gDQo+ID4gPiA+IFJlZmxlY3Qg cmVhbGl0eSBhbmQgbWFyayB0aGUgZHJpdmVyIGFzIEJST0tFTi4NCj4gPiA+IA0KPiA+ID4gU2hv dWxkIEkganVzdCBkZWxldGUgdGhpcyB0aGluZz8gIE5vIG9uZSBzZWVtcyB0byBiZSB1c2luZyBp dCBhbmQNCj4gPiA+IHRoZXJlDQo+ID4gPiBpcyBubyBtb3ZlIHRvIGdldCBpdCBvdXQgb2Ygc3Rh Z2luZyBhdCBhbGwuDQo+ID4gPiANCj4gPiA+IFdpbGwgYW55b25lIGFjdHVhbGx5IG1pc3MgaXQ/ ICBJdCBjYW4gYWx3YXlzIGNvbWUgYmFjayBvZiBzb21lb25lDQo+ID4gPiBkb2VzLi4uDQo+ID4g PiANCj4gPiANCj4gPiBBbGwgaXQgZG9lcyBpcyBjYXVzaW5nIHRyb3VibGUgYW5kIG1pc2d1aWRl ZCBhdHRlbXB0cyB0byBjbGVhbiBpdA0KPiA+IHVwLg0KPiA+IElmIGFueXRoaW5nLCB0aGUgd2hv bGUgdGhpbmcgZ29lcyBpbnRvIHRoZSB3cm9uZyBkaXJlY3Rpb24gKGRlY2xhcmUNCj4gPiBhDQo+ ID4gY29tcGxldGUgc2V0IG9mIGR1bW15IGZ1bmN0aW9ucyBqdXN0IHRvIGJlIGFibGUgdG8gYnVp bGQgdGhlIGRyaXZlcg0KPiA+IHdpdGggQ09NUElMRV9URVNUID8gU2VyaW91c2x5ID8pLg0KPiA+ IA0KPiA+IEkgc2Vjb25kIHRoZSBtb3Rpb24gdG8gZHJvcCBpdC4gVGhpcyBoYXMgYmVlbiBpbiBz dGFnaW5nIGZvciAxMA0KPiA+IHllYXJzLg0KPiA+IERvbid0IHdlIGhhdmUgc29tZSBraW5kIG9m IHRpbWUgbGltaXQgZm9yIGNvZGUgaW4gc3RhZ2luZyA/IElmIG5vdCwNCj4gPiBzaG91bGQgd2Ug PyBJZiBhbnlvbmUgcmVhbGx5IG5lZWRzIGl0LCB0aGF0IHBlcnNvbiBvciBncm91cCBzaG91bGQN Cj4gPiByZWFsbHkgaW52ZXN0IHRoZSB0aW1lIHRvIGdldCBpdCBvdXQgb2Ygc3RhZ2luZyBmb3Ig Z29vZC4NCj4gDQo+IDEwIHllYXJzPyAgVWdoLCB5ZXMsIGl0J3MgdGltZSB0byBkcm9wIHRoZSB0 aGluZywgSSdsbCBkbyBzbyBhZnRlcg0KPiAtcmMxDQo+IGlzIG91dC4NCj4gDQoNCkFzIGEgbG9u ZyBzdWZmZXJpbmcgQ2F2aXVtIE1JUHMgY3VzdG9tZXIgY291bGQgSSByZXF1ZXN0IHRoYXQgdGhp cw0KaXNuJ3QgZHJvcHBlZC4gSSdsbCBnZXQgc29tZW9uZSBoZXJlIHRvIHRha2UgYSBsb29rIGF0 IGZpeGluZyB0aGUgYnVpbGQNCmlzc3Vlcy4NCg0KR2l2ZW4gb3VyIHBsYXRmb3JtIGlzbid0IHVw c3RyZWFtIEknbSBub3Qgc3VyZSB0aGF0IHdlJ2xsIGJlIGFibGUgdG8NCm1lZXQgdGhlIGNyaXRl cmlhIGZvciBnZXR0aW5nIGl0IG91dCBvZiBzdGFnaW5nLg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA714C35247 for ; Tue, 4 Feb 2020 01:00:53 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 276552084E for ; Tue, 4 Feb 2020 01:00:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="M0sqb1E6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 276552084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alliedtelesis.co.nz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D42CB84D8E; Tue, 4 Feb 2020 01:00:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pKoP8t2qgZFm; Tue, 4 Feb 2020 01:00:48 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id D801184854; Tue, 4 Feb 2020 01:00:48 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id BD13B1BF980 for ; Tue, 4 Feb 2020 01:00:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id B79B220010 for ; Tue, 4 Feb 2020 01:00:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VPCgUD-6Io-U for ; Tue, 4 Feb 2020 01:00:46 +0000 (UTC) X-Greylist: delayed 00:06:15 by SQLgrey-1.7.6 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [202.36.163.20]) by silver.osuosl.org (Postfix) with ESMTPS id 1A0E92000E for ; Tue, 4 Feb 2020 01:00:45 +0000 (UTC) Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 3394C806B7; Tue, 4 Feb 2020 13:54:28 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1580777668; bh=tKQC6Ipa66JarTP+nI+/F28NSi13XpZtVs3kbVJL2vA=; h=From:To:CC:Subject:Date:References:In-Reply-To; b=M0sqb1E68F0qUCN8SZtCYA4EcSGqM8y88CK9Z2MFzPUJaMIxvRbjpiwFsFzlWJOTZ FYW7pKgK/pZ0/RxVz/xZnKKpnBHCUJHyK1AqgtqILuN23QaekqimUAmOKQ9etomlBJ 9mFzqUtwCq74AeWUzQqfL/PQ6ncVofyOSFV05nVU9cXXDOXquOCaiAcD4FbtJuMWVj MIlf1JPfAqD+Ie5E4wk6SxqeYDhqQj/vITtymmApV+UvBZ0f2NNMMmTEUf7Ry1lKsU HzGQ7dQbt6AXM9Zryl584xpMY165fYFJDCLDmKVHLyJoCFHE99jDkMQdcbCuqTUf0E 76lQrrtkTxPPQ== Received: from svr-chch-ex1.atlnz.lc (Not Verified[10.32.16.77]) by mmarshal3.atlnz.lc with Trustwave SEG (v7, 5, 8, 10121) id ; Tue, 04 Feb 2020 13:54:29 +1300 Received: from svr-chch-ex1.atlnz.lc (2001:df5:b000:bc8::77) by svr-chch-ex1.atlnz.lc (2001:df5:b000:bc8::77) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 4 Feb 2020 13:54:27 +1300 Received: from svr-chch-ex1.atlnz.lc ([fe80::409d:36f5:8899:92e8]) by svr-chch-ex1.atlnz.lc ([fe80::409d:36f5:8899:92e8%12]) with mapi id 15.00.1473.005; Tue, 4 Feb 2020 13:54:27 +1300 From: Chris Packham To: "linux@roeck-us.net" , "gregkh@linuxfoundation.org" Subject: Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN Thread-Topic: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN Thread-Index: AQHV2vWmtCtKfNrhHkKtpp3ao2yroA== Date: Tue, 4 Feb 2020 00:54:26 +0000 Message-ID: <8168627a60e9e851860f8cc295498423828401c9.camel@alliedtelesis.co.nz> References: <20191202141836.9363-1-linux@roeck-us.net> <20191202165231.GA728202@kroah.com> <20191202173620.GA29323@roeck-us.net> <20191202181505.GA732872@kroah.com> In-Reply-To: <20191202181505.GA732872@kroah.com> Accept-Language: en-NZ, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.32.28.97] Content-ID: <8642AD139CC0B24498FBF8659832B143@atlnz.lc> MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devel@driverdev.osuosl.org" , "julia.lawall@lip6.fr" , "linux-kernel@vger.kernel.org" , "wambui.karugax@gmail.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Greg & All, On Mon, 2019-12-02 at 19:15 +0100, Greg Kroah-Hartman wrote: > On Mon, Dec 02, 2019 at 09:36:20AM -0800, Guenter Roeck wrote: > > On Mon, Dec 02, 2019 at 05:52:31PM +0100, Greg Kroah-Hartman wrote: > > > On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote: > > > > The code doesn't compile due to incompatible pointer errors > > > > such as > > > > > > > > drivers/staging/octeon/ethernet-tx.c:649:50: error: > > > > passing argument 1 of 'cvmx_wqe_get_grp' from > > > > incompatible pointer type > > > > > > > > This is due to mixing, for example, cvmx_wqe_t with 'struct > > > > cvmx_wqe'. > > > > > > > > Unfortunately, one can not just revert the primary offending > > > > commit, as doing so > > > > results in secondary errors. This is made worse by the fact > > > > that the "removed" > > > > typedefs still exist and are used widely outside the staging > > > > directory, > > > > making the entire set of "remove typedef" changes pointless and > > > > wrong. > > > > > > Ugh, sorry about that. > > > > > > > Reflect reality and mark the driver as BROKEN. > > > > > > Should I just delete this thing? No one seems to be using it and > > > there > > > is no move to get it out of staging at all. > > > > > > Will anyone actually miss it? It can always come back of someone > > > does... > > > > > > > All it does is causing trouble and misguided attempts to clean it > > up. > > If anything, the whole thing goes into the wrong direction (declare > > a > > complete set of dummy functions just to be able to build the driver > > with COMPILE_TEST ? Seriously ?). > > > > I second the motion to drop it. This has been in staging for 10 > > years. > > Don't we have some kind of time limit for code in staging ? If not, > > should we ? If anyone really needs it, that person or group should > > really invest the time to get it out of staging for good. > > 10 years? Ugh, yes, it's time to drop the thing, I'll do so after > -rc1 > is out. > As a long suffering Cavium MIPs customer could I request that this isn't dropped. I'll get someone here to take a look at fixing the build issues. Given our platform isn't upstream I'm not sure that we'll be able to meet the criteria for getting it out of staging. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel