From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v3 2/3] malloc: allow reserving biggest
	element
Date: Mon, 14 May 2018 09:22:00 +0100
Message-ID: <81764c64-fb1f-6230-3ec5-f36830d1f4eb@intel.com>
References: <777ae6b10a7524e188c07ba14e576fc7b0e21018.1524729978.git.anatoly.burakov@intel.com>
 <cover.1525366407.git.anatoly.burakov@intel.com>
 <7844071bf096c83cf2e92eb4bc759cf013ba47f0.1525366407.git.anatoly.burakov@intel.com>
 <cfe99755-703a-f170-c493-9d9e1c73b472@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
To: Remy Horton <remy.horton@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id C010C1BAFC
 for <dev@dpdk.org>; Mon, 14 May 2018 10:22:02 +0200 (CEST)
In-Reply-To: <cfe99755-703a-f170-c493-9d9e1c73b472@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10-May-18 2:57 PM, Remy Horton wrote:
> 
> On 03/05/2018 18:18, Anatoly Burakov wrote:
> [..]
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> [..]
>> +    for (idx = 0; idx < RTE_HEAP_NUM_FREELISTS; idx++) {
>> +        for (elem = LIST_FIRST(&heap->free_head[idx]);
>> +                !!elem; elem = LIST_NEXT(elem, free_list)) {
> 
> Why the double-negation?
> 
> Otherwise, see no issues.
> 
> Acked-by: Remy Horton <remy.horton@intel.com>
> 
> 
> 

Presumably to make it a boolean value, not a pointer. This was written 
before my time, didn't change it :)

-- 
Thanks,
Anatoly