From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B7F9C433EF for ; Mon, 25 Oct 2021 08:01:04 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA98960F22 for ; Mon, 25 Oct 2021 08:01:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DA98960F22 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 56B9683311; Mon, 25 Oct 2021 10:01:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.b="DfIdux5X"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D9F4883460; Mon, 25 Oct 2021 10:00:58 +0200 (CEST) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D6A278311B for ; Mon, 25 Oct 2021 10:00:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=heinrich.schuchardt@canonical.com Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 4AA2B3FFED for ; Mon, 25 Oct 2021 08:00:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1635148852; bh=/EDWIhcC8myM8Kn7L/R55cu1L+yDFtNmlRPzFBzm6eI=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=DfIdux5XtvRAxlQrpx2m6ezIIC+vrr/scOjP0xFpYdEou1/qrud3FvsqKpQOetyqX fFZDz2FB9onmFTg2TVXYYBU9EUUFB4xjHfdFxemXPYMy6CTVAFh5knwDVmiAsDPqND 4qfYQ8esm3Mmq4icF+5XCd0LwtDpImwsoOnZLOAY+xHu4ZIwoWQ4cDwzS2+QyrCw0p pgeFoool17ya8brXYdra4hAbFP0DLyspzz7YRQuPiFLzZf0TKgSa3sCEqdrHDyRMo3 6Zwh1qowC24b+iMYoWWhhs8CPmXpRtE15z6ekActR1Xpp9McV78z9xYTBGZTkjvKMv gfYuQ5YLRi9eA== Received: by mail-wm1-f71.google.com with SMTP id 5-20020a1c0005000000b0032c9c156acbso3307279wma.9 for ; Mon, 25 Oct 2021 01:00:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=/EDWIhcC8myM8Kn7L/R55cu1L+yDFtNmlRPzFBzm6eI=; b=qCMc0rvYLJaJBMDa0+w7Vi6Qu4oCBbv1RQuIDcxSYWQq/DXy9SpeUe0Jn3oqzuvTXs NZg9vBBNTVVpvYG09kgv+0r8omDeomwOSfEpuZ+1Av1tjHNdtBaPqQKR8rnOszggnXeR 4o9vwWIivhhB4k3Lua7budHtkVr7DhMK9jZ/iaLep+66Ps1d/f4oQvnfF0i2ughnfpOV qY010dUhCr9OcKw+46zCU30nzyBYxRFJVroeYQ1SO2Drryg5daV9EwBNhzGx1obJyz9S gXgp/K6SnjvSptrU73b3jb85PxA/Iab0JSOLUr8IEiEogCTCngKzh4VEBH2iHTomg3nP dIUQ== X-Gm-Message-State: AOAM531FM+j3fAqwqrUwQ0bySvzUgmcRd1/2TjTo9819H5HdF9RoBHCc MIywpziCE5tueQy014lPlsY2vsQY+CFqnDFZFZseLzEj68I3BP65Oo7nqi9guBuRxnTyOh24J7U EPGFBKv2jlgKNrFJblcLyXbmTRttEXj8= X-Received: by 2002:a5d:59a3:: with SMTP id p3mr21649964wrr.146.1635148851869; Mon, 25 Oct 2021 01:00:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5E2icPtpsnZtLR7TLUdqXMBhM7OqKRyMKA2Jbcer/7K/tJvgz2bntgkIBVWNhU4+kEOHurw== X-Received: by 2002:a5d:59a3:: with SMTP id p3mr21649943wrr.146.1635148851706; Mon, 25 Oct 2021 01:00:51 -0700 (PDT) Received: from [192.168.123.55] (ip-88-152-144-157.hsi03.unitymediagroup.de. [88.152.144.157]) by smtp.gmail.com with ESMTPSA id a2sm15553354wru.82.2021.10.25.01.00.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 01:00:51 -0700 (PDT) Message-ID: <81777666-a5e1-b32b-b41e-70d894a44b94@canonical.com> Date: Mon, 25 Oct 2021 10:00:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH 1/1] blk: simplify blk_get_devnum_by_typename() Content-Language: en-US From: Heinrich Schuchardt To: Simon Glass Cc: Patrick Delaunay , Ilias Apalodimas , U-Boot Mailing List References: <20211023140647.7661-1-heinrich.schuchardt@canonical.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 10/25/21 09:54, Heinrich Schuchardt wrote: > On 10/24/21 21:54, Simon Glass wrote: >> Hi Heinrich, >> >> On Sat, 23 Oct 2021 at 08:06, Heinrich Schuchardt >> wrote: >>> >>> The block descriptor contains the if_type. There is no need to first >>> look >>> up the uclass for the if_type and then to check the parent device's >>> uclass >>> to know if the device has the correct if_type. >>> >>> Signed-off-by: Heinrich Schuchardt >>> --- >>>   drivers/block/blk-uclass.c | 35 +---------------------------------- >>>   1 file changed, 1 insertion(+), 34 deletions(-) >> >> This seems to be heading in the wrong direction though. >> >> The IF_TYPE should really go away and be replaced with the UCLASS ID, >> I think. >> >> At present we have lots of calls to blk_create_device_f() which >> specify the type. I think we should drop the IF_TYPE_.. arg to that >> function and have it figured out from the uclass, in the interim. >> >> But why do we need IF_TYPE now? > > I admit that this patch is just an intermediate step. > > We can replace IF_TYPE by ULASS ID once SPL block devices are always > using the driver model. Have we reached this point yet? I have not seen > drivers/block/blk_legacy.c being deleted. qemu_malta64, qemu_malta64el, qemu_malta, qemu_maltael are examples of defconfigs requiring drivers/block/blk_legacy.c Best regards Heinrich > > Removing if_type_uclass_id[] is anyway on the right path. > > Best regards > > Heinrich