From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966118AbcIHKBM (ORCPT ); Thu, 8 Sep 2016 06:01:12 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:50060 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964973AbcIHKBK (ORCPT ); Thu, 8 Sep 2016 06:01:10 -0400 From: Arnd Bergmann To: Emil Velikov Cc: Baoyou Xie , Benjamin Gaignard , Vincent Abriou , David Airlie , xie.baoyou@zte.com.cn, "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel Subject: Re: [PATCH] drm/sti: mark symbols static where possible Date: Thu, 08 Sep 2016 11:56:12 +0200 Message-ID: <8179856.bd6bOcXQvk@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1473246307-889-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:MaNEXsKJb61e8oQK1sJBDxdLrOxolYpCOBtfR9mDVU3DGR8XylT CaHFDVBMUgyyRdz5HoyUW+NX9kINfFeMxG90FyRG8fBzrMOhluIFrVIL+dr1pQpBRn+hoI/ rJMI9eR1Y06D3klSwbaS6qgHKci8C7icIjlK1SNlL4hobBGuG6GsFZsroRVXlSdG4ISbQoS IcwhLGYq8Is92fw4n+BXA== X-UI-Out-Filterresults: notjunk:1;V01:K0:ju5EM7Q+PDU=:PvOj58qQQZ4CyTszbKjM49 R0iHpNE8LslZTJgZaJkuX6vZ7qjjNu1wVHaR4Fac/8yuU7dv713M73RrtD3TZYcVUK/kpXZMN 1dG7hF1sujRdm3BzfETrXIHdZXp2eSmkKW4i3a37PNd1sqLaTBmDB1ppHEMkTojUU34SzvwpF ZZEml+qQoZfdICCcb7aMS5Nmv4V/ZvWjiUCJsuI5jaD6+nprKHd4OWM6tn4KvMXCbkJVonYmi bAoJeNIGdahuOLiOKylHKyCTr3JpAV8K0j6Rp+rT+13vOWtTWJ58a7MvSD88DzXh8NoNFvUYv miM8tSoeNLyMxjrBA1pq+k2p61jkzDP215vQeGdH00nhwxsHCeZ52BZRdu6W1HGzXdJnPmJyI oRdD22lJeISic0mMx6sOrrvHsiN1EhyjIfRkzt025wpDg/VyA4N6/Muucg8RCoVCOGuJX7l2I 2DDzmeanEuHyDScqILQr9YgaeNHOLn3OCW8P1WOmYACWg+EFsfVAK3SqfUihLzQz49ekMxYFB 2Lj8BeNGRn5PQD0jlvca+Zn0zyUpLWhJhQZuLWOextI/2/NUL+2yiAp/8/wo8cqlzXIJhdP2b KTm6Ph29bieZqXDmlh3mlXWu8yPTzb+PZxcW8HRow/QVMSZs/BITyXSTvv3q6Oy98X1g8XTYf EEr+AQcAeCOnm3hMaP6NjY6oplgNzB4ylnAUHAx89yG3KeA6yvqIhCPiU2RP16EYWk4ygocVw YOTBDt/RWpjK1ERv Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, September 8, 2016 10:35:17 AM CEST Emil Velikov wrote: > On 7 September 2016 at 12:05, Baoyou Xie wrote: > > We get 2 warnings when building kernel with W=1: > As you're going through DRM I was wondering if you have a rough number > of warnings we get at the various W levels 1,2,... I've looked at the W=1 warnings overall, and the count I got a month ago was 648 warnings for drivers/gpu/:: 471 -Werror=missing-prototypes 12 -Werror=type-limits 124 -Werror=unused-but-set-variable 41 -Werror=unused-const-variable= vs for the whole kernel 2033 -Werror=missing-prototypes 58 -Werror=suggest-attribute=format 167 -Werror=type-limits 1398 -Werror=unused-but-set-variable 1526 -Werror=unused-const-variable= but that was after I had already fixed some of the other warnings locally. It shouldn't be hard to fix all of them for any given subsystem, often a single line change gets rid of a number of individual warnings. My basic idea however is not to do it by subsystem but instead do it one warning at a time for the entire kernel and then enable that warning by default without W=1. > Hope you'll have the time/interest to sort some of the W>1 ones as well I suggested to Baoyou that he starts looking at missing-prototype warnings across the kernel, as these are likely to find the most actual bugs out of the W=1 warnings we get. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] drm/sti: mark symbols static where possible Date: Thu, 08 Sep 2016 11:56:12 +0200 Message-ID: <8179856.bd6bOcXQvk@wuerfel> References: <1473246307-889-1-git-send-email-baoyou.xie@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFF286EDEB for ; Thu, 8 Sep 2016 10:01:07 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: xie.baoyou@zte.com.cn, "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , Baoyou Xie , Vincent Abriou List-Id: dri-devel@lists.freedesktop.org T24gVGh1cnNkYXksIFNlcHRlbWJlciA4LCAyMDE2IDEwOjM1OjE3IEFNIENFU1QgRW1pbCBWZWxp a292IHdyb3RlOgo+IE9uIDcgU2VwdGVtYmVyIDIwMTYgYXQgMTI6MDUsIEJhb3lvdSBYaWUgPGJh b3lvdS54aWVAbGluYXJvLm9yZz4gd3JvdGU6Cj4gPiBXZSBnZXQgMiB3YXJuaW5ncyB3aGVuIGJ1 aWxkaW5nIGtlcm5lbCB3aXRoIFc9MToKPiBBcyB5b3UncmUgZ29pbmcgdGhyb3VnaCBEUk0gSSB3 YXMgd29uZGVyaW5nIGlmIHlvdSBoYXZlIGEgcm91Z2ggbnVtYmVyCj4gb2Ygd2FybmluZ3Mgd2Ug Z2V0IGF0IHRoZSB2YXJpb3VzIFcgbGV2ZWxzIDEsMiwuLi4KCkkndmUgbG9va2VkIGF0IHRoZSBX PTEgd2FybmluZ3Mgb3ZlcmFsbCwgYW5kIHRoZSBjb3VudCBJIGdvdCBhCm1vbnRoIGFnbyB3YXMg NjQ4IHdhcm5pbmdzIGZvciBkcml2ZXJzL2dwdS86OgoKICAgIDQ3MSAtV2Vycm9yPW1pc3Npbmct cHJvdG90eXBlcwogICAgIDEyIC1XZXJyb3I9dHlwZS1saW1pdHMKICAgIDEyNCAtV2Vycm9yPXVu dXNlZC1idXQtc2V0LXZhcmlhYmxlCiAgICAgNDEgLVdlcnJvcj11bnVzZWQtY29uc3QtdmFyaWFi bGU9Cgp2cyBmb3IgdGhlIHdob2xlIGtlcm5lbAoKICAgMjAzMyAtV2Vycm9yPW1pc3NpbmctcHJv dG90eXBlcwogICAgIDU4IC1XZXJyb3I9c3VnZ2VzdC1hdHRyaWJ1dGU9Zm9ybWF0CiAgICAxNjcg LVdlcnJvcj10eXBlLWxpbWl0cwogICAxMzk4IC1XZXJyb3I9dW51c2VkLWJ1dC1zZXQtdmFyaWFi bGUKICAgMTUyNiAtV2Vycm9yPXVudXNlZC1jb25zdC12YXJpYWJsZT0KCmJ1dCB0aGF0IHdhcyBh ZnRlciBJIGhhZCBhbHJlYWR5IGZpeGVkIHNvbWUgb2YgdGhlIG90aGVyIHdhcm5pbmdzCmxvY2Fs bHkuIEl0IHNob3VsZG4ndCBiZSBoYXJkIHRvIGZpeCBhbGwgb2YgdGhlbSBmb3IgYW55IGdpdmVu CnN1YnN5c3RlbSwgb2Z0ZW4gYSBzaW5nbGUgbGluZSBjaGFuZ2UgZ2V0cyByaWQgb2YgYSBudW1i ZXIKb2YgaW5kaXZpZHVhbCB3YXJuaW5ncy4KCk15IGJhc2ljIGlkZWEgaG93ZXZlciBpcyBub3Qg dG8gZG8gaXQgYnkgc3Vic3lzdGVtIGJ1dCBpbnN0ZWFkCmRvIGl0IG9uZSB3YXJuaW5nIGF0IGEg dGltZSBmb3IgdGhlIGVudGlyZSBrZXJuZWwgYW5kIHRoZW4gZW5hYmxlCnRoYXQgd2FybmluZyBi eSBkZWZhdWx0IHdpdGhvdXQgVz0xLgoKPiBIb3BlIHlvdSdsbCBoYXZlIHRoZSB0aW1lL2ludGVy ZXN0IHRvIHNvcnQgc29tZSBvZiB0aGUgVz4xIG9uZXMgYXMgd2VsbCAKCkkgc3VnZ2VzdGVkIHRv IEJhb3lvdSB0aGF0IGhlIHN0YXJ0cyBsb29raW5nIGF0IG1pc3NpbmctcHJvdG90eXBlCndhcm5p bmdzIGFjcm9zcyB0aGUga2VybmVsLCBhcyB0aGVzZSBhcmUgbGlrZWx5IHRvIGZpbmQgdGhlIG1v c3QKYWN0dWFsIGJ1Z3Mgb3V0IG9mIHRoZSBXPTEgd2FybmluZ3Mgd2UgZ2V0LgoKCUFybmQKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==