From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3DF9C433EF for ; Thu, 12 May 2022 06:28:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E900584354; Thu, 12 May 2022 08:28:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="F8utxK+z"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2B50184356; Thu, 12 May 2022 08:28:34 +0200 (CEST) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 647968015D for ; Thu, 12 May 2022 08:28:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vaishnav.a@ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 24C6SMXk094950; Thu, 12 May 2022 01:28:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1652336902; bh=sRslCe+Tm8pPmnFL2PNe0sEGXIiueluNlTQZ6RodRkA=; h=Date:Subject:To:References:From:In-Reply-To; b=F8utxK+zECVSAdMWn8LMPSIqiyVHHX3fPJWRZN9e+DFVKV7gGNTQtFBZ/H2EkTNzE AbemBo+DJs4YF1lgDWGRUr/vVwrVpmxWgkaAbCWj2rXJORSGFfYVWmy14D3Tq1tjkT a19lJHfpTH/wxMww/K6Utd930FyZw73EC1hMjNsY= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 24C6SMTl109508 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 12 May 2022 01:28:22 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 12 May 2022 01:28:22 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Thu, 12 May 2022 01:28:21 -0500 Received: from [10.24.69.12] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 24C6SGuH036040; Thu, 12 May 2022 01:28:17 -0500 Message-ID: <818693dd-6b8f-1532-06df-5bdee065c414@ti.com> Date: Thu, 12 May 2022 11:58:16 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 1/2] common: spl: spl_spi: add support for dynamic override of sf bus Content-Language: en-US To: "hs@denx.de" , "u-boot@lists.denx.de" , "sjg@chromium.org" , "mr.nuke.me@gmail.com" , "jh80.chung@samsung.com" , "michal.simek@amd.com" , "marek.behun@nic.cz" , "pali@kernel.org" , "sr@denx.de" , "marex@denx.de" , "ricardo@foundries.io" , "Raghavendra, Vignesh" , "Anna, Suman" , Kishon Vijay Abraham , "J, KEERTHY" , "Yadav, Pratyush" References: <20220511060352.28140-1-vaishnav.a@ti.com> <20220511060352.28140-2-vaishnav.a@ti.com> From: Vaishnav Achath In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Heiko, On 11/05/22 13:54, Heiko Schocher wrote: > Hello Achath, > > On 11.05.22 08:03, Vaishnav Achath wrote: >> Currently the SPI flash to load from is defined through the compile >> time config CONFIG_SF_DEFAULT_BUS and CONFIG_SF_DEFAULT_CS, this >> prevents the loading of binaries from different SPI flash using the >> same build.E.g. supporting QSPI flash boot and OSPI flash boot >> on J721E platform is not possible due to this limitation. >> >> This commit adds lookup functions spl_spi_boot_bus() >> and spl_spi_boot_cs for identifying the flash device based on the >> selected boot device, when not overridden the lookup functions are >> weakly defined in common/spl/spl_spi.c. >> >> Signed-off-by: Vaishnav Achath >> --- > > you miss here change history. May you want to look into patman tool in > > u-boot:/tools/patman/README > > which can help you here much. > Noted, sorry I missed this, will wait for further feedback and include the change history in next revision, please let me know if a v3 with the change history alone fixed is required. >> common/spl/spl_spi.c | 16 +++++++++++++--- >> include/spl.h | 16 ++++++++++++++++ >> 2 files changed, 29 insertions(+), 3 deletions(-) > > Looks fine for me, thanks! > > Reviewed-by: Heiko Schocher > Thank you for the review. > bye, > Heiko -- Regards, Vaishnav