From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ECD8C4727C for ; Wed, 30 Sep 2020 16:11:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27DE620789 for ; Wed, 30 Sep 2020 16:11:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726992AbgI3QLt (ORCPT ); Wed, 30 Sep 2020 12:11:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725837AbgI3QLt (ORCPT ); Wed, 30 Sep 2020 12:11:49 -0400 Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01860C061755 for ; Wed, 30 Sep 2020 09:11:49 -0700 (PDT) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4C1h8g61xGz1rxw2; Wed, 30 Sep 2020 18:11:47 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4C1h8g4vpFz1sM9L; Wed, 30 Sep 2020 18:11:47 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 56pmXOe2X2gX; Wed, 30 Sep 2020 18:11:46 +0200 (CEST) X-Auth-Info: rRUJcTQM21weAAGtmD/E4ZF0w8ZgffbVRE3MKqlMlVo= Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 30 Sep 2020 18:11:46 +0200 (CEST) Subject: Re: [PATCH 04/11] soc: imx: gpcv2: wait for ADB400 handshake To: Lucas Stach , Shawn Guo , Rob Herring Cc: NXP Linux Team , Fabio Estevam , Frieder Schrempf , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, patchwork-lst@pengutronix.de References: <20200930155006.535712-1-l.stach@pengutronix.de> <20200930155006.535712-5-l.stach@pengutronix.de> From: Marek Vasut Message-ID: <818925c0-b45f-67b4-02a1-8db49ccc491e@denx.de> Date: Wed, 30 Sep 2020 18:11:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200930155006.535712-5-l.stach@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 9/30/20 5:49 PM, Lucas Stach wrote: [...] > @@ -176,9 +180,19 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) > GPC_PGC_CTRL_PCR, 0); > > /* request the ADB400 to power up */ > - if (domain->bits.hsk) > + if (domain->bits.hskreq) { > regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, > - domain->bits.hsk, domain->bits.hsk); > + domain->bits.hskreq, domain->bits.hskreq); > + > + ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PWRHSK, > + reg_val, > + (reg_val & domain->bits.hskack), > + 0, USEC_PER_MSEC); > + if (ret) { > + dev_err(domain->dev, "failed to power up ADB400\n"); The ADB400 is a bus bridge, so the bus is being attached here, not powered up, right ? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60351C4741F for ; Wed, 30 Sep 2020 16:13:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE791206F7 for ; Wed, 30 Sep 2020 16:13:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="beT9xs9y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE791206F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZIVjTDPujF1WkUS8md7OAkGE19kR2NehjkTgY1vD7+g=; b=beT9xs9yZYQnV3Bvn/DGjvtLt ut+bs/UF9Btyk5xJ3/+AALpcTTeA0p3BkP+n6gLc2eOElWippYLJKX4k4pwmkWVfbIT88kGmoMg4+ ckeExWW46lceVpDveOLBr8HDVVwhkLrkCB/jqFE5YyXoAdwysAK+FZDyvWg42vsEc1wsZdRyu3X5f ECPejfbcL7q6k4NMy+oQo3R3aURpAwjwfEDWvqcgf/X3M644Wfus+Iuf0BN6sTLP15W/8VxZAJxKK xOM6OsIfj0ydfU0cXXyBZzAGAwIFNooBzJgMagmMGoZINABuw69E703f+s21NQVeRfukM+hJWciqR kk8k2TWqQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNehz-0008Ef-9t; Wed, 30 Sep 2020 16:11:59 +0000 Received: from mail-out.m-online.net ([2001:a60:0:28:0:1:25:1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNehp-0008BR-TA for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2020 16:11:50 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4C1h8g61xGz1rxw2; Wed, 30 Sep 2020 18:11:47 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4C1h8g4vpFz1sM9L; Wed, 30 Sep 2020 18:11:47 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 56pmXOe2X2gX; Wed, 30 Sep 2020 18:11:46 +0200 (CEST) X-Auth-Info: rRUJcTQM21weAAGtmD/E4ZF0w8ZgffbVRE3MKqlMlVo= Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 30 Sep 2020 18:11:46 +0200 (CEST) Subject: Re: [PATCH 04/11] soc: imx: gpcv2: wait for ADB400 handshake To: Lucas Stach , Shawn Guo , Rob Herring References: <20200930155006.535712-1-l.stach@pengutronix.de> <20200930155006.535712-5-l.stach@pengutronix.de> From: Marek Vasut Message-ID: <818925c0-b45f-67b4-02a1-8db49ccc491e@denx.de> Date: Wed, 30 Sep 2020 18:11:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200930155006.535712-5-l.stach@pengutronix.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200930_121150_051765_722C36E4 X-CRM114-Status: GOOD ( 14.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Frieder Schrempf , patchwork-lst@pengutronix.de, NXP Linux Team , kernel@pengutronix.de, Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/30/20 5:49 PM, Lucas Stach wrote: [...] > @@ -176,9 +180,19 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) > GPC_PGC_CTRL_PCR, 0); > > /* request the ADB400 to power up */ > - if (domain->bits.hsk) > + if (domain->bits.hskreq) { > regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, > - domain->bits.hsk, domain->bits.hsk); > + domain->bits.hskreq, domain->bits.hskreq); > + > + ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PWRHSK, > + reg_val, > + (reg_val & domain->bits.hskack), > + 0, USEC_PER_MSEC); > + if (ret) { > + dev_err(domain->dev, "failed to power up ADB400\n"); The ADB400 is a bus bridge, so the bus is being attached here, not powered up, right ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel