From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97713C3F2C6 for ; Wed, 11 Mar 2020 13:30:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7058A21655 for ; Wed, 11 Mar 2020 13:30:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="eFHlFzdQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729556AbgCKNaq (ORCPT ); Wed, 11 Mar 2020 09:30:46 -0400 Received: from mo4-p02-ob.smtp.rzone.de ([85.215.255.81]:8299 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729552AbgCKNap (ORCPT ); Wed, 11 Mar 2020 09:30:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1583933442; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=GdjmaOpO8Y3WU4rFoDIjKcLngUYzQxklDSD8RGkNqKM=; b=eFHlFzdQt3jZW7BzBb+EitGOR1sZWjUdS8wvw7ja4b3UxF0LmmMh+RN3mIVJ8DPMWo BpkjIHfQN61plZgvIA6BtZF3EgOl8TJW3benyJPYX6TwphR3hILSHdsSjX5UQ/2cCJcp scn7ebPyMf5fvC/L8vDL06DiBgi6G0nH9IaZdgB5YahzhrTbxPej9hueW+64aeB2E/Ox F8mU3QhFj7V7gqBM8PzAB45oqA5ngD0+dK9TV0lshZ9q22X/gxD08aj/vl+bifktdcWU L3nX3wjnY1qgdEpnH4sF+rZ5DcVKbjkwovuCPxuwicL6qnlztv5SfxLoA8JiBhLMZhTD BSxA== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw9iZeHmMnw43lIA8=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 46.2.0 DYNA|AUTH) with ESMTPSA id y0a02cw2BDURyeO (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 11 Mar 2020 14:30:27 +0100 (CET) Subject: Re: [RFC v2 6/8] MIPS: DTS: jz4780: account for Synopsys HDMI driver and LCD controller Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=iso-8859-1 From: "H. Nikolaus Schaller" In-Reply-To: <1583932809.3.0@crapouillou.net> Date: Wed, 11 Mar 2020 14:30:26 +0100 Cc: Paul Boddie , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , Linus Walleij , Andi Kleen , Krzysztof Kozlowski , Geert Uytterhoeven , "Eric W. Biederman" , Miquel Raynal , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , linux-mips@vger.kernel.org, "open list:GPIO SUBSYSTEM" , Discussions about the Letux Kernel , MIPS Creator CI20 Development Content-Transfer-Encoding: quoted-printable Message-Id: <81CAD3B7-0467-4F67-B379-76795B147497@goldelico.com> References: <04b485165f38744816a0446e95150cafdeb716ee.1582913973.git.hns@goldelico.com> <1583177253.3.5@crapouillou.net> <1583932809.3.0@crapouillou.net> To: Paul Cercueil X-Mailer: Apple Mail (2.3124) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Paul, > Am 11.03.2020 um 14:20 schrieb Paul Cercueil : >=20 > Hi Nikolaus, >=20 >=20 > Le mer., mars 11, 2020 at 13:43, H. Nikolaus Schaller = a =E9crit : >> Hi Paul, >>> The JZ4780's LCD controller is much newer than the JZ4740 one, so = even if it works with the "ingenic,jz4740-lcd" compatible string, you = want it as a fallback. >>> So this should be: compatible =3D "ingenic,jz4780-lcd", = "ingenic,jz4740-lcd". >>> That means the YAML should be updated too. >> I have started to look into jz4780 HDMI setup again. >> Well, there is no driver compatible to "ingenic,jz4780-lcd" so far >> and it is questionalbe if we need a different one. >> I think we should rather make the driver also compatible >> than adding a fallback to ingenic,jz4740-lcdto the DTS. >> The reason why this is better even if both LCDC are almost >> compatible is that the jz4780 allows for much bigger displays >> and therefore should have its own jz_soc_info with 4k x 2k >> as maximum. >=20 > Sure, feel free to extend the driver. >=20 >> Next I tried to find out if the LCDC are really compatible. >> Well the jz4780 has two lcdc instances but they are separated >> by the reg addr. Next, there are unique features (like picture in >> picture with alpha blending) but those are probably disabled >> if not programmed from reset state. This may become a reason >> to separate or augment the driver for the jz4780 but at the >> moment we can ignore that. >=20 > Two LCDC instances -> two lcd-controller@... nodes. It's that simple. Indeed :) >=20 > The other features you listed are outside the LCDC, so outside the = scope of this driver. Well, in the description they are mixed but I think we do not have to care about now. >=20 >> There are also subtly different bit definitions and register >> widths (e.g. 24 bit in addition to 16/18 bit modes or more bits >> for the sync position) but it looks as if the ingenic_drm >> driver already handles this. >> Then I tried to read back the registers. Strangely they >> are all 0x00000000. So there is no programming of the >> lcd-controller in our DT setup with HDMI at all! >=20 > How did you read them? I used devmem2 (may be an omap tool I have recompiled for MIPS - it uses = /dev/mem). > Do it from the regmap: should be "cat = /sys/kernel/debug/regmap/13050000.lcd-controller/registers" (not sure = about the path) Well seems to give the same result: root@letux:~# cat = /sys/kernel/debug/regmap/13050000.lcd-controller/registers 00: 00000000 04: 00000000 08: 00000000 0c: 00000000 10: 00000000 14: 00000000 18: 00000000 1c: 00000000 20: 00000000 24: 00000000 28: 00000000 2c: 00000000 30: 00000000 34: 00000000 38: 00000000 3c: 00000000 40: 00000000 44: 00000000 48: 00000000 4c: 00000000 50: 00000000 54: 00000000 58: 00000000 5c: 00000000 root@letux:~#=20 >=20 >> I also checked that ingenic_drm_probe() is called and >> returns successfully 0. It also reports that a /dev/fb >> has been created: >> [ 7.908830] ingenic-drm 13050000.lcd-controller: fb0: = ingenic-drmdrmf frame buffer device >> But for example ingenic_drm_encoder_atomic_mode_set() is >> never called which should write some registers of the LCDC. >> I only did see some calls to ingenic_drm_encoder_atomic_check(). >> This of course explains why we have no HDMI signals despite >> proper HPD and a /dev/fb0. Because the LCDC is not being >> programmed. >=20 > It won't be called until the HDMI driver says that the cable is = plugged, and there's a client application (e.g. fbdev emulation) = running. So the problem is most likely within the HDMI driver. Ok! The HDMI subsystem says (with some printk inserted) on cable = unplug/replug: root@letux:~# [ 3894.370706] dw_hdmi_update_power [ 3894.373984] dw_hdmi_update_power: hdmi->force=3D0 [ 3894.378759] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3894.383756] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.388947] dw_hdmi_update_power: hdmi->rxsense=3D1 [ 3894.393831] dw_hdmi_update_power: force=3D2 [ 3894.397895] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.403200] dw_hdmi_phy_update_hpd [ 3894.406784] dw_hdmi_update_power [ 3894.410054] dw_hdmi_update_power: hdmi->force=3D0 [ 3894.414766] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3894.419611] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.424928] dw_hdmi_update_power: hdmi->rxsense=3D1 [ 3894.429699] dw_hdmi_update_power: force=3D2 [ 3894.433876] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.439068] dw_hdmi_phy_update_hpd [ 3894.452316] dw_hdmi_update_power [ 3894.455596] dw_hdmi_update_power: hdmi->force=3D0 [ 3894.460150] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3894.464967] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.470131] dw_hdmi_update_power: hdmi->rxsense=3D1 [ 3894.475051] dw_hdmi_update_power: force=3D2 [ 3894.479111] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.484423] dw_hdmi_phy_update_hpd [ 3894.488007] dw_hdmi_update_power [ 3894.491278] dw_hdmi_update_power: hdmi->force=3D0 [ 3894.495982] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3894.500823] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.506139] dw_hdmi_update_power: hdmi->rxsense=3D0 [ 3894.510895] dw_hdmi_update_power: force=3D1 [ 3894.515063] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.520252] dw_hdmi_poweroff [ 3894.523284] dw_hdmi_phy_disable [ 3894.526480] dw_hdmi_phy_power_off [ 3894.529823] dw_hdmi_phy_gen2_txpwron [ 3894.533567] dw-hdmi-jz4780 10180000.hdmi: PHY powered down in 0 = iterations [ 3894.540496] dw_hdmi_phy_gen2_pddq [ 3894.543966] dw_hdmi_phy_update_hpd [ 3894.547435] dw-hdmi-jz4780 10180000.hdmi: EVENT=3Dplugout [ 3897.079560] dw_hdmi_update_power [ 3897.082840] dw_hdmi_update_power: hdmi->force=3D0 [ 3897.087394] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3897.092207] dw_hdmi_update_power: hdmi->bridge_is_on=3D0 [ 3897.097370] dw_hdmi_update_power: hdmi->rxsense=3D1 [ 3897.102316] dw_hdmi_update_power: force=3D2 [ 3897.106380] dw_hdmi_update_power: hdmi->bridge_is_on=3D0 [ 3897.111667] dw_hdmi_poweron [ 3897.114518] dw_hdmi_setup [ 3897.117163] hdmi_disable_overflow_interrupts [ 3897.121478] dw-hdmi-jz4780 10180000.hdmi: Non-CEA mode used in HDMI [ 3897.127930] hdmi_av_composer [ 3897.130848] dw-hdmi-jz4780 10180000.hdmi: final pixclk =3D 0 [ 3897.136506] dw_hdmi_phy_init [ 3897.139440] dw_hdmi_phy_sel_data_en_pol [ 3897.143428] dw_hdmi_phy_sel_interface_control [ 3897.147840] hdmi_phy_configure [ 3897.150922] dw_hdmi_phy_power_off [ 3897.154415] dw_hdmi_phy_gen2_txpwron [ 3897.158043] dw-hdmi-jz4780 10180000.hdmi: PHY powered down in 0 = iterations [ 3897.165094] dw_hdmi_phy_gen2_pddq [ 3897.168468] dw_hdmi_set_high_tmds_clock_ratio [ 3897.173002] hdmi_phy_configure_dwc_hdmi_3d_tx [ 3897.186578] dw_hdmi_phy_power_on [ 3897.189847] dw_hdmi_phy_gen2_txpwron [ 3897.193586] dw_hdmi_phy_gen2_pddq [ 3897.217640] dw-hdmi-jz4780 10180000.hdmi: PHY PLL locked 1 iterations [ 3897.224226] dw_hdmi_phy_sel_data_en_pol [ 3897.228107] dw_hdmi_phy_sel_interface_control [ 3897.232631] hdmi_phy_configure [ 3897.235739] dw_hdmi_phy_power_off [ 3897.239082] dw_hdmi_phy_gen2_txpwron [ 3897.242826] dw-hdmi-jz4780 10180000.hdmi: PHY powered down in 0 = iterations [ 3897.249754] dw_hdmi_phy_gen2_pddq [ 3897.253239] dw_hdmi_set_high_tmds_clock_ratio [ 3897.257658] hdmi_phy_configure_dwc_hdmi_3d_tx [ 3897.271264] dw_hdmi_phy_power_on [ 3897.274659] dw_hdmi_phy_gen2_txpwron [ 3897.278292] dw_hdmi_phy_gen2_pddq [ 3897.283840] dw-hdmi-jz4780 10180000.hdmi: PHY PLL locked 1 iterations [ 3897.290346] dw_hdmi_enable_video_path [ 3897.294240] dw-hdmi-jz4780 10180000.hdmi: sink has audio support [ 3897.300324] dw-hdmi-jz4780 10180000.hdmi: dw_hdmi_setup HDMI mode [ 3897.306596] hdmi_config_AVI [ 3897.309467] hdmi_config_vendor_specific_infoframe [ 3897.314336] hdmi_config_drm_infoframe [ 3897.318096] hdmi_tx_hdcp_config [ 3897.321270] dw_hdmi_clear_overflow [ 3897.324831] dw_hdmi_phy_update_hpd [ 3897.328298] dw-hdmi-jz4780 10180000.hdmi: EVENT=3Dplugin [ 3897.333704] dw_hdmi_update_power [ 3897.336990] dw_hdmi_update_power: hdmi->force=3D0 [ 3897.341551] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3897.346528] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3897.351858] dw_hdmi_update_power: hdmi->rxsense=3D1 [ 3897.356615] dw_hdmi_update_power: force=3D2 [ 3897.360655] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3897.365980] dw_hdmi_phy_update_hpd So the plugout/plugin events are not processed further. One thing looks strange: [ 3897.127930] hdmi_av_composer [ 3897.130848] dw-hdmi-jz4780 10180000.hdmi: final pixclk =3D 0 But I have no idea if this is the reason or the consequence of the uninitialized lcdc. So we need some DRM specialist to take a look on it. BR and thanks, Nikolaus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RDNS_NONE,SPF_HELO_PASS,SPF_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mo4-p02-ob.smtp.rzone.de ([85.215.255.81]:8299 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729552AbgCKNap (ORCPT ); Wed, 11 Mar 2020 09:30:45 -0400 Subject: Re: [RFC v2 6/8] MIPS: DTS: jz4780: account for Synopsys HDMI driver and LCD controller Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=iso-8859-1 From: "H. Nikolaus Schaller" In-Reply-To: <1583932809.3.0@crapouillou.net> Date: Wed, 11 Mar 2020 14:30:26 +0100 Cc: Paul Boddie , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , Linus Walleij , Andi Kleen , Krzysztof Kozlowski , Geert Uytterhoeven , "Eric W. Biederman" , Miquel Raynal , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , linux-mips@vger.kernel.org, "open list:GPIO SUBSYSTEM" , Discussions about the Letux Kernel , MIPS Creator CI20 Development Content-Transfer-Encoding: quoted-printable Message-Id: <81CAD3B7-0467-4F67-B379-76795B147497@goldelico.com> References: <04b485165f38744816a0446e95150cafdeb716ee.1582913973.git.hns@goldelico.com> <1583177253.3.5@crapouillou.net> <1583932809.3.0@crapouillou.net> To: Paul Cercueil Sender: linux-kernel-owner@vger.kernel.org List-ID: Message-ID: <20200311133026.4kJRz1JZDwOzwBlMH3Z8x_s84iG-aebc11-5z-QN_Fs@z> Hi Paul, > Am 11.03.2020 um 14:20 schrieb Paul Cercueil : >=20 > Hi Nikolaus, >=20 >=20 > Le mer., mars 11, 2020 at 13:43, H. Nikolaus Schaller = a =E9crit : >> Hi Paul, >>> The JZ4780's LCD controller is much newer than the JZ4740 one, so = even if it works with the "ingenic,jz4740-lcd" compatible string, you = want it as a fallback. >>> So this should be: compatible =3D "ingenic,jz4780-lcd", = "ingenic,jz4740-lcd". >>> That means the YAML should be updated too. >> I have started to look into jz4780 HDMI setup again. >> Well, there is no driver compatible to "ingenic,jz4780-lcd" so far >> and it is questionalbe if we need a different one. >> I think we should rather make the driver also compatible >> than adding a fallback to ingenic,jz4740-lcdto the DTS. >> The reason why this is better even if both LCDC are almost >> compatible is that the jz4780 allows for much bigger displays >> and therefore should have its own jz_soc_info with 4k x 2k >> as maximum. >=20 > Sure, feel free to extend the driver. >=20 >> Next I tried to find out if the LCDC are really compatible. >> Well the jz4780 has two lcdc instances but they are separated >> by the reg addr. Next, there are unique features (like picture in >> picture with alpha blending) but those are probably disabled >> if not programmed from reset state. This may become a reason >> to separate or augment the driver for the jz4780 but at the >> moment we can ignore that. >=20 > Two LCDC instances -> two lcd-controller@... nodes. It's that simple. Indeed :) >=20 > The other features you listed are outside the LCDC, so outside the = scope of this driver. Well, in the description they are mixed but I think we do not have to care about now. >=20 >> There are also subtly different bit definitions and register >> widths (e.g. 24 bit in addition to 16/18 bit modes or more bits >> for the sync position) but it looks as if the ingenic_drm >> driver already handles this. >> Then I tried to read back the registers. Strangely they >> are all 0x00000000. So there is no programming of the >> lcd-controller in our DT setup with HDMI at all! >=20 > How did you read them? I used devmem2 (may be an omap tool I have recompiled for MIPS - it uses = /dev/mem). > Do it from the regmap: should be "cat = /sys/kernel/debug/regmap/13050000.lcd-controller/registers" (not sure = about the path) Well seems to give the same result: root@letux:~# cat = /sys/kernel/debug/regmap/13050000.lcd-controller/registers 00: 00000000 04: 00000000 08: 00000000 0c: 00000000 10: 00000000 14: 00000000 18: 00000000 1c: 00000000 20: 00000000 24: 00000000 28: 00000000 2c: 00000000 30: 00000000 34: 00000000 38: 00000000 3c: 00000000 40: 00000000 44: 00000000 48: 00000000 4c: 00000000 50: 00000000 54: 00000000 58: 00000000 5c: 00000000 root@letux:~#=20 >=20 >> I also checked that ingenic_drm_probe() is called and >> returns successfully 0. It also reports that a /dev/fb >> has been created: >> [ 7.908830] ingenic-drm 13050000.lcd-controller: fb0: = ingenic-drmdrmf frame buffer device >> But for example ingenic_drm_encoder_atomic_mode_set() is >> never called which should write some registers of the LCDC. >> I only did see some calls to ingenic_drm_encoder_atomic_check(). >> This of course explains why we have no HDMI signals despite >> proper HPD and a /dev/fb0. Because the LCDC is not being >> programmed. >=20 > It won't be called until the HDMI driver says that the cable is = plugged, and there's a client application (e.g. fbdev emulation) = running. So the problem is most likely within the HDMI driver. Ok! The HDMI subsystem says (with some printk inserted) on cable = unplug/replug: root@letux:~# [ 3894.370706] dw_hdmi_update_power [ 3894.373984] dw_hdmi_update_power: hdmi->force=3D0 [ 3894.378759] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3894.383756] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.388947] dw_hdmi_update_power: hdmi->rxsense=3D1 [ 3894.393831] dw_hdmi_update_power: force=3D2 [ 3894.397895] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.403200] dw_hdmi_phy_update_hpd [ 3894.406784] dw_hdmi_update_power [ 3894.410054] dw_hdmi_update_power: hdmi->force=3D0 [ 3894.414766] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3894.419611] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.424928] dw_hdmi_update_power: hdmi->rxsense=3D1 [ 3894.429699] dw_hdmi_update_power: force=3D2 [ 3894.433876] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.439068] dw_hdmi_phy_update_hpd [ 3894.452316] dw_hdmi_update_power [ 3894.455596] dw_hdmi_update_power: hdmi->force=3D0 [ 3894.460150] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3894.464967] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.470131] dw_hdmi_update_power: hdmi->rxsense=3D1 [ 3894.475051] dw_hdmi_update_power: force=3D2 [ 3894.479111] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.484423] dw_hdmi_phy_update_hpd [ 3894.488007] dw_hdmi_update_power [ 3894.491278] dw_hdmi_update_power: hdmi->force=3D0 [ 3894.495982] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3894.500823] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.506139] dw_hdmi_update_power: hdmi->rxsense=3D0 [ 3894.510895] dw_hdmi_update_power: force=3D1 [ 3894.515063] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.520252] dw_hdmi_poweroff [ 3894.523284] dw_hdmi_phy_disable [ 3894.526480] dw_hdmi_phy_power_off [ 3894.529823] dw_hdmi_phy_gen2_txpwron [ 3894.533567] dw-hdmi-jz4780 10180000.hdmi: PHY powered down in 0 = iterations [ 3894.540496] dw_hdmi_phy_gen2_pddq [ 3894.543966] dw_hdmi_phy_update_hpd [ 3894.547435] dw-hdmi-jz4780 10180000.hdmi: EVENT=3Dplugout [ 3897.079560] dw_hdmi_update_power [ 3897.082840] dw_hdmi_update_power: hdmi->force=3D0 [ 3897.087394] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3897.092207] dw_hdmi_update_power: hdmi->bridge_is_on=3D0 [ 3897.097370] dw_hdmi_update_power: hdmi->rxsense=3D1 [ 3897.102316] dw_hdmi_update_power: force=3D2 [ 3897.106380] dw_hdmi_update_power: hdmi->bridge_is_on=3D0 [ 3897.111667] dw_hdmi_poweron [ 3897.114518] dw_hdmi_setup [ 3897.117163] hdmi_disable_overflow_interrupts [ 3897.121478] dw-hdmi-jz4780 10180000.hdmi: Non-CEA mode used in HDMI [ 3897.127930] hdmi_av_composer [ 3897.130848] dw-hdmi-jz4780 10180000.hdmi: final pixclk =3D 0 [ 3897.136506] dw_hdmi_phy_init [ 3897.139440] dw_hdmi_phy_sel_data_en_pol [ 3897.143428] dw_hdmi_phy_sel_interface_control [ 3897.147840] hdmi_phy_configure [ 3897.150922] dw_hdmi_phy_power_off [ 3897.154415] dw_hdmi_phy_gen2_txpwron [ 3897.158043] dw-hdmi-jz4780 10180000.hdmi: PHY powered down in 0 = iterations [ 3897.165094] dw_hdmi_phy_gen2_pddq [ 3897.168468] dw_hdmi_set_high_tmds_clock_ratio [ 3897.173002] hdmi_phy_configure_dwc_hdmi_3d_tx [ 3897.186578] dw_hdmi_phy_power_on [ 3897.189847] dw_hdmi_phy_gen2_txpwron [ 3897.193586] dw_hdmi_phy_gen2_pddq [ 3897.217640] dw-hdmi-jz4780 10180000.hdmi: PHY PLL locked 1 iterations [ 3897.224226] dw_hdmi_phy_sel_data_en_pol [ 3897.228107] dw_hdmi_phy_sel_interface_control [ 3897.232631] hdmi_phy_configure [ 3897.235739] dw_hdmi_phy_power_off [ 3897.239082] dw_hdmi_phy_gen2_txpwron [ 3897.242826] dw-hdmi-jz4780 10180000.hdmi: PHY powered down in 0 = iterations [ 3897.249754] dw_hdmi_phy_gen2_pddq [ 3897.253239] dw_hdmi_set_high_tmds_clock_ratio [ 3897.257658] hdmi_phy_configure_dwc_hdmi_3d_tx [ 3897.271264] dw_hdmi_phy_power_on [ 3897.274659] dw_hdmi_phy_gen2_txpwron [ 3897.278292] dw_hdmi_phy_gen2_pddq [ 3897.283840] dw-hdmi-jz4780 10180000.hdmi: PHY PLL locked 1 iterations [ 3897.290346] dw_hdmi_enable_video_path [ 3897.294240] dw-hdmi-jz4780 10180000.hdmi: sink has audio support [ 3897.300324] dw-hdmi-jz4780 10180000.hdmi: dw_hdmi_setup HDMI mode [ 3897.306596] hdmi_config_AVI [ 3897.309467] hdmi_config_vendor_specific_infoframe [ 3897.314336] hdmi_config_drm_infoframe [ 3897.318096] hdmi_tx_hdcp_config [ 3897.321270] dw_hdmi_clear_overflow [ 3897.324831] dw_hdmi_phy_update_hpd [ 3897.328298] dw-hdmi-jz4780 10180000.hdmi: EVENT=3Dplugin [ 3897.333704] dw_hdmi_update_power [ 3897.336990] dw_hdmi_update_power: hdmi->force=3D0 [ 3897.341551] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3897.346528] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3897.351858] dw_hdmi_update_power: hdmi->rxsense=3D1 [ 3897.356615] dw_hdmi_update_power: force=3D2 [ 3897.360655] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3897.365980] dw_hdmi_phy_update_hpd So the plugout/plugin events are not processed further. One thing looks strange: [ 3897.127930] hdmi_av_composer [ 3897.130848] dw-hdmi-jz4780 10180000.hdmi: final pixclk =3D 0 But I have no idea if this is the reason or the consequence of the uninitialized lcdc. So we need some DRM specialist to take a look on it. BR and thanks, Nikolaus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 576C4C2BB1D for ; Thu, 12 Mar 2020 08:09:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6B3320650 for ; Thu, 12 Mar 2020 08:09:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="jzAma20A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6B3320650 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goldelico.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CD8ED6EA83; Thu, 12 Mar 2020 08:08:52 +0000 (UTC) Received: from mo6-p02-ob.smtp.rzone.de (mo6-p02-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5302::12]) by gabe.freedesktop.org (Postfix) with ESMTPS id C88BD6E97B for ; Wed, 11 Mar 2020 13:30:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1583933446; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=GdjmaOpO8Y3WU4rFoDIjKcLngUYzQxklDSD8RGkNqKM=; b=jzAma20AklWyfw8PSGvm4ZVzEbVnDcTRqBdor6CJOslr1gjFzI3M7BgLnAwR74djAv i1pILqPxfkRbORrI556CwzE0bV1lvr2i8+GJQOGK8kVlvugBavi5uFgtXtKyYCVB7vOH ue/bvBvDQp5I3v0GTwusZ9qcyYX/FGnN5gDbLuWzH5x4cGyobNNxEWLgIVm2SHG47tPs D6PdgaxL0kyBwAm7TZQTV2MLTSjPIQx87bD7cq8VJKTFjR6nJ1BGim8CW2eXy0XOxA/F 9CFOlxXJWrXwQ8WqyNYYsjx+8aWXx3Lm7HTFShyBQ0N3XPmQEysAaEFlgc4v3fW3EetV aewg== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw9iZeHmMnw43lIA8=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 46.2.0 DYNA|AUTH) with ESMTPSA id y0a02cw2BDURyeO (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 11 Mar 2020 14:30:27 +0100 (CET) Subject: Re: [RFC v2 6/8] MIPS: DTS: jz4780: account for Synopsys HDMI driver and LCD controller Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: "H. Nikolaus Schaller" In-Reply-To: <1583932809.3.0@crapouillou.net> Date: Wed, 11 Mar 2020 14:30:26 +0100 Message-Id: <81CAD3B7-0467-4F67-B379-76795B147497@goldelico.com> References: <04b485165f38744816a0446e95150cafdeb716ee.1582913973.git.hns@goldelico.com> <1583177253.3.5@crapouillou.net> <1583932809.3.0@crapouillou.net> To: Paul Cercueil X-Mailer: Apple Mail (2.3124) X-Mailman-Approved-At: Thu, 12 Mar 2020 08:08:13 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Paul Boddie , Geert Uytterhoeven , Paul Burton , "open list:GPIO SUBSYSTEM" , David Airlie , MIPS Creator CI20 Development , "open list:DRM PANEL DRIVERS" , Linux Kernel Mailing List , Ralf Baechle , linux-mips@vger.kernel.org, Andi Kleen , Rob Herring , Krzysztof Kozlowski , Miquel Raynal , Discussions about the Letux Kernel , "Eric W. Biederman" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Paul, > Am 11.03.2020 um 14:20 schrieb Paul Cercueil : > = > Hi Nikolaus, > = > = > Le mer., mars 11, 2020 at 13:43, H. Nikolaus Schaller = a =E9crit : >> Hi Paul, >>> The JZ4780's LCD controller is much newer than the JZ4740 one, so even = if it works with the "ingenic,jz4740-lcd" compatible string, you want it as= a fallback. >>> So this should be: compatible =3D "ingenic,jz4780-lcd", "ingenic,jz4740= -lcd". >>> That means the YAML should be updated too. >> I have started to look into jz4780 HDMI setup again. >> Well, there is no driver compatible to "ingenic,jz4780-lcd" so far >> and it is questionalbe if we need a different one. >> I think we should rather make the driver also compatible >> than adding a fallback to ingenic,jz4740-lcdto the DTS. >> The reason why this is better even if both LCDC are almost >> compatible is that the jz4780 allows for much bigger displays >> and therefore should have its own jz_soc_info with 4k x 2k >> as maximum. > = > Sure, feel free to extend the driver. > = >> Next I tried to find out if the LCDC are really compatible. >> Well the jz4780 has two lcdc instances but they are separated >> by the reg addr. Next, there are unique features (like picture in >> picture with alpha blending) but those are probably disabled >> if not programmed from reset state. This may become a reason >> to separate or augment the driver for the jz4780 but at the >> moment we can ignore that. > = > Two LCDC instances -> two lcd-controller@... nodes. It's that simple. Indeed :) > = > The other features you listed are outside the LCDC, so outside the scope = of this driver. Well, in the description they are mixed but I think we do not have to care about now. > = >> There are also subtly different bit definitions and register >> widths (e.g. 24 bit in addition to 16/18 bit modes or more bits >> for the sync position) but it looks as if the ingenic_drm >> driver already handles this. >> Then I tried to read back the registers. Strangely they >> are all 0x00000000. So there is no programming of the >> lcd-controller in our DT setup with HDMI at all! > = > How did you read them? I used devmem2 (may be an omap tool I have recompiled for MIPS - it uses /d= ev/mem). > Do it from the regmap: should be "cat /sys/kernel/debug/regmap/13050000.l= cd-controller/registers" (not sure about the path) Well seems to give the same result: root@letux:~# cat /sys/kernel/debug/regmap/13050000.lcd-controller/registers 00: 00000000 04: 00000000 08: 00000000 0c: 00000000 10: 00000000 14: 00000000 18: 00000000 1c: 00000000 20: 00000000 24: 00000000 28: 00000000 2c: 00000000 30: 00000000 34: 00000000 38: 00000000 3c: 00000000 40: 00000000 44: 00000000 48: 00000000 4c: 00000000 50: 00000000 54: 00000000 58: 00000000 5c: 00000000 root@letux:~# = > = >> I also checked that ingenic_drm_probe() is called and >> returns successfully 0. It also reports that a /dev/fb >> has been created: >> [ 7.908830] ingenic-drm 13050000.lcd-controller: fb0: ingenic-drmdrmf= frame buffer device >> But for example ingenic_drm_encoder_atomic_mode_set() is >> never called which should write some registers of the LCDC. >> I only did see some calls to ingenic_drm_encoder_atomic_check(). >> This of course explains why we have no HDMI signals despite >> proper HPD and a /dev/fb0. Because the LCDC is not being >> programmed. > = > It won't be called until the HDMI driver says that the cable is plugged, = and there's a client application (e.g. fbdev emulation) running. So the pro= blem is most likely within the HDMI driver. Ok! The HDMI subsystem says (with some printk inserted) on cable unplug/replug: root@letux:~# [ 3894.370706] dw_hdmi_update_power [ 3894.373984] dw_hdmi_update_power: hdmi->force=3D0 [ 3894.378759] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3894.383756] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.388947] dw_hdmi_update_power: hdmi->rxsense=3D1 [ 3894.393831] dw_hdmi_update_power: force=3D2 [ 3894.397895] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.403200] dw_hdmi_phy_update_hpd [ 3894.406784] dw_hdmi_update_power [ 3894.410054] dw_hdmi_update_power: hdmi->force=3D0 [ 3894.414766] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3894.419611] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.424928] dw_hdmi_update_power: hdmi->rxsense=3D1 [ 3894.429699] dw_hdmi_update_power: force=3D2 [ 3894.433876] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.439068] dw_hdmi_phy_update_hpd [ 3894.452316] dw_hdmi_update_power [ 3894.455596] dw_hdmi_update_power: hdmi->force=3D0 [ 3894.460150] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3894.464967] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.470131] dw_hdmi_update_power: hdmi->rxsense=3D1 [ 3894.475051] dw_hdmi_update_power: force=3D2 [ 3894.479111] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.484423] dw_hdmi_phy_update_hpd [ 3894.488007] dw_hdmi_update_power [ 3894.491278] dw_hdmi_update_power: hdmi->force=3D0 [ 3894.495982] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3894.500823] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.506139] dw_hdmi_update_power: hdmi->rxsense=3D0 [ 3894.510895] dw_hdmi_update_power: force=3D1 [ 3894.515063] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3894.520252] dw_hdmi_poweroff [ 3894.523284] dw_hdmi_phy_disable [ 3894.526480] dw_hdmi_phy_power_off [ 3894.529823] dw_hdmi_phy_gen2_txpwron [ 3894.533567] dw-hdmi-jz4780 10180000.hdmi: PHY powered down in 0 iteratio= ns [ 3894.540496] dw_hdmi_phy_gen2_pddq [ 3894.543966] dw_hdmi_phy_update_hpd [ 3894.547435] dw-hdmi-jz4780 10180000.hdmi: EVENT=3Dplugout [ 3897.079560] dw_hdmi_update_power [ 3897.082840] dw_hdmi_update_power: hdmi->force=3D0 [ 3897.087394] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3897.092207] dw_hdmi_update_power: hdmi->bridge_is_on=3D0 [ 3897.097370] dw_hdmi_update_power: hdmi->rxsense=3D1 [ 3897.102316] dw_hdmi_update_power: force=3D2 [ 3897.106380] dw_hdmi_update_power: hdmi->bridge_is_on=3D0 [ 3897.111667] dw_hdmi_poweron [ 3897.114518] dw_hdmi_setup [ 3897.117163] hdmi_disable_overflow_interrupts [ 3897.121478] dw-hdmi-jz4780 10180000.hdmi: Non-CEA mode used in HDMI [ 3897.127930] hdmi_av_composer [ 3897.130848] dw-hdmi-jz4780 10180000.hdmi: final pixclk =3D 0 [ 3897.136506] dw_hdmi_phy_init [ 3897.139440] dw_hdmi_phy_sel_data_en_pol [ 3897.143428] dw_hdmi_phy_sel_interface_control [ 3897.147840] hdmi_phy_configure [ 3897.150922] dw_hdmi_phy_power_off [ 3897.154415] dw_hdmi_phy_gen2_txpwron [ 3897.158043] dw-hdmi-jz4780 10180000.hdmi: PHY powered down in 0 iteratio= ns [ 3897.165094] dw_hdmi_phy_gen2_pddq [ 3897.168468] dw_hdmi_set_high_tmds_clock_ratio [ 3897.173002] hdmi_phy_configure_dwc_hdmi_3d_tx [ 3897.186578] dw_hdmi_phy_power_on [ 3897.189847] dw_hdmi_phy_gen2_txpwron [ 3897.193586] dw_hdmi_phy_gen2_pddq [ 3897.217640] dw-hdmi-jz4780 10180000.hdmi: PHY PLL locked 1 iterations [ 3897.224226] dw_hdmi_phy_sel_data_en_pol [ 3897.228107] dw_hdmi_phy_sel_interface_control [ 3897.232631] hdmi_phy_configure [ 3897.235739] dw_hdmi_phy_power_off [ 3897.239082] dw_hdmi_phy_gen2_txpwron [ 3897.242826] dw-hdmi-jz4780 10180000.hdmi: PHY powered down in 0 iteratio= ns [ 3897.249754] dw_hdmi_phy_gen2_pddq [ 3897.253239] dw_hdmi_set_high_tmds_clock_ratio [ 3897.257658] hdmi_phy_configure_dwc_hdmi_3d_tx [ 3897.271264] dw_hdmi_phy_power_on [ 3897.274659] dw_hdmi_phy_gen2_txpwron [ 3897.278292] dw_hdmi_phy_gen2_pddq [ 3897.283840] dw-hdmi-jz4780 10180000.hdmi: PHY PLL locked 1 iterations [ 3897.290346] dw_hdmi_enable_video_path [ 3897.294240] dw-hdmi-jz4780 10180000.hdmi: sink has audio support [ 3897.300324] dw-hdmi-jz4780 10180000.hdmi: dw_hdmi_setup HDMI mode [ 3897.306596] hdmi_config_AVI [ 3897.309467] hdmi_config_vendor_specific_infoframe [ 3897.314336] hdmi_config_drm_infoframe [ 3897.318096] hdmi_tx_hdcp_config [ 3897.321270] dw_hdmi_clear_overflow [ 3897.324831] dw_hdmi_phy_update_hpd [ 3897.328298] dw-hdmi-jz4780 10180000.hdmi: EVENT=3Dplugin [ 3897.333704] dw_hdmi_update_power [ 3897.336990] dw_hdmi_update_power: hdmi->force=3D0 [ 3897.341551] dw_hdmi_update_power: hdmi->disabled=3D0 [ 3897.346528] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3897.351858] dw_hdmi_update_power: hdmi->rxsense=3D1 [ 3897.356615] dw_hdmi_update_power: force=3D2 [ 3897.360655] dw_hdmi_update_power: hdmi->bridge_is_on=3D1 [ 3897.365980] dw_hdmi_phy_update_hpd So the plugout/plugin events are not processed further. One thing looks strange: [ 3897.127930] hdmi_av_composer [ 3897.130848] dw-hdmi-jz4780 10180000.hdmi: final pixclk =3D 0 But I have no idea if this is the reason or the consequence of the uninitialized lcdc. So we need some DRM specialist to take a look on it. BR and thanks, Nikolaus _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel