From: Bart Van Assche <bvanassche@acm.org>
To: Bean Huo <beanhuo@iokpp.de>,
alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, stanley.chu@mediatek.com,
beanhuo@micron.com, tomas.winkler@intel.com,
daejun7.park@samsung.com, quic_cang@quicinc.com,
quic_nguyenb@quicinc.com, quic_xiaosenh@quicinc.com,
quic_richardp@quicinc.com, quic_asutoshd@quicinc.com,
hare@suse.de
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 7/7] ufs: core: Add advanced RPMB support in ufs_bsg
Date: Thu, 5 Jan 2023 14:37:17 -0800 [thread overview]
Message-ID: <81a10cd9-7b0b-e982-5d24-5f0438e37b63@acm.org> (raw)
In-Reply-To: <20221201140437.549272-8-beanhuo@iokpp.de>
On 12/1/22 06:04, Bean Huo wrote:
> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
> index 5cf81dff60aa..c3dfa8084b5c 100644
> --- a/include/ufs/ufshcd.h
> +++ b/include/ufs/ufshcd.h
> +int ufshcd_advanced_rpmb_req_handler(struct ufs_hba *hba, struct utp_upiu_req *req_upiu,
> + struct utp_upiu_req *rsp_upiu, struct ufs_ehs *ehs_req,
> + struct ufs_ehs *ehs_rsp, int sg_cnt,
> + struct scatterlist *sg_list, enum dma_data_direction dir);
Hi Bean,
I think this patch is the first patch that adds a declaration in
ufshcd.h that uses the enum dma_data_direction data type. That leads to
the following compiler warning:
In file included from drivers/ufs/host/tc-dwc-g210-pci.c:10:
./include/ufs/ufshcd.h:1282:72: warning: ‘enum dma_data_direction’
declared inside parameter list will not be visible outside of this
definition or declaration
1282 | struct scatterlist
*sg_list, enum dma_data_direction dir);
|
^~~~~~~~~~~~~~~~~~
Can you please post a patch to fix this? Adding the following line is
probably sufficient:
#include <linux/dma-direction.h>
This has been detected with the following script:
https://github.com/bvanassche/build-scsi-drivers/blob/main/build-scsi-drivers
Thanks,
Bart.
next prev parent reply other threads:[~2023-01-05 22:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 14:04 [PATCH v3 0/7] UFS Advanced RPMB Bean Huo
2022-12-01 14:04 ` [PATCH v3 1/7] ufs: bsg: Let result in struct ufs_bsg_reply be signed int Bean Huo
2022-12-01 14:04 ` [PATCH v3 2/7] ufs: ufs_bsg: Remove unnecessary length checkup Bean Huo
2022-12-01 14:04 ` [PATCH v3 3/7] ufs: ufs_bsg: Cleanup ufs_bsg_request Bean Huo
2022-12-01 14:04 ` [PATCH v3 4/7] ufs: core: Split ufshcd_map_sg Bean Huo
2022-12-01 14:04 ` [PATCH v3 5/7] ufs: core: Advanced RPMB detection Bean Huo
2022-12-01 14:04 ` [PATCH v3 6/7] ufs: core: Pass EHS length into ufshcd_prepare_req_desc_hdr() Bean Huo
2022-12-01 14:04 ` [PATCH v3 7/7] ufs: core: Add advanced RPMB support in ufs_bsg Bean Huo
2023-01-05 22:37 ` Bart Van Assche [this message]
2023-01-06 14:47 ` Bean Huo
2022-12-30 21:05 ` [PATCH v3 0/7] UFS Advanced RPMB Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81a10cd9-7b0b-e982-5d24-5f0438e37b63@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@iokpp.de \
--cc=beanhuo@micron.com \
--cc=daejun7.park@samsung.com \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_richardp@quicinc.com \
--cc=quic_xiaosenh@quicinc.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.