From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 528EAC07E95 for ; Tue, 20 Jul 2021 08:57:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F34361209 for ; Tue, 20 Jul 2021 08:57:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F34361209 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A2DF16E09A; Tue, 20 Jul 2021 08:57:32 +0000 (UTC) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by gabe.freedesktop.org (Postfix) with ESMTPS id 494836E09A for ; Tue, 20 Jul 2021 08:57:31 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 02BF71FDDC; Tue, 20 Jul 2021 08:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626771450; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZXNnH6D1Q32/FJ1I4xXSlZSda7tbLPV20AyNdNWH554=; b=ripcJOAob/isB17J5mrJMngv5wZ2R0BNMzFnSVeJtHDvOQ/n4P4IqpL7n8w+1z6+Dcmqhj JsiPFnUZ2f+jyqIOoAZOMCnPyud8Kt9sJ6frlZRnc5um4dnH8hFNLiQ/Ol8Da1wWj4D4CW QC7EBUFQI1fKkfcRAbVesSEMtBwsA+c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626771450; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZXNnH6D1Q32/FJ1I4xXSlZSda7tbLPV20AyNdNWH554=; b=Xq/r2Ym8/l5nTKGsZPim+oElzrhM+XwQMDePpRyNuby8CWfs4eXzdxqIGrLu487g72tQhb TCg6hhlcprXMJgBQ== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id CEB0913A2E; Tue, 20 Jul 2021 08:57:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id zsduMfmP9mABEwAAGKfGzw (envelope-from ); Tue, 20 Jul 2021 08:57:29 +0000 Subject: Re: [PATCH] drm/ast: Zero is missing in detect function To: ainux.wang@gmail.com, airlied@redhat.com, airlied@linux.ie, daniel@ffwll.ch References: <20210716015615.9150-1-ainux.wang@gmail.com> From: Thomas Zimmermann Message-ID: <81a3d5e6-7998-b839-9303-c7759eb86907@suse.de> Date: Tue, 20 Jul 2021 10:57:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210716015615.9150-1-ainux.wang@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="643VSKineCFUNxtt919Xxt5YhEyWpbGXz" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sterlingteng@gmail.com, chenhuacai@kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --643VSKineCFUNxtt919Xxt5YhEyWpbGXz Content-Type: multipart/mixed; boundary="ZPumEoFlbOXT7VFWQdcMdwph6HYuYU2bw"; protected-headers="v1" From: Thomas Zimmermann To: ainux.wang@gmail.com, airlied@redhat.com, airlied@linux.ie, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, sterlingteng@gmail.com, chenhuacai@kernel.org Message-ID: <81a3d5e6-7998-b839-9303-c7759eb86907@suse.de> Subject: Re: [PATCH] drm/ast: Zero is missing in detect function References: <20210716015615.9150-1-ainux.wang@gmail.com> In-Reply-To: <20210716015615.9150-1-ainux.wang@gmail.com> --ZPumEoFlbOXT7VFWQdcMdwph6HYuYU2bw Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 16.07.21 um 03:56 schrieb ainux.wang@gmail.com: > From: "Ainux.Wang" >=20 > The function ast_get_modes() will also return 0, when it try to get the= > edid, but it also do not get the edid. >=20 > Signed-off-by: Ainux.Wang Acked-by: Thomas Zimmermann after the issue has been discussed a bit. I'll merge the patch into=20 drm-misc-next soon. Best regards Thomas > --- > drivers/gpu/drm/ast/ast_mode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_m= ode.c > index e5996ae03c49..b7dcf7821ec6 100644 > --- a/drivers/gpu/drm/ast/ast_mode.c > +++ b/drivers/gpu/drm/ast/ast_mode.c > @@ -1299,7 +1299,7 @@ static enum drm_connector_status ast_connector_de= tect(struct drm_connector > int r; > =20 > r =3D ast_get_modes(connector); > - if (r < 0) > + if (r <=3D 0) > return connector_status_disconnected; > =20 > return connector_status_connected; >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --ZPumEoFlbOXT7VFWQdcMdwph6HYuYU2bw-- --643VSKineCFUNxtt919Xxt5YhEyWpbGXz Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmD2j/kFAwAAAAAACgkQlh/E3EQov+A8 rQ//esrncfgqyM9hFmFhbFxmpEqO9cods184rjfYzA0z1pYJiJcLk7f3Ty802IbGdLQFMHmAE0R4 qKNb3a0BS7mSiM3ompMlxbcQi6JtCmobpg6bcQPn/GUPP2WnAZCuVueRJ7VXQKoXc0wlfJ5E3K50 A6uhPihY56N3jxWk2kaVsCIiwGbkEMORswK2YKujvLisn8i3pmZZtHS65rDk+Da3S/XpWH23Ib4f k1Ye3S8iKunD48kUQ5KdWdLsYyHEgAyf/j8goZTvPImwEFu08DQ5mbQuN55Y5hKUJIALKdj4jdAy ri+162Lonr15tbFT4e8iFbnFZIbktG27LnRwlUZIbD/nJcu+Nm3+TOnMsGFe180FPIxL45PzaUt8 5KLiX9TEvs946eN/o9Dtwf7398Nz+rNFs/nurY2AT5hzJ+VoZDN52OMti/1z52TCAdP51KZ0SCcO wBPcXRnLugryK27V+hlTj5ImgRaUfcGvVGGNBtFBbB0PVoXgiWfGNp6uO1EA41U1wtirr1I4iKvC ZCxZzn9QVlO2qXu2IshM6/8JNum7/GHwqFWHR6JDJ6IGhG1RiTH7vv0MDdvqjkFDJBk6o30WMm2z 2Kle2xEt3Dg66lUSns5k9KqtuJz4uzJFISX8jyF/ZG0t75LP05trv0dWH6QpiPJ6MdLsDJy4gki+ xFY= =D5Pp -----END PGP SIGNATURE----- --643VSKineCFUNxtt919Xxt5YhEyWpbGXz--