From: "Alex Riesen" <raa.lkml@gmail.com>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Cc: "Junio C Hamano" <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] config_set_multivar(): disallow newlines in keys
Date: Mon, 22 Jan 2007 16:06:50 +0100 [thread overview]
Message-ID: <81b0412b0701220706w65ed0657h1d69819e7879ed40@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.63.0701200224180.22628@wbgn013.biozentrum.uni-wuerzburg.de>
On 1/20/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> --- a/config.c
> +++ b/config.c
> @@ -661,6 +661,11 @@ int git_config_set_multivar(const char* key, const char* value,
> goto out_free;
> }
> c = tolower(c);
> + } else if (c == '\n') {
> + fprintf(stderr, "invalid key (newline): %s\n", key);
BTW, why config.c never uses error() or warn()?
next prev parent reply other threads:[~2007-01-22 15:06 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-15 0:44 [RFC] Git config file reader in Perl (WIP) Jakub Narebski
2007-01-15 7:08 ` Eric Wong
2007-01-15 9:03 ` Jakub Narebski
2007-01-15 9:56 ` Eric Wong
2007-01-15 10:01 ` Shawn O. Pearce
2007-01-15 10:32 ` Jakub Narebski
2007-01-15 11:26 ` Eric Wong
2007-01-15 12:15 ` Johannes Schindelin
2007-01-15 15:34 ` Nikolai Weibull
2007-01-15 15:44 ` Johannes Schindelin
2007-01-15 16:22 ` Nikolai Weibull
2007-01-15 16:00 ` Jakub Narebski
2007-01-16 10:45 ` Junio C Hamano
2007-01-16 11:12 ` Johannes Schindelin
2007-01-16 14:14 ` Jakub Narebski
2007-01-16 22:17 ` Nikolai Weibull
2007-01-16 22:37 ` Jakub Narebski
2007-01-16 22:56 ` Johannes Schindelin
2007-01-16 23:24 ` Jakub Narebski
2007-01-17 8:51 ` Johannes Schindelin
2007-01-17 9:48 ` Jakub Narebski
2007-01-17 10:44 ` Johannes Schindelin
2007-01-17 12:11 ` Jakub Narebski
2007-01-17 12:37 ` Johannes Schindelin
2007-01-17 14:00 ` Jakub Narebski
2007-01-19 12:10 ` Jakub Narebski
2007-01-19 12:25 ` Jakub Narebski
2007-01-19 13:20 ` Johannes Schindelin
2007-01-19 22:44 ` Jakub Narebski
2007-01-20 0:08 ` Johannes Schindelin
2007-01-20 0:59 ` Jakub Narebski
2007-01-20 0:19 ` Junio C Hamano
2007-01-20 1:25 ` [PATCH] config_set_multivar(): disallow newlines in keys Johannes Schindelin
2007-01-20 1:40 ` Junio C Hamano
2007-01-22 15:06 ` Alex Riesen [this message]
2007-01-22 15:21 ` Johannes Schindelin
2007-01-22 15:33 ` Alex Riesen
2007-01-22 15:44 ` Johannes Schindelin
2007-01-22 16:09 ` Alex Riesen
2007-01-23 11:26 ` Johannes Schindelin
2007-01-23 12:47 ` Alex Riesen
2007-01-20 14:03 ` [PATCH] Documentation/config.txt: Document config file syntax better Jakub Narebski
2007-01-22 15:25 ` Jakub Narebski
2007-01-24 14:14 ` [PATCH 2/1] Documentation/config.txt: Correct info about subsection name Jakub Narebski
2007-01-16 22:42 ` [RFC] Git config file reader in Perl (WIP) Johannes Schindelin
2007-01-17 18:08 ` Nikolai Weibull
2007-01-17 19:22 ` Jakub Narebski
2007-01-17 20:01 ` Nikolai Weibull
2007-01-17 19:25 ` Jakub Narebski
2007-01-18 0:50 ` Johannes Schindelin
2007-01-16 19:09 ` Eric Wong
2007-01-16 9:51 ` Eric Wong
2007-01-16 10:47 ` Johannes Schindelin
2007-01-16 19:53 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81b0412b0701220706w65ed0657h1d69819e7879ed40@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.