From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B90EC10DCE for ; Thu, 12 Mar 2020 10:21:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D997220674 for ; Thu, 12 Mar 2020 10:21:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726756AbgCLKVn (ORCPT ); Thu, 12 Mar 2020 06:21:43 -0400 Received: from smtprelay0016.hostedemail.com ([216.40.44.16]:42982 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725268AbgCLKVn (ORCPT ); Thu, 12 Mar 2020 06:21:43 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 5C1362C94; Thu, 12 Mar 2020 10:21:42 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: thumb39_48ee4dd62f451 X-Filterd-Recvd-Size: 1674 Received: from XPS-9350.home (unknown [47.151.143.254]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Thu, 12 Mar 2020 10:21:41 +0000 (UTC) Message-ID: <81bad451e9ffee6990ffc3571bc7b558c1c26bb3.camel@perches.com> Subject: Re: [PATCH -next 006/491] ARM/RISCPC ARCHITECTURE: Use fallthrough; From: Joe Perches To: Russell King - ARM Linux admin Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Date: Thu, 12 Mar 2020 03:19:57 -0700 In-Reply-To: <20200312101130.GX25745@shell.armlinux.org.uk> References: <20200312101130.GX25745@shell.armlinux.org.uk> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-03-12 at 10:11 +0000, Russell King - ARM Linux admin wrote: > On Tue, Mar 10, 2020 at 09:51:20PM -0700, Joe Perches wrote: > > Convert the various uses of fallthrough comments to fallthrough; > > And the point of what on the face of it seems to be useless churn is? > > What compilers support this? gcc 7.1, clang 9 clang does not support the /* fallthrough */ comment styles. clang does support the __attribute__((__fallthrough__)) and the c++17 [[fallthrough]] weirdness. see: commit 294f69e662d1 ("compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use") From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FCA1C1975A for ; Thu, 12 Mar 2020 10:21:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EADA120674 for ; Thu, 12 Mar 2020 10:21:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Nyew5Iu/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EADA120674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1sWV/1Q/hNsPbCMHrCbIAlAijpPq6a/TOKHDcEEZkbo=; b=Nyew5Iu/DjHbgB 83UwVOp00XrMnyW/6CY4VUHB9isTZndPbMxDbSDQA6Cfa0jgcjHGBZ07Tan65ALjzu0F4+dMh86M8 RU7+Qm8ex+QA2pC2HgF0zsFCotk+gz+3rgNuasT/s1PgKI16yrn687+uAfQ/da0Ln7feyN60Mi8T1 Ky6xEl5KtMw5dWCxK4im6huIRHKcp8P7+v4E/jckQhWtmWbnSUI53Y96U0WZWbVPYOJfOnwWiepBR xIBW7N59xQFufBfH8kpzV6uv68q0Gxndmk6DZrRaqqRfQR+p3PrDxZmpUpHFSe18dH1iEHZWtdKSo MhaxrcllOUcsYSDqXdlA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCKyO-0005Gp-CE; Thu, 12 Mar 2020 10:21:52 +0000 Received: from smtprelay0137.hostedemail.com ([216.40.44.137] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCKyK-0005G9-Kg for linux-arm-kernel@lists.infradead.org; Thu, 12 Mar 2020 10:21:49 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 5C1362C94; Thu, 12 Mar 2020 10:21:42 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: thumb39_48ee4dd62f451 X-Filterd-Recvd-Size: 1674 Received: from XPS-9350.home (unknown [47.151.143.254]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Thu, 12 Mar 2020 10:21:41 +0000 (UTC) Message-ID: <81bad451e9ffee6990ffc3571bc7b558c1c26bb3.camel@perches.com> Subject: Re: [PATCH -next 006/491] ARM/RISCPC ARCHITECTURE: Use fallthrough; From: Joe Perches To: Russell King - ARM Linux admin Date: Thu, 12 Mar 2020 03:19:57 -0700 In-Reply-To: <20200312101130.GX25745@shell.armlinux.org.uk> References: <20200312101130.GX25745@shell.armlinux.org.uk> User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200312_032148_738561_97976CE9 X-CRM114-Status: UNSURE ( 8.60 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-scsi@vger.kernel.org, "James E.J. Bottomley" , linux-arm-kernel@lists.infradead.org, "Martin K. Petersen" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-03-12 at 10:11 +0000, Russell King - ARM Linux admin wrote: > On Tue, Mar 10, 2020 at 09:51:20PM -0700, Joe Perches wrote: > > Convert the various uses of fallthrough comments to fallthrough; > > And the point of what on the face of it seems to be useless churn is? > > What compilers support this? gcc 7.1, clang 9 clang does not support the /* fallthrough */ comment styles. clang does support the __attribute__((__fallthrough__)) and the c++17 [[fallthrough]] weirdness. see: commit 294f69e662d1 ("compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use") _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel