All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>,
	dev@dpdk.org, John McNamara <john.mcnamara@intel.com>,
	Keith Wiles <keith.wiles@intel.com>
Subject: Re: [PATCH 3/4] mk: add new test-run make rule
Date: Wed, 15 Feb 2017 17:41:08 +0000	[thread overview]
Message-ID: <81cc47aa-73dc-bd6c-6442-51571585cbfe@intel.com> (raw)
In-Reply-To: <20170215170724.GA89892@bricha3-MOBL3.ger.corp.intel.com>

On 2/15/2017 5:07 PM, Bruce Richardson wrote:
> On Wed, Feb 15, 2017 at 03:26:31PM +0000, Ferruh Yigit wrote:
>> Since "make test" and "make test-build" does dependency resolving, they
>> check for all dependent components (lib and drivers) which takes a few
>> seconds.
>>
>> This is a good feature during development, but if the target is just
>> running unit test, that step is unnecessary, it is possible to compile
>> onece and run unit test multiple times, without checking any code update
>>
>> For this purpose, a new make rule "make test-run" added. Which just runs
>> the unit test, expects that unit test already compiled.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
> Sorry, I just don't see the point of having an extra command to maintain
> and document for the sake of a few seconds on a unit test run. How long
> does the run itself take compared to the time to check dependencies? 

It is matter of choice, it does not take much time for "make test", but
still I thought it is handy to have a rule only to run the test.

I don't expect much maintenance cost with this, also I don't have strong
opinion to keep it.

> 
> /Bruce
> 

  reply	other threads:[~2017-02-15 17:41 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 15:13 [RFC 17.05] test: move tests to separate folder Ferruh Yigit
2017-02-14 15:41 ` Bruce Richardson
2017-02-14 15:51   ` Wiles, Keith
2017-02-14 16:12   ` Mcnamara, John
2017-02-15  9:03     ` Thomas Monjalon
2017-02-14 17:07   ` Ferruh Yigit
2017-02-14 17:30     ` Richardson, Bruce
2017-02-15  2:11       ` Yuanhan Liu
2017-02-15 10:06         ` Ferruh Yigit
2017-02-15 11:16           ` Thomas Monjalon
2017-02-15 11:28             ` Ferruh Yigit
2017-02-14 16:15 ` Mcnamara, John
2017-02-15 15:26 ` [PATCH 1/4] " Ferruh Yigit
2017-02-15 15:26   ` [PATCH 2/4] mk: do not build tests by default Ferruh Yigit
2017-02-15 16:58     ` Thomas Monjalon
2017-02-15 17:30       ` Ferruh Yigit
2017-02-16  8:53         ` Thomas Monjalon
2017-02-16 10:07           ` Ferruh Yigit
2017-02-15 15:26   ` [PATCH 3/4] mk: add new test-run make rule Ferruh Yigit
2017-02-15 17:07     ` Bruce Richardson
2017-02-15 17:41       ` Ferruh Yigit [this message]
2017-02-16  9:08         ` Bruce Richardson
2017-02-16  9:26     ` Thomas Monjalon
2017-02-16 10:21       ` Ferruh Yigit
2017-02-16 10:44         ` Thomas Monjalon
2017-02-15 15:26   ` [PATCH 4/4] mk: rename test related make rules Ferruh Yigit
2017-02-16  9:10   ` [PATCH 1/4] test: move tests to separate folder Bruce Richardson
2017-02-16 14:57   ` [PATCH v2 1/5] " Ferruh Yigit
2017-02-16 14:57     ` [PATCH v2 2/5] mk: do not build tests by default Ferruh Yigit
2017-02-16 14:57     ` [PATCH v2 3/5] mk: add new test-basic make rule Ferruh Yigit
2017-02-16 14:57     ` [PATCH v2 4/5] mk: rename test related make rules Ferruh Yigit
2017-02-16 14:57     ` [PATCH v2 5/5] doc: document test related make rules in make help Ferruh Yigit
2017-02-20 15:23       ` Mcnamara, John
2017-02-28 15:19     ` [PATCH v2 1/5] test: move tests to separate folder Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81cc47aa-73dc-bd6c-6442-51571585cbfe@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=keith.wiles@intel.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.