From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v8 06/13] drm/i915/perf: implement active wait for noa configurations
Date: Thu, 11 Jul 2019 10:47:19 +0300 [thread overview]
Message-ID: <81e170bc-dd7c-194d-0211-ef312ac1ea46@intel.com> (raw)
In-Reply-To: <156282659660.12280.4199368775706498585@skylake-alporthouse-com>
On 11/07/2019 09:29, Chris Wilson wrote:
> Quoting Umesh Nerlige Ramappa (2019-07-11 00:43:21)
>> On Tue, Jul 09, 2019 at 03:33:44PM +0300, Lionel Landwerlin wrote:
>>> +static u32 *save_register(struct drm_i915_private *i915, u32 *cs,
>>> + i915_reg_t reg, u32 offset, u32 dword_count)
>>> +{
>>> + uint32_t d;
>>> +
>>> + for (d = 0; d < dword_count; d++) {
>>> + *cs++ = INTEL_GEN(i915) >= 8 ?
>>> + MI_STORE_REGISTER_MEM_GEN8 : MI_STORE_REGISTER_MEM;
>>> + *cs++ = i915_mmio_reg_offset(reg) + 4 * d;
>>> + *cs++ = intel_gt_scratch_offset(&i915->gt, offset) + 4 * d;
>>> + *cs++ = 0;
>>> + }
>>> +
>>> + return cs;
>>> +}
>>> +
>>> +static u32 *restore_register(struct drm_i915_private *i915, u32 *cs,
>>> + i915_reg_t reg, u32 offset, u32 dword_count)
>>> +{
>>> + uint32_t d;
>>> +
>>> + for (d = 0; d < dword_count; d++) {
>>> + *cs++ = INTEL_GEN(i915) >= 8 ?
>>> + MI_LOAD_REGISTER_MEM_GEN8 : MI_LOAD_REGISTER_MEM;
>>> + *cs++ = i915_mmio_reg_offset(reg);
>>> + *cs++ = intel_gt_scratch_offset(&i915->gt, offset);
>> are you missing + 4 * d in the above 2 lines?
> Whoops bad reviewer. Since these are the same two loops just with a
> different cmd...
> -Chris
>
Thanks Umesh!
I've merged these 2 function locally. I'm about to resend.
-Lionel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-07-11 7:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 12:33 [PATCH v8 00/13] drm/i915: Vulkan performance query support Lionel Landwerlin
2019-07-09 12:33 ` [PATCH v8 01/13] drm/i915/perf: ensure we keep a reference on the driver Lionel Landwerlin
2019-07-09 12:33 ` [PATCH v8 02/13] drm/i915/perf: add missing delay for OA muxes configuration Lionel Landwerlin
2019-07-09 12:33 ` [PATCH v8 03/13] drm/i915/perf: introduce a versioning of the i915-perf uapi Lionel Landwerlin
2019-07-09 12:33 ` [PATCH v8 04/13] drm/i915/perf: allow for CS OA configs to be created lazily Lionel Landwerlin
2019-07-09 12:33 ` [PATCH v8 05/13] drm/i915: enumerate scratch fields Lionel Landwerlin
2019-07-09 12:33 ` [PATCH v8 06/13] drm/i915/perf: implement active wait for noa configurations Lionel Landwerlin
2019-07-10 23:43 ` Umesh Nerlige Ramappa
[not found] ` <156282659660.12280.4199368775706498585@skylake-alporthouse-com>
2019-07-11 7:47 ` Lionel Landwerlin [this message]
2019-07-09 12:33 ` [PATCH v8 07/13] drm/i915: introduce a mechanism to extend execbuf2 Lionel Landwerlin
2019-07-09 12:33 ` [PATCH v8 08/13] drm/i915: add syncobj timeline support Lionel Landwerlin
2019-07-09 12:33 ` [PATCH v8 09/13] drm/i915: add a new perf configuration execbuf parameter Lionel Landwerlin
2019-07-09 12:53 ` Lionel Landwerlin
2019-07-09 13:10 ` Chris Wilson
2019-07-09 13:13 ` Chris Wilson
2019-07-10 11:09 ` Chris Wilson
2019-07-09 12:33 ` [PATCH v8 10/13] drm/i915: add infrastructure to hold off preemption on a request Lionel Landwerlin
2019-07-09 14:18 ` Chris Wilson
2019-07-09 12:33 ` [PATCH v8 11/13] drm/i915/perf: allow holding preemption on filtered ctx Lionel Landwerlin
2019-07-09 12:33 ` [PATCH v8 12/13] drm/i915/perf: execute OA configuration from command stream Lionel Landwerlin
2019-07-09 12:33 ` [PATCH v8 13/13] drm/i915: add support for perf configuration queries Lionel Landwerlin
2019-07-10 11:04 ` Chris Wilson
2019-07-09 13:08 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Vulkan performance query support (rev8) Patchwork
2019-07-09 13:15 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-07-09 13:27 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-09 20:30 ` [PATCH v8 00/13] drm/i915: Vulkan performance query support Chris Wilson
2019-07-10 9:06 ` Lionel Landwerlin
2019-07-10 1:20 ` ✗ Fi.CI.IGT: failure for drm/i915: Vulkan performance query support (rev8) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81e170bc-dd7c-194d-0211-ef312ac1ea46@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.