From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D650C4332F for ; Thu, 13 Oct 2022 13:22:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229995AbiJMNWk (ORCPT ); Thu, 13 Oct 2022 09:22:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229945AbiJMNW0 (ORCPT ); Thu, 13 Oct 2022 09:22:26 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63B71F0358 for ; Thu, 13 Oct 2022 06:22:23 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id j16so2827916wrh.5 for ; Thu, 13 Oct 2022 06:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/A5M/mERnholVn2sPhllr5YgwOSnfIz8uR3LS/h5QWE=; b=JVsZ5Ne5IoFw/6lLM2Z+zUzAl/UqQKH5ocJHyB/wFFpTeMtrMGMGAikZpm1S8siyAs 3LI4AzEMTO0rCv7SwQqXBtojACXkUsIgwJgD2eFPWTNYDGQkMOonfYtxpt3vEe4pTxi9 fei8Lm7Pstpha26mYXnkInKqSQsT/uoxCzsT9YYJTFvvooaywZx/aANtaMY7FuENzpHn 5T6uegYWQwapWdPebllY8f7G1hjkvb4Bm0z2xm/1ojZX3UL6NxSctiPuPIj4iP33biuW ZiNBFKIeTxkLHWXLZNCLubXGJRrvhOhETU3Gi4wD11xO2sYS3ePzlAdChAP91FoeKyDC nwcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/A5M/mERnholVn2sPhllr5YgwOSnfIz8uR3LS/h5QWE=; b=HMqQ9k6aMpTg+5izl3soY0gZTUpAwT/rlwKziwpCyYmJGaFf9eo0Usnsti/xgQjl+X HQMkKsD7PTJFxR8yRWCrR+EHczZ6ivN+vea3vLTZe2LwQCvyScWt5dKLTZkoEz2O3gCx KyYmdST/8PCDiymPyq+xy4y+PcLX2r7G5lc/A/gvNmjCXLynzlRA07btizn2/bmmyHt+ zNoZodo/plbnGUDfRwyPjcKXgTQX2mZQ3CFEz6grqj2F8fBQvRufUgThqKbbVRI6Iru8 35gxy49PQAP/ExIA5A1ckl0fEi+MwWScJHg13M9vJs+gaTMXPGhYtN5+Gvz3AS4MdbjA P02w== X-Gm-Message-State: ACrzQf03jZOqkEIw8Y+YMYBqWnSg+aHYsGRpIdzFz92KpeV7vOnLd9PW lx9ymichpaSgOjAN5FUQz0dDXg== X-Google-Smtp-Source: AMsMyM42+wJuePysW3q25cWDaRQocIly51kR7f7+oxcIFEVdZpzwuYLtz7MrX5w8AAflktcRjAS/qg== X-Received: by 2002:adf:dec3:0:b0:22e:6efe:7861 with SMTP id i3-20020adfdec3000000b0022e6efe7861mr21667996wrn.454.1665667341768; Thu, 13 Oct 2022 06:22:21 -0700 (PDT) Received: from [192.168.1.91] (192.201.68.85.rev.sfr.net. [85.68.201.192]) by smtp.gmail.com with ESMTPSA id u8-20020adfdb88000000b0022e035a4e93sm2083628wri.87.2022.10.13.06.22.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Oct 2022 06:22:21 -0700 (PDT) Message-ID: <81e3a8d8-9c20-6711-f2c9-54c366aab276@baylibre.com> Date: Thu, 13 Oct 2022 15:22:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules Content-Language: en-US To: Krzysztof Kozlowski , Kevin Hilman , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, lee@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com Cc: afd@ti.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-7-jneanne@baylibre.com> <72b9809e-d6d7-862a-26b8-221d14ea4322@linaro.org> <60507e87-cf92-13d9-29d0-83f18a648f4b@baylibre.com> <7hzge1hqof.fsf@baylibre.com> <8d27a5f6-461a-5b28-1560-07bb4ddcaa8a@linaro.org> From: jerome Neanne In-Reply-To: <8d27a5f6-461a-5b28-1560-07bb4ddcaa8a@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/10/2022 14:32, Krzysztof Kozlowski wrote: > On 12/10/2022 13:56, Kevin Hilman wrote: >> Krzysztof Kozlowski writes: >> >>> On 12/10/2022 04:39, jerome Neanne wrote: >>>>> You explained what you did, which is easily visible. You did not explain >>>>> why you are doing it. >>>>> >>>>> Best regards, >>>>> Krzysztof >>>>> >>>> Thanks for pointing me to the detailed guidelines >>>> I'm new to upstream and not well aware of all good practices. >>>> >>>> Would below commit message be more suitable: >>>> >>>> Add support for the TPS65219 PMIC by enabling MFD, regulator and >>>> power-button drivers. All drivers enabled as modules. >>> >>> This still says only what you did. I still does not explain why. >> >> Jerome, maybe adding a bit of preamble like: >> >> "Development boards from TI include the TPS65219 PMIC. Add support..." > > I would propose: "Development boards from TI with xxx SoC include the > ..." because the point is that you use this defconfig for boards for > given SoC (supported by upstream). > > Other way would be "Foo-bar development board includes the TP..." > >> >> Krzysztof, I'm the first to argue for descriptive/verbose changelogs, >> but IMO, this is getting a little bit nit-picky. >> >> The series adds a new driver, DTS and defconfig patches to enable >> support the new driver. The "why" for changes to defconfig changes like >> this are kind of implied/obvious, and there is lots of precedent for >> changelogs of defconfig changes for simple drivers to simply say "enable >> X and Y". > > While I understand the entire patchset, the defconfig goes via separate > tree/branch and must stand on its own. Later (one month, one year, one > decade) someone will look at history and wonder why the heck we enabled > TPS65219. > >> >> If my above suggesion is not enough, please make a suggestion for what >> you think would qualify as an appropritate changelong that answers "why" >> for a simple driver change. > > It is enough :) > > Best regards, > Krzysztof > Got it! I'll rephrase following your suggestion From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 682BBC4332F for ; Thu, 13 Oct 2022 13:46:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MGbDb/pCdWED/I6Bv75/tZrQbQyrT7czjNVBcraHJq8=; b=Lxyg16P/qfE3/Z rrP4keICdCN65s1WyViUwS17aYoqOYDUJZTETeu63ndK4oQubAue4/eymgjKRR9VCA4xbweglN8i/ 9bKgn7NdCcjDpKBloG3tyqzUy2XCFPNmLvcHom/bmHOkyIb0wAslYXKVxAyFihM2ivZUHWrg/UqSa 4JEVpD6VGEwqgrLHirLuZgO6wNrd5INK3o9UcGnUAgWa1CqUKhfaaTjMsaBYIFLEU2VfVNsnmDWSK CmhBxwwBq+R0/wIwArXVt9An6NRzAry0g8cbHANOVA7cjT/IRofa5vQPljDoc4In9O8/ibB4+FT5S m3t8vbdIM4N4vXoeSlcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiyVc-00BxHm-Tw; Thu, 13 Oct 2022 13:44:25 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiyAK-00Bq4u-MW for linux-arm-kernel@lists.infradead.org; Thu, 13 Oct 2022 13:22:27 +0000 Received: by mail-wr1-x42a.google.com with SMTP id n12so2792953wrp.10 for ; Thu, 13 Oct 2022 06:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/A5M/mERnholVn2sPhllr5YgwOSnfIz8uR3LS/h5QWE=; b=JVsZ5Ne5IoFw/6lLM2Z+zUzAl/UqQKH5ocJHyB/wFFpTeMtrMGMGAikZpm1S8siyAs 3LI4AzEMTO0rCv7SwQqXBtojACXkUsIgwJgD2eFPWTNYDGQkMOonfYtxpt3vEe4pTxi9 fei8Lm7Pstpha26mYXnkInKqSQsT/uoxCzsT9YYJTFvvooaywZx/aANtaMY7FuENzpHn 5T6uegYWQwapWdPebllY8f7G1hjkvb4Bm0z2xm/1ojZX3UL6NxSctiPuPIj4iP33biuW ZiNBFKIeTxkLHWXLZNCLubXGJRrvhOhETU3Gi4wD11xO2sYS3ePzlAdChAP91FoeKyDC nwcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/A5M/mERnholVn2sPhllr5YgwOSnfIz8uR3LS/h5QWE=; b=iaSIBSbUvLBCSuJN09Nd6C4dPetGLKT3LL+1tD0FCsi9ncp7EIBNUZuv0lc7vp1biU 4d1LjJNvCDiAGfQSTSWjwP5Z9IulH3eKwDy1jVfZ9YpmecOde98pJXckljwy4ISiUUEI OavHBzQZ8AU4WKsa1JHgiHGRvWrKzVKiJ3b0CH97Hw6nxVgHDaDk/MEvMmB37PPHrL6n BDDo9GvZJOv8oZtorV/Q61FpFO5TXwhon9xr0uF/MmcaRmUb/rGRIaPpaIvRzSjv6VWG LWb/7XyIWwf6rL/cDLtvgnKi7maA9IzhbVAjquKWsqJsOXFFilLeTu2bUDtHMFimjPMT h3ZQ== X-Gm-Message-State: ACrzQf02Cx10DmGckbnOoeQwLqKp/ViZUTMn6HAoFAiyn08uJpJam6IK ohTPhpKZN6PFb2vBuP+4s/gZgw== X-Google-Smtp-Source: AMsMyM42+wJuePysW3q25cWDaRQocIly51kR7f7+oxcIFEVdZpzwuYLtz7MrX5w8AAflktcRjAS/qg== X-Received: by 2002:adf:dec3:0:b0:22e:6efe:7861 with SMTP id i3-20020adfdec3000000b0022e6efe7861mr21667996wrn.454.1665667341768; Thu, 13 Oct 2022 06:22:21 -0700 (PDT) Received: from [192.168.1.91] (192.201.68.85.rev.sfr.net. [85.68.201.192]) by smtp.gmail.com with ESMTPSA id u8-20020adfdb88000000b0022e035a4e93sm2083628wri.87.2022.10.13.06.22.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Oct 2022 06:22:21 -0700 (PDT) Message-ID: <81e3a8d8-9c20-6711-f2c9-54c366aab276@baylibre.com> Date: Thu, 13 Oct 2022 15:22:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules Content-Language: en-US To: Krzysztof Kozlowski , Kevin Hilman , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, lee@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com Cc: afd@ti.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-7-jneanne@baylibre.com> <72b9809e-d6d7-862a-26b8-221d14ea4322@linaro.org> <60507e87-cf92-13d9-29d0-83f18a648f4b@baylibre.com> <7hzge1hqof.fsf@baylibre.com> <8d27a5f6-461a-5b28-1560-07bb4ddcaa8a@linaro.org> From: jerome Neanne In-Reply-To: <8d27a5f6-461a-5b28-1560-07bb4ddcaa8a@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221013_062224_782368_F8C1B535 X-CRM114-Status: GOOD ( 22.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/10/2022 14:32, Krzysztof Kozlowski wrote: > On 12/10/2022 13:56, Kevin Hilman wrote: >> Krzysztof Kozlowski writes: >> >>> On 12/10/2022 04:39, jerome Neanne wrote: >>>>> You explained what you did, which is easily visible. You did not explain >>>>> why you are doing it. >>>>> >>>>> Best regards, >>>>> Krzysztof >>>>> >>>> Thanks for pointing me to the detailed guidelines >>>> I'm new to upstream and not well aware of all good practices. >>>> >>>> Would below commit message be more suitable: >>>> >>>> Add support for the TPS65219 PMIC by enabling MFD, regulator and >>>> power-button drivers. All drivers enabled as modules. >>> >>> This still says only what you did. I still does not explain why. >> >> Jerome, maybe adding a bit of preamble like: >> >> "Development boards from TI include the TPS65219 PMIC. Add support..." > > I would propose: "Development boards from TI with xxx SoC include the > ..." because the point is that you use this defconfig for boards for > given SoC (supported by upstream). > > Other way would be "Foo-bar development board includes the TP..." > >> >> Krzysztof, I'm the first to argue for descriptive/verbose changelogs, >> but IMO, this is getting a little bit nit-picky. >> >> The series adds a new driver, DTS and defconfig patches to enable >> support the new driver. The "why" for changes to defconfig changes like >> this are kind of implied/obvious, and there is lots of precedent for >> changelogs of defconfig changes for simple drivers to simply say "enable >> X and Y". > > While I understand the entire patchset, the defconfig goes via separate > tree/branch and must stand on its own. Later (one month, one year, one > decade) someone will look at history and wonder why the heck we enabled > TPS65219. > >> >> If my above suggesion is not enough, please make a suggestion for what >> you think would qualify as an appropritate changelong that answers "why" >> for a simple driver change. > > It is enough :) > > Best regards, > Krzysztof > Got it! I'll rephrase following your suggestion _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel