From: Mimi Zohar <zohar@linux.ibm.com>
To: Jianglei Nie <niejianglei2021@163.com>,
dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com
Cc: linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ima/evm: Fix potential memory leak in ima_init_crypto()
Date: Mon, 11 Jul 2022 08:04:01 -0400 [thread overview]
Message-ID: <81ea189fd671947efc61000a745599a4b0573370.camel@linux.ibm.com> (raw)
In-Reply-To: <20220711072202.2319030-1-niejianglei2021@163.com>
On Mon, 2022-07-11 at 15:22 +0800, Jianglei Nie wrote:
> This patch adds the missing kfree() for ima_algo_array allocated by
> kcalloc() to avoid potential memory leak.
Missing is the reason that ima_algo_array is being freed.
Perhaps something like,
"On failure to allocate the SHA1 tfm, IMA fails to initialize and exits
without freeing the ima_algo_array. Add the missing kfree() for
ima_algo_array to avoid the potential memory leak."
thanks,
Mimi
next prev parent reply other threads:[~2022-07-11 12:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 7:22 [PATCH] ima/evm: Fix potential memory leak in ima_init_crypto() Jianglei Nie
2022-07-11 12:04 ` Mimi Zohar [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-07-04 0:59 Jianglei Nie
2022-07-07 3:19 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81ea189fd671947efc61000a745599a4b0573370.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=jmorris@namei.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=niejianglei2021@163.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.