From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74EFEC10F03 for ; Fri, 1 Mar 2019 14:36:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C8212084F for ; Fri, 1 Mar 2019 14:36:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388686AbfCAOgy (ORCPT ); Fri, 1 Mar 2019 09:36:54 -0500 Received: from m97179.mail.qiye.163.com ([220.181.97.179]:19006 "EHLO m97179.mail.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387965AbfCAOgx (ORCPT ); Fri, 1 Mar 2019 09:36:53 -0500 Received: from [192.168.0.107] (unknown [116.234.7.57]) by m97179.mail.qiye.163.com (Hmail) with ESMTPA id 3AE09E013EF; Fri, 1 Mar 2019 22:36:48 +0800 (CST) Subject: Re: [PATCH net-next] net: ipv4: Fix NULL pointer dereference in route lookup To: Ido Schimmel , "netdev@vger.kernel.org" Cc: "davem@davemloft.net" , "dsahern@gmail.com" , mlxsw References: <20190301133810.8107-1-idosch@mellanox.com> From: wenxu Message-ID: <81f7adde-49ad-6d74-edf4-ad7011716540@ucloud.cn> Date: Fri, 1 Mar 2019 22:36:47 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190301133810.8107-1-idosch@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-HM-Spam-Status: e1kIGBQJHllBS1VLV1koWUFJQjdXWS1ZQUlXWQkOFx4IWUFZMjUtOjcyP0 FLVUtZBg++ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NiI6Ejo4QjlOMwwsSxMzL0oK TRRPCzlVSlVKTk5KT05KS0tDT0xCVTMWGhIXVQweFQMOOw4YFxQOH1UYFUVZV1kSC1lBWUpKTVVJ SE9VTFVOTFlXWQgBWUFJSE5DNwY+ X-HM-Tid: 0a6939afada920bdkuqy3ae09e013ef Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019/3/1 下午9:38, Ido Schimmel wrote: > When calculating the multipath hash for input routes the flow info is > not available and therefore should not be used. > > Fixes: 24ba14406c5c ("route: Add multipath_hash in flowi_common to make user-define hash") > Signed-off-by: Ido Schimmel > Cc: wenxu > --- > net/ipv4/route.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv4/route.c b/net/ipv4/route.c > index 7cf4c8305071..e3ac458b5d8b 100644 > --- a/net/ipv4/route.c > +++ b/net/ipv4/route.c > @@ -1820,7 +1820,7 @@ static void ip_multipath_l3_keys(const struct sk_buff *skb, > int fib_multipath_hash(const struct net *net, const struct flowi4 *fl4, > const struct sk_buff *skb, struct flow_keys *flkeys) > { > - u32 multipath_hash = fl4->flowi4_multipath_hash; > + u32 multipath_hash = fl4 ? fl4->flowi4_multipath_hash : 0; > struct flow_keys hash_keys; > u32 mhash; > Acked-by: wenxu